bingo-soft / jabe

src/Impl/Cmd/DeleteJobsCmd.php

<?php

namespace Jabe\Impl\Cmd;

use Jabe\Impl\Context\Context;
use Jabe\Impl\Interceptor\{
    CommandInterface,
    CommandContext
};

class DeleteJobsCmd implements CommandInterface
{
    protected $jobIds = [];
    protected $cascade;

    public function __construct($jobIds, ?bool $cascade = false)
    {
        if (is_string($jobIds)) {
            $this->jobIds[] = $jobIds;
        } elseif (is_array($jobIds)) {
            $this->jobIds = $jobIds;
        }
        $this->cascade = $cascade;
    }

    public function execute(CommandContext $commandContext)
    {
        $jobToDelete = null;

The assignment to $jobToDelete is dead and can be removed.

        foreach ($this->jobIds as $jobId) {
            $jobToDelete = Context::getCommandContext()
            ->getJobManager()
            ->findJobById($jobId);

            if ($jobToDelete !== null) {
                // When given job doesn't exist, ignore
                $jobToDelete->delete();

                if ($this->cascade) {
                    $commandContext
                    ->getHistoricJobLogManager()
                    ->deleteHistoricJobLogByJobId($this->jobId);

The property jobId does not exist on Jabe\Impl\Cmd\DeleteJobsCmd. Did you mean jobIds?

                }
            }
        }
        return null;
    }
}