bingo-soft / jabe

src/Authorization/PermissionTrait.php

<?php

namespace Jabe\Authorization;

trait PermissionTrait
{
    private $name;
    private $id;

    public function getName(): string
    {
        return $this->name;
    }

    public function getValue(): int
    {
        return $this->id;
    }

    public static function forName(string $name): PermissionInterface
    {
        $names = explode("_", strtolower($name));
        $func = $names[0];
        if (count($names) > 1) {
            for ($i = 1; $i < count($names); $i += 1) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $func .= ucfirst($names[$i]);
            }
        }

        return self::$func();
    }

    public static function values(): array
    {
        $reflection = new \ReflectionClass(__CLASS__);
        $methods = $reflection->getMethods(\ReflectionMethod::IS_STATIC);
        $arr = [];

        foreach ($methods as $method) {
            if ($method->getName() !== "values" && $method->getName() !== "forName" && $method->getName() !== "resources") {
                $arr[] = $method->invoke(null);
            }
        }
        return $arr;
    }
}