Jabe\Engine\Impl\Util\PermissionConverter

Complexity

Total Complexity

11

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getNamesForPermissions()	0	28	9
A	getPermissionsForNames()	0	9	2

<?php

namespace Jabe\Engine\Impl\Util;

use Jabe\Engine\ProcessEngineConfiguration;
use Jabe\Engine\Authorization\{
    AuthorizationInterface,
    PermissionInterface,
    Permissions
};
use Jabe\Engine\Impl\Cfg\ProcessEngineConfigurationImpl;

class PermissionConverter
{
    public static function getPermissionsForNames(array $names, int $resourceType, ProcessEngineConfiguration $engineConfiguration): array
    {
        $permissions = [];

        for ($i = 0; i < count($names); $i += 1) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

The constant Jabe\Engine\Impl\Util\i was not found. Maybe you did not declare it correctly or list all dependencies?

            $permissions[] = $engineConfiguration->getPermissionProvider()->getPermissionForName($names[$i], $resourceType);

The method getPermissionProvider() does not exist on Jabe\Engine\ProcessEngineConfiguration.

        }

        return $permissions;
    }

    public static function getNamesForPermissions(AuthorizationInterface $authorization, array $permissions): array
    {
        $type = $authorization->getAuthorizationType();

        // special case all permissions are granted
        if (
            ($type == AuthorizationInterface::AUTH_TYPE_GLOBAL || $type == AuthorizationInterface::AUTH_TYPE_GRANT)
            && $authorization->isEveryPermissionGranted()
        ) {
            return [ Permissions::all()->getName() ];
        }

        // special case all permissions are revoked
        if ($type == Authorization::AUTH_TYPE_REVOKE && $authorization->isEveryPermissionRevoked()) {
            return [ Permissions::all()->getName() ];
        }

        $names = [];

        foreach ($permissions as $permission) {
            $name = $permission->getName();
            // filter NONE and ALL from permissions array
            if ($name != Permissions::none()->getName() && $name != Permissions::all()->getName()) {
                $names[] = $name;
            }
        }

        return $names;
    }
}