Jabe\Engine\Impl\Json\MessageCorrelationBatchConfigurationJsonConverter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	readProcessInstanceIds()	0	3	1
A	readIdMappings()	0	3	1
A	toObject()	0	7	1
A	instance()	0	6	2
A	toJsonObject()	0	10	1

<?php

namespace Jabe\Engine\Impl\Json;

use Jabe\Engine\Impl\Batch\{
    DeploymentMappingJsonConverter,
    DeploymentMappings
};
use Jabe\Engine\Impl\Batch\Message\MessageCorrelationBatchConfiguration;
use Jabe\Engine\Impl\Util\JsonUtil;

class MessageCorrelationBatchConfigurationJsonConverter extends JsonObjectConverter
{
    private static $INSTANCE;
    public const MESSAGE_NAME = "messageName";
    public const PROCESS_INSTANCE_IDS = "processInstanceIds";
    public const PROCESS_INSTANCE_ID_MAPPINGS = "processInstanceIdMappings";
    public const BATCH_ID = "batchId";

    public static function instance(): MessageCorrelationBatchConfigurationJsonConverter
    {
        if (self::$INSTANCE === null) {
            self::$INSTANCE = new MessageCorrelationBatchConfigurationJsonConverter();
        }
        return self::$INSTANCE;
    }

    public function toJsonObject(/*(MessageCorrelationBatchConfiguration*/$configuration, bool $isOrQueryActive = false): ?\stdClass
    {
        $json = JsonUtil::createObject();

        JsonUtil::addField($json, self::MESSAGE_NAME, $configuration->getMessageName());
        JsonUtil::addListField($json, self::PROCESS_INSTANCE_IDS, $configuration->getIds());
        JsonUtil::addListField($json, self::PROCESS_INSTANCE_ID_MAPPINGS, DeploymentMappingJsonConverter::instance(), $configuration->getIdMappings());
        JsonUtil::addField($json, self::BATCH_ID, $configuration->getBatchId());

        return $json;
    }

    public function toObject(\stdClass $json, bool $isOrQuery = false)
    {
        return new MessageCorrelationBatchConfiguration(
            $this->readProcessInstanceIds($json),
            $this->readIdMappings($json),
            JsonUtil::getString($json, self::MESSAGE_NAME, null),
            JsonUtil::getString($json, self::BATCH_ID)
        );
    }

    protected function readProcessInstanceIds($jsonObject): array
    {
        return JsonUtil::asStringList(JsonUtil::getArray($jsonObject, self::PROCESS_INSTANCE_IDS));
    }

    protected function readIdMappings(\stdClass $json): DeploymentMappings
    {
        return JsonUtil::asList(JsonUtil::getArray($json, self::PROCESS_INSTANCE_ID_MAPPINGS), DeploymentMappingJsonConverter::instance(), DeploymentMappings::class);

The expression return Jabe\Engine\Impl\Util\JsonUtil::asList(Jabe\Engine\Impl\Util\JsonUtil::getArray($json, self::PROCESS_INSTANCE_ID_MAPPINGS), Jabe\Engine\Impl\Batch\DeploymentMappingJsonConverter::instance(), Jabe\Engine\Impl\Batch\DeploymentMappings::class) could return the type array which is incompatible with the type-hinted return Jabe\Engine\Impl\Batch\DeploymentMappings. Consider adding an additional type-check to rule them out.

    }
}