Jabe\Engine\Impl\Util\ModificationUtil::handleChildRemovalInScope()

Complexity

Conditions	8
Paths	14

Size

Total Lines	28
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function handleChildRemovalInScope(ExecutionEntity $removedExecution): void
    {
        $activity = $removedExecution->getActivity();
        if ($activity === null) {
            if ($removedExecution->getSuperExecution() !== null) {
                $removedExecution = $removedExecution->getSuperExecution();
                $activity = $removedExecution->getActivity();
                if ($activity == null) {
                    return;
                }
            } else {
                return;
            }
        }
        $flowScope = $activity->getFlowScope();

        $scopeExecution = $removedExecution->getParentScopeExecution(false);
        $executionInParentScope = $removedExecution->isConcurrent() ? $removedExecution : $removedExecution->getParent();

        if ($flowScope->getActivityBehavior() != null && $flowScope->getActivityBehavior() instanceof ModificationObserverBehaviorInterface) {
            // let child removal be handled by the scope itself
            $behavior = $flowScope->getActivityBehavior();
            $behavior->destroyInnerInstance($executionInParentScope);

It seems like $executionInParentScope can also be of type null; however, parameter $concurrentExecution of Jabe\Engine\Impl\Pvm\Delegate\ModificationObserverBehaviorInterface::destroyInnerInstance() does only seem to accept Jabe\Engine\Impl\Pvm\Delegate\ActivityExecutionInterface, maybe add an additional type check?

        } else {
            if ($executionInParentScope->isConcurrent()) {

The method isConcurrent() does not exist on null.

                $executionInParentScope->remove();
                $scopeExecution->tryPruneLastConcurrentChild();
                $scopeExecution->forceUpdate();
            }