Jabe\Engine\Impl\Util\QueryMaxResultsLimitUtil

Complexity

Total Complexity

12

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	checkMaxResultsLimit()	0	19	8
A	isUserAuthenticated()	0	4	2
A	getAuthenticatedUserId()	0	8	2

<?php

namespace Jabe\Engine\Impl\Util;

use Jabe\Engine\BadUserRequestException;
use Jabe\Engine\Impl\ProcessEngineException;
use Jabe\Engine\Impl\Cfg\ProcessEngineConfigurationImpl;
use Jabe\Engine\Impl\Context\Context;

class QueryMaxResultsLimitUtil
{
    public static function checkMaxResultsLimit(int $resultsCount, int $maxResultsLimit = null, bool $isUserAuthenticated = null): void
    {
        if ($maxResultsLimit === null && $isUserAuthenticated === null) {
            $processEngineConfiguration = Context::getProcessEngineConfiguration();
            if ($processEngineConfiguration === null) {
                throw new ProcessEngineException("Command context unset.");
            }

            self::checkMaxResultsLimit(
                $resultsCount,
                self::getMaxResultsLimit($processEngineConfiguration),

The method getMaxResultsLimit() does not exist on Jabe\Engine\Impl\Util\QueryMaxResultsLimitUtil.

                self::isUserAuthenticated($processEngineConfiguration)
            );
        } else {
            if ($isUserAuthenticated && $maxResultsLimit < PHP_INT_MAX) {
                if ($resultsCount == PHP_INT_MAX) {
                    throw new BadUserRequestException("An unbound number of results is forbidden!");
                } elseif ($resultsCount > $maxResultsLimit) {
                    throw new BadUserRequestException("Max results limit of " . $maxResultsLimit . " exceeded!");
                }
            }
        }
    }

    protected static function isUserAuthenticated(ProcessEngineConfigurationImpl $processEngineConfig): bool
    {
        $userId = self::getAuthenticatedUserId($processEngineConfig);
        return $userId != null && !empty($userId);

It seems like you are loosely comparing $userId of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

    }

    protected static function getAuthenticatedUserId(ProcessEngineConfigurationImpl $processEngineConfig): ?string
    {
        $identityService = $processEngineConfig->getIdentityService();

The method getIdentityService() does not exist on Jabe\Engine\Impl\Cfg\ProcessEngineConfigurationImpl.

        $currentAuthentication = $identityService->getCurrentAuthentication();
        if ($currentAuthentication === null) {
            return null;
        } else {
            return $currentAuthentication->getUserId();
        }
    }
}