Jabe\Engine\Impl\Metrics\Util\MetricsUtil

Complexity

Total Complexity

10

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	resolveInternalName()	0	16	5
A	resolvePublicName()	0	16	5

<?php

namespace Jabe\Engine\Impl\Metrics\Util;

use Jabe\Engine\Management\Metrics;

class MetricsUtil
{
    /**
     * Resolves the internal name of the metric by the public name.
     *
     * @param publicName the public name
     * @return string the internal name
     */
    public static function resolveInternalName(?string $publicName): ?string
    {
        if ($publicName == null) {

It seems like you are loosely comparing $publicName of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            return null;
        }
        switch ($publicName) {
            case Metrics::TASK_USERS:

The constant Jabe\Engine\Management\Metrics::TASK_USERS was not found. Maybe you did not declare it correctly or list all dependencies?

                return Metrics::UNIQUE_TASK_WORKERS;
            case Metrics::PROCESS_INSTANCES:

The constant Jabe\Engine\Management\Metrics::PROCESS_INSTANCES was not found. Maybe you did not declare it correctly or list all dependencies?

                return Metrics::ROOT_PROCESS_INSTANCE_START;
            //case Metrics::DECISION_INSTANCES:
            //    return Metrics::EXECUTED_DECISION_INSTANCES;
            case Metrics::FLOW_NODE_INSTANCES:

The constant Jabe\Engine\Management\Metrics::FLOW_NODE_INSTANCES was not found. Maybe you did not declare it correctly or list all dependencies?

                return Metrics::ACTIVTY_INSTANCE_START;
            default:
                return $publicName;
        }
    }

    /**
     * Resolves the public name of the metric by the internal name.
     *
     * @param internalName the internal name
     * @return string the public name
     */
    public static function resolvePublicName(?string $internalName): ?string
    {
        if ($internalName == null) {

It seems like you are loosely comparing $internalName of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            return null;
        }
        switch ($internalName) {
            case Metrics::UNIQUE_TASK_WORKERS:
                return Metrics::TASK_USERS;

The constant Jabe\Engine\Management\Metrics::TASK_USERS was not found. Maybe you did not declare it correctly or list all dependencies?

            case Metrics::ROOT_PROCESS_INSTANCE_START:
                return Metrics::PROCESS_INSTANCES;

The constant Jabe\Engine\Management\Metrics::PROCESS_INSTANCES was not found. Maybe you did not declare it correctly or list all dependencies?

            //case Metrics::EXECUTED_DECISION_INSTANCES:
            //    return Metrics::DECISION_INSTANCES;
            case Metrics::ACTIVTY_INSTANCE_START:
                return Metrics::FLOW_NODE_INSTANCES;

The constant Jabe\Engine\Management\Metrics::FLOW_NODE_INSTANCES was not found. Maybe you did not declare it correctly or list all dependencies?

            default:
                return $internalName;
        }
    }
}