Jabe\Impl\Batch\BatchSeedJobHandler

Complexity

Total Complexity

5

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	newConfiguration()	0	3	1
A	onDelete()	0	2	1
A	getType()	0	3	1
A	execute()	0	19	2

<?php

namespace Jabe\Impl\Batch;

use Jabe\Impl\Interceptor\CommandContext;
use Jabe\Impl\JobExecutor\{
    JobHandlerInterface,
    JobHandlerConfigurationInterface
};
use Jabe\Impl\Persistence\Entity\{
    ExecutionEntity,
    JobEntity
};
use Jabe\Impl\Util\EnsureUtil;

class BatchSeedJobHandler implements JobHandlerInterface
{
    public const TYPE = "batch-seed-job";

    public function getType(): string
    {
        return self::TYPE;
    }

    public function execute(JobHandlerConfigurationInterface $configuration, ExecutionEntity $execution, CommandContext $commandContext, ?string $tenantId): void
    {
        $batchId = $configuration->getBatchId();

The method getBatchId() does not exist on Jabe\Impl\JobExecutor\JobHandlerConfigurationInterface. It seems like you code against a sub-type of Jabe\Impl\JobExecutor\JobHandlerConfigurationInterface such as Jabe\Impl\Batch\BatchMonitorJobConfiguration or Jabe\Impl\Batch\BatchSeedJobConfiguration.

The assignment to $batchId is dead and can be removed.

        $batch = $commandContext->getBatchManager()->findBatchById($configuration->getBatchId());
        EnsureUtil::ensureNotNull("Batch with id '" . $this->batchId . "' cannot be found", "batch", $batch);

The property batchId does not exist on Jabe\Impl\Batch\BatchSeedJobHandler. Did you maybe forget to declare it?

        $batchJobHandler = $commandContext
            ->getProcessEngineConfiguration()
            ->getBatchHandlers()

The method getBatchHandlers() does not exist on Jabe\Impl\Cfg\ProcessEngineConfigurationImpl.

            ->get($batch->getType());

        $done = $batchJobHandler->createJobs($batch);

        if (!$done) {
            $batch->createSeedJob();
        } else {
            // create monitor job initially without due date to
            // enable rapid completion of simple batches
            $batch->createMonitorJob(false);
        }
    }

    public function newConfiguration(string $canonicalString): JobHandlerConfigurationInterface
    {
        return new BatchSeedJobConfiguration($canonicalString);
    }

    public function onDelete(JobHandlerConfigurationInterface $configuration, JobEntity $jobEntity): void
    {
        // do nothing
    }
}