graphp\edge\specifics\UniformEdgeSpecifics

Complexity

Total Complexity

13

Size/Duplication

Total Lines	136
Duplicated Lines	0 %

Test Coverage

Coverage

80%

Importance

Changes	1
Bugs	0	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getEdgeSet()	0	3	1
A	getEdge()	0	6	2
A	getEdgeWeight()	0	3	1
A	remove()	0	4	2
A	getEdgeSource()	0	3	1
A	containsEdge()	0	3	1
A	add()	0	11	2
A	__construct()	0	3	1
A	setEdgeWeight()	0	3	1
A	getEdgeTarget()	0	3	1

<?php

namespace graphp\edge\specifics;

use BadMethodCallException;
use graphp\graph\GraphInterface;
use graphp\edge\EdgeInterface;
use graphp\edge\EdgeSet;
use graphp\vertex\VertexInterface;

/**
 * Class UniformEdgeSpecifics
 *
 * @package graphp\edge\specifics
 */
class UniformEdgeSpecifics implements EdgeSpecificsInterface
{
    /**
     * The edge set
     *
     * @var array
     */
    protected $edgeSet;
    
    /**
     * Construct a new specifics
     */
    public function __construct()
    {
        $this->edgeSet = new EdgeSet();

It seems like new graphp\edge\EdgeSet() of type graphp\edge\EdgeSet is incompatible with the declared type array of property $edgeSet.

    }
    
    /**
     * Check if the edge exists
     *
     * @param EdgeInterface $edge - the edge
     *
     * @return bool
     */
    public function containsEdge(EdgeInterface $edge): bool
    {
        return $this->edgeSet->contains($edge);
    }
    
     /**
     * Get the edge set
     *
     * @return EdgeSet
     */
    public function getEdgeSet(): EdgeSet
    {
        return $this->edgeSet;

The expression return $this->edgeSet returns the type array which is incompatible with the type-hinted return graphp\edge\EdgeSet.

    }
    
    /**
     * Remove the edge from the set
     *
     * @param EdgeInterface $edge - the edge
     */
    public function remove(EdgeInterface $edge): void
    {
        if ($this->edgeSet->contains($edge)) {
            $this->edgeSet->remove($edge);
        }
    }
    
    /**
     * Get the edge source vertex
     *
     * @param EdgeInterface $edge - the edge
     *
     * @return VertexInterface
     */
    public function getEdgeSource(EdgeInterface $edge): VertexInterface
    {
        return $edge->getSource();

The method getSource() does not exist on graphp\edge\EdgeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to graphp\edge\EdgeInterface.

    }
    
     /**
     * Get the edge target vertex
     *
     * @param EdgeInterface $edge - the edge
     *
     * @return VertexInterface
     */
    public function getEdgeTarget(EdgeInterface $edge): VertexInterface
    {
        return $edge->getTarget();

The method getTarget() does not exist on graphp\edge\EdgeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to graphp\edge\EdgeInterface.

    }
    
    /**
     * Get the edge weight
     *
     * @param EdgeInterface $edge - the edge
     *
     * @return float
     */
    public function getEdgeWeight(EdgeInterface $edge): float
    {
        return GraphInterface::DEFAULT_EDGE_WEIGHT;
    }
    
    /**
     * Set the edge weight
     *
     * @param EdgeInterface $edge - the edge
     * @param float $weight - the weight
     *
     * @throws BadMethodCallException
     */
    public function setEdgeWeight(EdgeInterface $edge, float $weight): void
    {
        throw new BadMethodCallException("Method is not supported by this type of edge");
    }
    
    /**
     * Get the edge
     *
     * @param EdgeInterface $edge - the edge
     *
     * @return null|EdgeInterface
     */
    public function getEdge(EdgeInterface $edge): ?EdgeInterface
    {
        if (($id = array_search($edge, $this->edgeSet->getArrayCopy())) !== false) {
            return $this->edgeSet[$id];
        }
        return null;
    }
    
    /**
     * Add a new edge connecting the specified vertices
     * Return true, if edge was added
     *
     * @param EdgeInterface $edge - the edge
     * @param VertexInterface $sourceVertex - the source vertex
     * @param VertexInterface $sourceVertex - tge target vertex
     *
     * @return bool
     */
    public function add(EdgeInterface $edge, VertexInterface $sourceVertex, VertexInterface $targetVertex): bool
    {
        $edge->setSource($sourceVertex);

The method setSource() does not exist on graphp\edge\EdgeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to graphp\edge\EdgeInterface.

        $edge->setTarget($targetVertex);

The method setTarget() does not exist on graphp\edge\EdgeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to graphp\edge\EdgeInterface.

        if (!$this->containsEdge($edge)) {
            $this->edgeSet[] = $edge;
            return true;
        }

        return false;
    }
}