graphp\edge\DefaultEdge

Complexity

Total Complexity

8

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Test Coverage

Coverage

89.47%

Importance

Changes	1
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	equals()	0	3	1
A	getHash()	0	3	1
A	__construct()	0	3	1
A	setTarget()	0	3	1
A	getTarget()	0	3	1
A	setSource()	0	3	1
A	__toString()	0	3	1
A	getSource()	0	3	1

<?php

namespace graphp\edge;

use graphp\vertex\VertexInterface;

/**
 * Class DefaultEdge
 *
 * @package graphp\edge
 */
class DefaultEdge implements EdgeInterface
{
    /**
     * The edge unique hash
     *
     * @var string
     */
    private $hash;

    /**
     * The edge source vertex
     *
     * @var VertexInterface
     */
    protected $sourceVertex;
    
    /**
     * The edge target vertex
     *
     * @var VertexInterface
     */
    protected $targetVertex;

    /**
     * Construct a new edge
     */
    public function __construct()
    {
        $this->hash = uniqid('', true);
    }

    /**
     * Check if two edges are equal
     *
     * @param EdgeInterface $other - other edge to be compared
     */
    public function equals(EdgeInterface $other): bool
    {
        return $this->hash == $other->getHash();

The method getHash() does not exist on graphp\edge\EdgeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to graphp\edge\EdgeInterface.

    }

    /**
     * Get the edge hash
     *
     * @return string
     */
    public function getHash(): string
    {
        return $this->hash;
    }
    
    /**
     * Get the edge source vertex
     *
     * @return VertexInterface
     */
    public function getSource(): VertexInterface
    {
        return $this->sourceVertex;
    }
    
    /**
     * Get the edge target vertex
     *
     * @return VertexInterface
     */
    public function getTarget(): VertexInterface
    {
        return $this->targetVertex;
    }

    /**
     * Set the edge source vertex
     *
     * @param VertexInterface $vertex - the source vertex
     */
    public function setSource(VertexInterface $vertex): void
    {
        $this->sourceVertex = $vertex;
    }
    
    /**
     * Set the edge target vertex
     *
     * @param VertexInterface $vertex - the target vertex
     */
    public function setTarget(VertexInterface $vertex): void
    {
        $this->targetVertex = $vertex;
    }

    /**
     * Get the edge string representation
     *
     * @return string
     */
    public function __toString(): string
    {
        return "(" . $this->sourceVertex + " : " + $this->targetVertex + ")";

Are you sure $this->sourceVertex of type graphp\vertex\VertexInterface can be used in concatenation? Consider adding a __toString()-method.

    }
}