Graphp\Graph\Specifics\UndirectedEdgeContainer

Complexity

Total Complexity

7

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	edgeCount()	0	3	1
A	__construct()	0	3	1
A	addEdge()	0	3	1
A	removeEdge()	0	6	3
A	getEdges()	0	3	1

<?php

namespace Graphp\Graph\Specifics;

use Graphp\Edge\EdgeInterface;
use Graphp\Edge\EdgeSetFactoryInterface;
use Graphp\Edge\EdgeContainerInterface;
use Graphp\Edge\EdgeSet;
use Graphp\Vertex\VertexInterface;

/**
 * Class UndirectedEdgeContainer
 *
 * @package Graphp\Graph\Specifics
 */
final class UndirectedEdgeContainer implements EdgeContainerInterface
{
    /**
     * Container vertex edges
     *
     * @var array
     */
    private $vertexEdges = [];
    
    /**
     * Construct undirected edge container
     *
     * @param EdgeSetFactoryInterface $edgeSetFactory - the edge set factory
     * @param VertexInterface $vertex - the vertex
     */
    public function __construct(EdgeSetFactoryInterface $edgeSetFactory, VertexInterface $vertex)
    {
        $this->vertexEdges = $edgeSetFactory->createEdgeSet($vertex);

It seems like $edgeSetFactory->createEdgeSet($vertex) of type Graphp\Edge\EdgeSet is incompatible with the declared type array of property $vertexEdges.

    }
    
    /**
     * Add an edge to the container
     *
     * @param EdgeInterface $edge - the edge to be added
     */
    public function addEdge(EdgeInterface $edge): void
    {
        $this->vertexEdges[] = $edge;
    }
    
    /**
     * Remove the edge from the container
     *
     * @param EdgeInterface $edge - the edge to be removed
     */
    public function removeEdge(EdgeInterface $edge): void
    {
        foreach ($this->vertexEdges as $key => $e) {
            if ($edge->equals($e)) {
                unset($this->vertexEdges[$key]);
                break;
            }
        }
    }
    
    /**
     * Get all container edges
     *
     * @return EdgeSet
     */
    public function getEdges(): EdgeSet
    {
        return $this->vertexEdges;

The expression return $this->vertexEdges returns the type array which is incompatible with the type-hinted return Graphp\Edge\EdgeSet.

    }

    /**
     * Get the number of edges
     *
     * @return int
     */
    public function edgeCount(): int
    {
        return count($this->vertexEdges);
    }
}