bigperson / amocrm-api-laravel

src/AmoCrmApiServiceProvider.php

<?php

declare(strict_types=1);
/**
 * @author Anton Kartsev <anton@alarm.ru>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Bigperson\AmoCrmApi;

use Illuminate\Support\ServiceProvider;
use linkprofit\AmoCRM\RequestHandler;
use linkprofit\AmoCRM\services\AccountService;
use linkprofit\AmoCRM\services\CatalogElementService;
use linkprofit\AmoCRM\services\CatalogService;
use linkprofit\AmoCRM\services\CompanyService;
use linkprofit\AmoCRM\services\ContactService;
use linkprofit\AmoCRM\services\CustomerService;
use linkprofit\AmoCRM\services\FieldService;
use linkprofit\AmoCRM\services\LeadService;
use linkprofit\AmoCRM\services\NoteService;
use linkprofit\AmoCRM\services\PipelineService;
use linkprofit\AmoCRM\services\TaskService;
use linkprofit\AmoCRM\services\TaskTypeService;

/**
 * Class AmoCrmApiServiceProvider.
 */
class AmoCrmApiServiceProvider extends ServiceProvider
{
    protected $defer = true;

    /**
     * Local config file path.
     */
    private const CONFIG_PATH = __DIR__.'/../config/amocrm-api.php';

    /**
     * @var array List of services
     */
    protected $services = [
        AccountService::class,
        CatalogElementService::class,
        CatalogService::class,
        CompanyService::class,
        ContactService::class,
        CustomerService::class,
        FieldService::class,
        LeadService::class,
        NoteService::class,
        PipelineService::class,
        TaskService::class,
        TaskTypeService::class,
    ];

    /**
     * Bootstrap the application services.
     *
     * @return void
     */
    public function boot()
    {
        $this->shareResources();
        $this->mergeConfigFrom(self::CONFIG_PATH, 'amocrm-api');
    }

    /**
     * Register the application services.
     *
     * @return void
     */
    public function register()
    {
        $this->registerRequestHandler();
        $this->registerAuthorizationService();
        $this->registerServices();
    }

    /**
     * @return void
     */
    private function shareResources(): void
    {
        $publishes = [
            self::CONFIG_PATH => \config_path('amocrm-api.php'),
        ];
        $this->publishes($publishes, 'amocrm-api');
    }

    /**
     * @return void Register Request Handler
     */
    private function registerRequestHandler()
    {
        $this->app->singleton(RequestHandler::class, function ($app) {

The parameter $app is not used and could be removed.

            $request = new \linkprofit\AmoCRM\RequestHandler();
            $request->setSubdomain(config('amocrm-api.domain'));

            return $request;
        });
    }

    /**
     * @return void Register and authorize Authorization Service
     */
    private function registerAuthorizationService()
    {
        $this->app->singleton(AuthorizationService::class, function ($app) {
            $request = $app->make(RequestHandler::class);
            $connection = new \linkprofit\AmoCRM\entities\Authorization(
                config('amocrm-api.login'),
                config('amocrm-api.hash')
            );
            $authorization = new \linkprofit\AmoCRM\services\AuthorizationService($request);
            $authorization->add($connection);
            if ($this->app->environment() !== 'testing') {
                $authorization->authorize();
            }

            return $authorization;
        });
    }

    /**
     * @return void Boot all services
     */
    private function registerServices()
    {
        foreach ($this->services as $service) {
            $this->app->bind($service, function ($app) use ($service) {
                $request = $app->make(\linkprofit\AmoCRM\RequestHandler::class);
                $authorization = $app->make(AuthorizationService::class);

The assignment to $authorization is dead and can be removed.

                $service = new $service($request);

                return $service;
            });
        }
    }

    /**
     * Get the services provided by the provider.
     *
     * @return array
     */
    public function provides()
    {
        return [RequestHandler::class];
    }
}