bigbluebutton /
greenlight
| Conditions | 5 |
| Paths | 4 |
| Total Lines | 63 |
| Code Lines | 32 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | // BigBlueButton open source conferencing system - http://www.bigbluebutton.org/. |
||
| 17 | $(document).on('turbolinks:load', function(){ |
||
| 18 | var controller = $("body").data('controller'); |
||
| 19 | var action = $("body").data('action'); |
||
| 20 | |||
| 21 | // Only run on the admins page. |
||
| 22 | if (controller == "admins" && action == "index") { |
||
| 23 | // show the modal with the correct form action url |
||
| 24 | $(".delete-user").click(function(data){ |
||
| 25 | var uid = $(data.target).closest("tr").data("user-uid") |
||
| 26 | $("#delete-confirm").parent().attr("action", "/u/" + uid) |
||
| 27 | }) |
||
| 28 | |||
| 29 | // Change the color of the color inputs when the color is changed |
||
| 30 | $(".colorinput-input").change(function(data) { |
||
| 31 | // Get the color from the input |
||
| 32 | var color = $(data.target).val() |
||
| 33 | |||
| 34 | // Update the color in the database and reload the page |
||
| 35 | $.post($("#coloring-path").val(), {color: color}).done(function(data) { |
||
|
|
|||
| 36 | location.reload() |
||
| 37 | }); |
||
| 38 | }); |
||
| 39 | |||
| 40 | // Submit search if the user hits enter |
||
| 41 | $("#search-input").keypress(function(key) { |
||
| 42 | var keyPressed = key.which |
||
| 43 | if (keyPressed == 13) { |
||
| 44 | searchPage() |
||
| 45 | } |
||
| 46 | }) |
||
| 47 | |||
| 48 | // Add listeners for sort |
||
| 49 | $("th[data-order]").click(function(data){ |
||
| 50 | var header_elem = $(data.target) |
||
| 51 | |||
| 52 | if(header_elem.data('order') === 'asc'){ // asc |
||
| 53 | header_elem.data('order', 'desc'); |
||
| 54 | } |
||
| 55 | else if(header_elem.data('order') === 'desc'){ // desc |
||
| 56 | header_elem.data('order', 'none'); |
||
| 57 | } |
||
| 58 | else{ // none |
||
| 59 | header_elem.data('order', 'asc'); |
||
| 60 | } |
||
| 61 | |||
| 62 | var search = $("#search-input").val() |
||
| 63 | window.location.replace(window.location.pathname + "?page=1&search=" + search + "&column=" + header_elem.data("header") + "&direction="+ header_elem.data('order')) |
||
| 64 | }) |
||
| 65 | } |
||
| 66 | |||
| 67 | // Only run on the admins edit user page. |
||
| 68 | if (controller == "admins" && action == "edit_user") { |
||
| 69 | $("#users").click(function(data){ |
||
| 70 | var url = $("body").data("relative-root") |
||
| 71 | if (!url.endsWith("/")) { |
||
| 72 | url += "/" |
||
| 73 | } |
||
| 74 | url += "admins" |
||
| 75 | |||
| 76 | window.location.href = url |
||
| 77 | }) |
||
| 78 | } |
||
| 79 | }); |
||
| 80 | |||
| 98 |
This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function.