user_edit.js ➔ clearRole - Code Metrics - Inspection of "GRN2-176: Create a role editor that allows admins..." - bigbluebutton/greenlight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#709)

unknown

created 2019-07-30 14:33 UTC

user_edit.js ➔ clearRole B

↳ Parent: app/assets/javascripts/user_edit.js

Complexity

Conditions

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
c	0
b	0
f	0
dl	0
loc	19
rs	7.3333
eloc	12

$(document).on('turbolinks:load', function(){
    var controller = $("body").data('controller');
    var action = $("body").data('action');
    if ((controller == "admins" && action == "edit_user") || (controller == "users" && action == "edit")) {
        $(".setting-btn").click(function(data){
            var url = $("body").data("relative-root")
            if (!url.endsWith("/")) {
                url += "/"
            }
            url += "admins?setting=" + data.target.id

            window.location.href = url
        })

        $(".clear-role").click(clearRole)

        $("#role-select-dropdown").change(function(data){
            dropdown = $("#role-select-dropdown");

            select_role_id = dropdown.val();


            if(select_role_id){
                selected_role = dropdown.find('[value=\"' + select_role_id + '\"]');

                selected_role.prop("disabled", true)

                tag_container = $("#role-tag-container");

                tag_container.append("<span id=\"user-role-tag_" + select_role_id + "\" style=\"background-color:" + selected_role.data("colour") + ";\" class=\"tag\">" + 
                    selected_role.text() + "<a data-role-id=\"" + select_role_id + "\" class=\"tag-addon clear-role\"><i data-role-id=\"" + select_role_id + "\" class=\"fas fa-times\"></i></a></span>");

                role_ids = $("#user_role_ids").val()

                role_ids += " " + select_role_id
                $("#user_role_ids").val(role_ids)
                
                $("#user-role-tag_" + select_role_id).click(clearRole);
                dropdown.val(null)
            }
        })
    }
})

function clearRole(data){
    role_id = $(data.target).data("role-id");

    role_tag = $("#user-role-tag_" + role_id);

    $(role_tag).remove()
  
    role_ids = $("#user_role_ids").val()

    parsed_ids = role_ids.split(' ')

  
    var index = parsed_ids.indexOf(role_id.toString());
  
    if (index > -1) {
        parsed_ids.splice(index, 1);
    }
  
    $("#user_role_ids").val(parsed_ids.join(' '))
  
    selected_role = $("#role-select-dropdown").find('[value=\"' + role_id + '\"]');

    selected_role.prop("disabled", false)
}

1			$(document).on('turbolinks:load', function(){
2			var controller = $("body").data('controller');
3			var action = $("body").data('action');
4			if ((controller == "admins" && action == "edit_user") \|\| (controller == "users" && action == "edit")) {
5			$(".setting-btn").click(function(data){
6			var url = $("body").data("relative-root")
7			if (!url.endsWith("/")) {
8			url += "/"
9			}
10			url += "admins?setting=" + data.target.id
11
12			window.location.href = url
13			})
14
15			$(".clear-role").click(clearRole)
16
17			$("#role-select-dropdown").change(function(data){
18			dropdown = $("#role-select-dropdown");
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `dropdown` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.dropdown`. Loading history...
19			select_role_id = dropdown.val();
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `select_role_id` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.select_role_id`. Loading history...
20
21			if(select_role_id){
22			selected_role = dropdown.find('[value=\"' + select_role_id + '\"]');
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `selected_role` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.selected_role`. Loading history...
23			selected_role.prop("disabled", true)
24
25			tag_container = $("#role-tag-container");
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `tag_container` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.tag_container`. Loading history...
26			tag_container.append("<span id=\"user-role-tag_" + select_role_id + "\" style=\"background-color:" + selected_role.data("colour") + ";\" class=\"tag\">" +
27			selected_role.text() + "<a data-role-id=\"" + select_role_id + "\" class=\"tag-addon clear-role\"><i data-role-id=\"" + select_role_id + "\" class=\"fas fa-times\"></i></a></span>");
28
29			role_ids = $("#user_role_ids").val()
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `role_ids` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.role_ids`. Loading history...
30			role_ids += " " + select_role_id
31			$("#user_role_ids").val(role_ids)
32
33			$("#user-role-tag_" + select_role_id).click(clearRole);
34			dropdown.val(null)
35			}
36			})
37			}
38			})
39
40			function clearRole(data){
41			role_id = $(data.target).data("role-id");
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `role_id` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.role_id`. Loading history...
42			role_tag = $("#user-role-tag_" + role_id);
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `role_tag` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.role_tag`. Loading history...
43			$(role_tag).remove()
44
45			role_ids = $("#user_role_ids").val()
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `role_ids` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.role_ids`. Loading history...
46			parsed_ids = role_ids.split(' ')
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `parsed_ids` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.parsed_ids`. Loading history...
47
48			var index = parsed_ids.indexOf(role_id.toString());
49
50			if (index > -1) {
51			parsed_ids.splice(index, 1);
52			}
53
54			$("#user_role_ids").val(parsed_ids.join(' '))
55
56			selected_role = $("#role-select-dropdown").find('[value=\"' + role_id + '\"]');
			0 ignored issues – show Bug introduced 2019-07-30 14:33 UTC by Report Bug Copy Issue Report The variable `selected_role` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.selected_role`. Loading history...
57			selected_role.prop("disabled", false)
58			}

bigbluebutton / greenlight

GitHub Access Token became invalid

Pull Request — master (#709)

user_edit.js ➔ clearRole B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like