AddCustomRoles.up() - Code Metrics - bigbluebutton/greenlight - Measure and Improve Code Quality continuously with Scrutinizer

AddCustomRoles.up() B
last analyzed 2020-01-09 16:25 UTC

↳ Parent: AddCustomRoles

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
cc	1
c	2
b	1
f	1
dl	0
loc	75
rs	7.8181

How to fix Long Method

# frozen_string_literal: true

class AddCustomRoles < ActiveRecord::Migration[5.2]
  def up
    super_admin_id = -1
    user_id = -1
    admin_id = -1
    denied_id = -1
    pending_id = -1

    old_roles = ActiveRecord::Base.connection.execute("select * from roles")

    # Determine what ids corresponded to what roles in the old table
    old_roles.each do |role|
      if role["name"] == "super_admin"
        super_admin_id = role["id"]
      elsif role["name"] == "user"
        user_id = role["id"]
      elsif role["name"] == "admin"
        admin_id = role["id"]
      elsif role["name"] == "denied"
        denied_id = role["id"]
      elsif role["name"] == "pending"
        pending_id = role["id"]
      end
    end

    # Replace Rolify's table with our own
    drop_table :roles

    create_table(:roles) do |t|
      t.string :name
      t.integer :priority, default: 9999
      t.boolean :can_create_rooms, default: false
      t.boolean :send_promoted_email, default: false
      t.boolean :send_demoted_email, default: false
      t.boolean :can_edit_site_settings, default: false
      t.boolean :can_edit_roles, default: false
      t.boolean :can_manage_users, default: false
      t.string  :colour
      t.string :provider

      t.timestamps
    end

    add_index(:roles, :name)
    add_index(:roles, [:name, :provider], unique: true)

    # Look at all the old role assignments and and for each role create a new role
    # that is scoped to the provider
    old_assignments = ActiveRecord::Base.connection.execute("select * from users_roles")
    new_assignments = []

    old_assignments.each do |assignment|
      begin
        user = User.find(assignment["user_id"])
      rescue
        next
      end

      new_assignment = { "user_id" => assignment["user_id"] }
      if assignment["role_id"] == super_admin_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "super_admin")
      elsif assignment["role_id"] == user_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "user")
      elsif assignment["role_id"] == admin_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "admin")
      elsif assignment["role_id"] == denied_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "denied")
      elsif assignment["role_id"] == pending_id
        new_assignment["new_role_id"] = generate_scoped_role(user, "pending")
      end

      new_assignments << new_assignment
    end

    assign_new_users(new_assignments)
  end

  def generate_scoped_role(user, role_name)
    provider = Rails.configuration.loadbalanced_configuration ? user.provider : 'greenlight'
    new_role = Role.find_by(name: role_name, provider: provider)

    if new_role.nil?
      Role.create_default_roles(provider)

      new_role = Role.find_by(name: role_name, provider: provider)
    end

    new_role.id
  end

  def assign_new_users(new_assignments)
    # Delete the old assignments
    ActiveRecord::Base.connection.execute("DELETE FROM users_roles")
    # Add the role assignments to the new roles
    new_assignments.each do |assignment|
      if assignment['new_role_id']
        ActiveRecord::Base.connection.execute("INSERT INTO users_roles (user_id, role_id)" \
          " VALUES (#{assignment['user_id']}, #{assignment['new_role_id']})")
      end
    end
  end

  def down
    drop_table :roles

    create_table(:roles) do |t|
      t.string :name
      t.references :resource, polymorphic: true

      t.timestamps
    end
  end
end


1			# frozen_string_literal: true
2
3			class AddCustomRoles < ActiveRecord::Migration[5.2]
4			def up
5			super_admin_id = -1
6			user_id = -1
7			admin_id = -1
8			denied_id = -1
9			pending_id = -1
10
11			old_roles = ActiveRecord::Base.connection.execute("select * from roles")
12
13			# Determine what ids corresponded to what roles in the old table
14			old_roles.each do \|role\|
15			if role["name"] == "super_admin"
16			super_admin_id = role["id"]
17			elsif role["name"] == "user"
18			user_id = role["id"]
19			elsif role["name"] == "admin"
20			admin_id = role["id"]
21			elsif role["name"] == "denied"
22			denied_id = role["id"]
23			elsif role["name"] == "pending"
24			pending_id = role["id"]
25			end
26			end
27
28			# Replace Rolify's table with our own
29			drop_table :roles
30
31			create_table(:roles) do \|t\|
32			t.string :name
33			t.integer :priority, default: 9999
34			t.boolean :can_create_rooms, default: false
35			t.boolean :send_promoted_email, default: false
36			t.boolean :send_demoted_email, default: false
37			t.boolean :can_edit_site_settings, default: false
38			t.boolean :can_edit_roles, default: false
39			t.boolean :can_manage_users, default: false
40			t.string :colour
41			t.string :provider
42
43			t.timestamps
44			end
45
46			add_index(:roles, :name)
47			add_index(:roles, [:name, :provider], unique: true)
48
49			# Look at all the old role assignments and and for each role create a new role
50			# that is scoped to the provider
51			old_assignments = ActiveRecord::Base.connection.execute("select * from users_roles")
52			new_assignments = []
53
54			old_assignments.each do \|assignment\|
55			begin
56			user = User.find(assignment["user_id"])
57			rescue
58			next
59			end
60
61			new_assignment = { "user_id" => assignment["user_id"] }
62			if assignment["role_id"] == super_admin_id
63			new_assignment["new_role_id"] = generate_scoped_role(user, "super_admin")
64			elsif assignment["role_id"] == user_id
65			new_assignment["new_role_id"] = generate_scoped_role(user, "user")
66			elsif assignment["role_id"] == admin_id
67			new_assignment["new_role_id"] = generate_scoped_role(user, "admin")
68			elsif assignment["role_id"] == denied_id
69			new_assignment["new_role_id"] = generate_scoped_role(user, "denied")
70			elsif assignment["role_id"] == pending_id
71			new_assignment["new_role_id"] = generate_scoped_role(user, "pending")
72			end
73
74			new_assignments << new_assignment
75			end
76
77			assign_new_users(new_assignments)
78			end
79
80			def generate_scoped_role(user, role_name)
81			provider = Rails.configuration.loadbalanced_configuration ? user.provider : 'greenlight'
82			new_role = Role.find_by(name: role_name, provider: provider)
83
84			if new_role.nil?
85			Role.create_default_roles(provider)
86
87			new_role = Role.find_by(name: role_name, provider: provider)
88			end
89
90			new_role.id
91			end
92
93			def assign_new_users(new_assignments)
94			# Delete the old assignments
95			ActiveRecord::Base.connection.execute("DELETE FROM users_roles")
96			# Add the role assignments to the new roles
97			new_assignments.each do \|assignment\|
98			if assignment['new_role_id']
99			ActiveRecord::Base.connection.execute("INSERT INTO users_roles (user_id, role_id)" \
100			" VALUES (#{assignment['user_id']}, #{assignment['new_role_id']})")
101			end
102			end
103			end
104
105			def down
106			drop_table :roles
107
108			create_table(:roles) do \|t\|
109			t.string :name
110			t.references :resource, polymorphic: true
111
112			t.timestamps
113			end
114			end
115			end
116

bigbluebutton / greenlight

GitHub Access Token became invalid

AddCustomRoles.up() B last analyzed 2020-01-09 16:25 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

AddCustomRoles.up() B
last analyzed 2020-01-09 16:25 UTC