Complex classes like CreateMeetingParameters often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CreateMeetingParameters, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
24 | class CreateMeetingParameters extends MetaParameters |
||
25 | { |
||
26 | /** |
||
27 | * @var string |
||
28 | */ |
||
29 | private $meetingId; |
||
30 | |||
31 | /** |
||
32 | * @var string |
||
33 | */ |
||
34 | private $meetingName; |
||
35 | |||
36 | /** |
||
37 | * @var string |
||
38 | */ |
||
39 | private $attendeePassword; |
||
40 | |||
41 | /** |
||
42 | * @var string |
||
43 | */ |
||
44 | private $moderatorPassword; |
||
45 | |||
46 | /** |
||
47 | * @var string |
||
48 | */ |
||
49 | private $dialNumber; |
||
50 | |||
51 | /** |
||
52 | * @var int |
||
53 | */ |
||
54 | private $voiceBridge; |
||
55 | |||
56 | /** |
||
57 | * @var string |
||
58 | */ |
||
59 | private $webVoice; |
||
60 | |||
61 | /** |
||
62 | * @var string |
||
63 | */ |
||
64 | private $logoutUrl; |
||
65 | |||
66 | /** |
||
67 | * @var int |
||
68 | */ |
||
69 | private $maxParticipants; |
||
70 | |||
71 | /** |
||
72 | * @var bool |
||
73 | */ |
||
74 | private $record; |
||
75 | |||
76 | /** |
||
77 | * @var bool |
||
78 | */ |
||
79 | private $autoStartRecording; |
||
80 | |||
81 | /** |
||
82 | * @var bool |
||
83 | */ |
||
84 | private $allowStartStopRecording; |
||
85 | |||
86 | /** |
||
87 | * @var int |
||
88 | */ |
||
89 | private $duration; |
||
90 | |||
91 | /** |
||
92 | * @var string |
||
93 | */ |
||
94 | private $welcomeMessage; |
||
95 | |||
96 | /** |
||
97 | * @var string |
||
98 | */ |
||
99 | private $moderatorOnlyMessage; |
||
100 | |||
101 | /** |
||
102 | * @var bool |
||
103 | */ |
||
104 | private $webcamsOnlyForModerator; |
||
105 | |||
106 | /** |
||
107 | * @var string |
||
108 | */ |
||
109 | private $logo; |
||
110 | |||
111 | /** |
||
112 | * @var string |
||
113 | */ |
||
114 | private $copyright; |
||
115 | |||
116 | /** |
||
117 | * @var bool |
||
118 | */ |
||
119 | private $muteOnStart; |
||
120 | |||
121 | /** |
||
122 | * @var array |
||
123 | */ |
||
124 | private $presentations = []; |
||
125 | |||
126 | /** |
||
127 | * @var boolean |
||
128 | */ |
||
129 | private $isBreakout; |
||
130 | |||
131 | /** |
||
132 | * @var string |
||
133 | */ |
||
134 | private $parentMeetingId; |
||
135 | |||
136 | /** |
||
137 | * @var int |
||
138 | */ |
||
139 | private $sequence; |
||
140 | |||
141 | /** |
||
142 | * @var boolean |
||
143 | */ |
||
144 | private $freeJoin; |
||
145 | |||
146 | /** |
||
147 | * CreateMeetingParameters constructor. |
||
148 | * |
||
149 | * @param $meetingId |
||
150 | * @param $meetingName |
||
151 | */ |
||
152 | public function __construct($meetingId, $meetingName) |
||
157 | |||
158 | /** |
||
159 | * @return string |
||
160 | */ |
||
161 | public function getMeetingId() |
||
165 | |||
166 | /** |
||
167 | * @param string $meetingId |
||
168 | * |
||
169 | * @return CreateMeetingParameters |
||
170 | */ |
||
171 | public function setMeetingId($meetingId) |
||
177 | |||
178 | /** |
||
179 | * @return string |
||
180 | */ |
||
181 | public function getMeetingName() |
||
185 | |||
186 | /** |
||
187 | * @param string $meetingName |
||
188 | * |
||
189 | * @return CreateMeetingParameters |
||
190 | */ |
||
191 | public function setMeetingName($meetingName) |
||
197 | |||
198 | /** |
||
199 | * @return string |
||
200 | */ |
||
201 | public function getAttendeePassword() |
||
205 | |||
206 | /** |
||
207 | * @param string $attendeePassword |
||
208 | * |
||
209 | * @return CreateMeetingParameters |
||
210 | */ |
||
211 | public function setAttendeePassword($attendeePassword) |
||
217 | |||
218 | /** |
||
219 | * @return string |
||
220 | */ |
||
221 | public function getModeratorPassword() |
||
225 | |||
226 | /** |
||
227 | * @param string $moderatorPassword |
||
228 | * |
||
229 | * @return CreateMeetingParameters |
||
230 | */ |
||
231 | public function setModeratorPassword($moderatorPassword) |
||
237 | |||
238 | /** |
||
239 | * @return string |
||
240 | */ |
||
241 | public function getDialNumber() |
||
245 | |||
246 | /** |
||
247 | * @param string $dialNumber |
||
248 | * |
||
249 | * @return CreateMeetingParameters |
||
250 | */ |
||
251 | public function setDialNumber($dialNumber) |
||
257 | |||
258 | /** |
||
259 | * @return int |
||
260 | */ |
||
261 | public function getVoiceBridge() |
||
265 | |||
266 | /** |
||
267 | * @param int $voiceBridge |
||
268 | * |
||
269 | * @return CreateMeetingParameters |
||
270 | */ |
||
271 | public function setVoiceBridge($voiceBridge) |
||
277 | |||
278 | /** |
||
279 | * @return string |
||
280 | */ |
||
281 | public function getWebVoice() |
||
285 | |||
286 | /** |
||
287 | * @param string $webVoice |
||
288 | * |
||
289 | * @return CreateMeetingParameters |
||
290 | */ |
||
291 | public function setWebVoice($webVoice) |
||
297 | |||
298 | /** |
||
299 | * @return string |
||
300 | */ |
||
301 | public function getLogoutUrl() |
||
305 | |||
306 | /** |
||
307 | * @param string $logoutUrl |
||
308 | * |
||
309 | * @return CreateMeetingParameters |
||
310 | */ |
||
311 | public function setLogoutUrl($logoutUrl) |
||
317 | |||
318 | /** |
||
319 | * @return int |
||
320 | */ |
||
321 | public function getMaxParticipants() |
||
325 | |||
326 | /** |
||
327 | * @param int $maxParticipants |
||
328 | * |
||
329 | * @return CreateMeetingParameters |
||
330 | */ |
||
331 | public function setMaxParticipants($maxParticipants) |
||
337 | |||
338 | /** |
||
339 | * @return bool |
||
340 | */ |
||
341 | public function isRecorded() |
||
345 | |||
346 | /** |
||
347 | * @param bool $record |
||
348 | * |
||
349 | * @return CreateMeetingParameters |
||
350 | */ |
||
351 | public function setRecord($record) |
||
357 | |||
358 | /** |
||
359 | * @return bool |
||
360 | */ |
||
361 | public function isAutoStartRecording() |
||
365 | |||
366 | /** |
||
367 | * @param bool $autoStartRecording |
||
368 | * |
||
369 | * @return CreateMeetingParameters |
||
370 | */ |
||
371 | public function setAutoStartRecording($autoStartRecording) |
||
377 | |||
378 | /** |
||
379 | * @return bool |
||
380 | */ |
||
381 | public function isAllowStartStopRecording() |
||
385 | |||
386 | /** |
||
387 | * @param bool $allowStartStopRecording |
||
388 | * |
||
389 | * @return CreateMeetingParameters |
||
390 | */ |
||
391 | public function setAllowStartStopRecording($allowStartStopRecording) |
||
397 | |||
398 | /** |
||
399 | * @return int |
||
400 | */ |
||
401 | public function getDuration() |
||
405 | |||
406 | /** |
||
407 | * @param int $duration |
||
408 | * |
||
409 | * @return CreateMeetingParameters |
||
410 | */ |
||
411 | public function setDuration($duration) |
||
417 | |||
418 | /** |
||
419 | * @return string |
||
420 | */ |
||
421 | public function getWelcomeMessage() |
||
425 | |||
426 | /** |
||
427 | * @param string $welcomeMessage |
||
428 | * |
||
429 | * @return CreateMeetingParameters |
||
430 | */ |
||
431 | public function setWelcomeMessage($welcomeMessage) |
||
437 | |||
438 | /** |
||
439 | * @return string |
||
440 | */ |
||
441 | public function getModeratorOnlyMessage() |
||
445 | |||
446 | /** |
||
447 | * @param string $message |
||
448 | * |
||
449 | * @return CreateMeetingParameters |
||
450 | */ |
||
451 | public function setModeratorOnlyMessage($message) |
||
457 | |||
458 | /** |
||
459 | * @return bool |
||
460 | */ |
||
461 | public function isWebcamsOnlyForModerator() |
||
465 | |||
466 | /** |
||
467 | * @param bool $webcamsOnlyForModerator |
||
468 | * @return CreateMeetingParameters |
||
469 | */ |
||
470 | public function setWebcamsOnlyForModerator($webcamsOnlyForModerator) |
||
476 | |||
477 | /** |
||
478 | * @return string |
||
479 | */ |
||
480 | public function getLogo() |
||
484 | |||
485 | /** |
||
486 | * @param string $logo |
||
487 | * @return CreateMeetingParameters |
||
488 | */ |
||
489 | public function setLogo($logo) |
||
495 | |||
496 | /** |
||
497 | * @return string |
||
498 | */ |
||
499 | public function getCopyright() |
||
503 | |||
504 | /** |
||
505 | * @param string $copyright |
||
506 | * @return CreateMeetingParameters |
||
507 | */ |
||
508 | public function setCopyright($copyright) |
||
514 | |||
515 | /** |
||
516 | * @return bool |
||
517 | */ |
||
518 | public function isMuteOnStart() |
||
522 | |||
523 | /** |
||
524 | * @param bool $muteOnStart |
||
525 | * @return CreateMeetingParameters |
||
526 | */ |
||
527 | public function setMuteOnStart($muteOnStart) |
||
533 | |||
534 | /** |
||
535 | * @param $endCallbackUrl |
||
536 | * @return CreateMeetingParameters |
||
537 | */ |
||
538 | public function setEndCallbackUrl($endCallbackUrl) |
||
544 | |||
545 | /** |
||
546 | * @return bool |
||
547 | */ |
||
548 | public function isBreakout() |
||
552 | |||
553 | /** |
||
554 | * @param bool $isBreakout |
||
555 | * @return CreateMeetingParameters |
||
556 | */ |
||
557 | public function setBreakout($isBreakout) |
||
563 | |||
564 | /** |
||
565 | * @return string |
||
566 | */ |
||
567 | public function getParentMeetingId() |
||
571 | |||
572 | /** |
||
573 | * @param string $parentMeetingId |
||
574 | * @return CreateMeetingParameters |
||
575 | */ |
||
576 | public function setParentMeetingId($parentMeetingId) |
||
582 | |||
583 | /** |
||
584 | * @return int |
||
585 | */ |
||
586 | public function getSequence() |
||
590 | |||
591 | /** |
||
592 | * @param int $sequence |
||
593 | * @return CreateMeetingParameters |
||
594 | */ |
||
595 | public function setSequence($sequence) |
||
601 | |||
602 | /** |
||
603 | * @return bool |
||
604 | */ |
||
605 | public function isFreeJoin() |
||
609 | |||
610 | /** |
||
611 | * @param bool $freeJoin |
||
612 | * @return CreateMeetingParameters |
||
613 | */ |
||
614 | public function setFreeJoin($freeJoin) |
||
620 | |||
621 | /** |
||
622 | * @return array |
||
623 | */ |
||
624 | public function getPresentations() |
||
628 | |||
629 | /** |
||
630 | * @param $nameOrUrl |
||
631 | * @param null $content |
||
632 | * @param null $filename |
||
633 | * |
||
634 | * @return CreateMeetingParameters |
||
635 | */ |
||
636 | public function addPresentation($nameOrUrl, $content = null, $filename = null) |
||
646 | |||
647 | /** |
||
648 | * @return mixed |
||
649 | */ |
||
650 | public function getPresentationsAsXML() |
||
677 | |||
678 | /** |
||
679 | * @return string |
||
680 | */ |
||
681 | public function getHTTPQuery() |
||
719 | } |
||
720 |