Complex classes like CreateMeetingParameters often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CreateMeetingParameters, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 24 | class CreateMeetingParameters extends MetaParameters |
||
| 25 | { |
||
| 26 | /** |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | private $meetingId; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @var string |
||
| 33 | */ |
||
| 34 | private $meetingName; |
||
| 35 | |||
| 36 | /** |
||
| 37 | * @var string |
||
| 38 | */ |
||
| 39 | private $attendeePassword; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * @var string |
||
| 43 | */ |
||
| 44 | private $moderatorPassword; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @var string |
||
| 48 | */ |
||
| 49 | private $dialNumber; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * @var int |
||
| 53 | */ |
||
| 54 | private $voiceBridge; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @var string |
||
| 58 | */ |
||
| 59 | private $webVoice; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var string |
||
| 63 | */ |
||
| 64 | private $logoutUrl; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @var int |
||
| 68 | */ |
||
| 69 | private $maxParticipants; |
||
| 70 | |||
| 71 | /** |
||
| 72 | * @var bool |
||
| 73 | */ |
||
| 74 | private $record; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * @var bool |
||
| 78 | */ |
||
| 79 | private $autoStartRecording; |
||
| 80 | |||
| 81 | /** |
||
| 82 | * @var bool |
||
| 83 | */ |
||
| 84 | private $allowStartStopRecording; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @var int |
||
| 88 | */ |
||
| 89 | private $duration; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * @var string |
||
| 93 | */ |
||
| 94 | private $welcomeMessage; |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @var string |
||
| 98 | */ |
||
| 99 | private $moderatorOnlyMessage; |
||
| 100 | |||
| 101 | /** |
||
| 102 | * @var array |
||
| 103 | */ |
||
| 104 | private $presentations = []; |
||
| 105 | |||
| 106 | /** |
||
| 107 | * CreateMeetingParameters constructor. |
||
| 108 | * |
||
| 109 | * @param $meetingId |
||
| 110 | * @param $meetingName |
||
| 111 | */ |
||
| 112 | public function __construct($meetingId, $meetingName) |
||
| 117 | |||
| 118 | /** |
||
| 119 | * @return string |
||
| 120 | */ |
||
| 121 | public function getMeetingId() |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @param string $meetingId |
||
| 128 | * |
||
| 129 | * @return CreateMeetingParameters |
||
| 130 | */ |
||
| 131 | public function setMeetingId($meetingId) |
||
| 137 | |||
| 138 | /** |
||
| 139 | * @return string |
||
| 140 | */ |
||
| 141 | public function getMeetingName() |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @param string $meetingName |
||
| 148 | * |
||
| 149 | * @return CreateMeetingParameters |
||
| 150 | */ |
||
| 151 | public function setMeetingName($meetingName) |
||
| 157 | |||
| 158 | /** |
||
| 159 | * @return string |
||
| 160 | */ |
||
| 161 | public function getAttendeePassword() |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @param string $attendeePassword |
||
| 168 | * |
||
| 169 | * @return CreateMeetingParameters |
||
| 170 | */ |
||
| 171 | public function setAttendeePassword($attendeePassword) |
||
| 177 | |||
| 178 | /** |
||
| 179 | * @return string |
||
| 180 | */ |
||
| 181 | public function getModeratorPassword() |
||
| 185 | |||
| 186 | /** |
||
| 187 | * @param string $moderatorPassword |
||
| 188 | * |
||
| 189 | * @return CreateMeetingParameters |
||
| 190 | */ |
||
| 191 | public function setModeratorPassword($moderatorPassword) |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @return string |
||
| 200 | */ |
||
| 201 | public function getDialNumber() |
||
| 205 | |||
| 206 | /** |
||
| 207 | * @param string $dialNumber |
||
| 208 | * |
||
| 209 | * @return CreateMeetingParameters |
||
| 210 | */ |
||
| 211 | public function setDialNumber($dialNumber) |
||
| 217 | |||
| 218 | /** |
||
| 219 | * @return int |
||
| 220 | */ |
||
| 221 | public function getVoiceBridge() |
||
| 225 | |||
| 226 | /** |
||
| 227 | * @param int $voiceBridge |
||
| 228 | * |
||
| 229 | * @return CreateMeetingParameters |
||
| 230 | */ |
||
| 231 | public function setVoiceBridge($voiceBridge) |
||
| 237 | |||
| 238 | /** |
||
| 239 | * @return string |
||
| 240 | */ |
||
| 241 | public function getWebVoice() |
||
| 245 | |||
| 246 | /** |
||
| 247 | * @param string $webVoice |
||
| 248 | * |
||
| 249 | * @return CreateMeetingParameters |
||
| 250 | */ |
||
| 251 | public function setWebVoice($webVoice) |
||
| 257 | |||
| 258 | /** |
||
| 259 | * @return string |
||
| 260 | */ |
||
| 261 | public function getLogoutUrl() |
||
| 265 | |||
| 266 | /** |
||
| 267 | * @param string $logoutUrl |
||
| 268 | * |
||
| 269 | * @return CreateMeetingParameters |
||
| 270 | */ |
||
| 271 | public function setLogoutUrl($logoutUrl) |
||
| 277 | |||
| 278 | /** |
||
| 279 | * @return int |
||
| 280 | */ |
||
| 281 | public function getMaxParticipants() |
||
| 285 | |||
| 286 | /** |
||
| 287 | * @param int $maxParticipants |
||
| 288 | * |
||
| 289 | * @return CreateMeetingParameters |
||
| 290 | */ |
||
| 291 | public function setMaxParticipants($maxParticipants) |
||
| 297 | |||
| 298 | /** |
||
| 299 | * @return bool |
||
| 300 | */ |
||
| 301 | public function isRecorded() |
||
| 302 | { |
||
| 303 | return $this->record; |
||
| 304 | } |
||
| 305 | |||
| 306 | /** |
||
| 307 | * @param bool $record |
||
| 308 | * |
||
| 309 | * @return CreateMeetingParameters |
||
| 310 | */ |
||
| 311 | public function setRecord($record) |
||
| 317 | |||
| 318 | /** |
||
| 319 | * @return bool |
||
| 320 | */ |
||
| 321 | public function isAutoStartRecording() |
||
| 325 | |||
| 326 | /** |
||
| 327 | * @param bool $autoStartRecording |
||
| 328 | * |
||
| 329 | * @return CreateMeetingParameters |
||
| 330 | */ |
||
| 331 | public function setAutoStartRecording($autoStartRecording) |
||
| 337 | |||
| 338 | /** |
||
| 339 | * @return bool |
||
| 340 | */ |
||
| 341 | public function isAllowStartStopRecording() |
||
| 345 | |||
| 346 | /** |
||
| 347 | * @param bool $autoStartRecording |
||
| 348 | * |
||
| 349 | * @return CreateMeetingParameters |
||
| 350 | */ |
||
| 351 | public function setAllowStartStopRecording($autoStartRecording) |
||
| 357 | |||
| 358 | /** |
||
| 359 | * @return int |
||
| 360 | */ |
||
| 361 | public function getDuration() |
||
| 365 | |||
| 366 | /** |
||
| 367 | * @param int $duration |
||
| 368 | * |
||
| 369 | * @return CreateMeetingParameters |
||
| 370 | */ |
||
| 371 | public function setDuration($duration) |
||
| 377 | |||
| 378 | /** |
||
| 379 | * @return string |
||
| 380 | */ |
||
| 381 | public function getWelcomeMessage() |
||
| 385 | |||
| 386 | /** |
||
| 387 | * @param string $welcomeMessage |
||
| 388 | * |
||
| 389 | * @return CreateMeetingParameters |
||
| 390 | */ |
||
| 391 | public function setWelcomeMessage($welcomeMessage) |
||
| 397 | |||
| 398 | /** |
||
| 399 | * @return string |
||
| 400 | */ |
||
| 401 | public function getModeratorOnlyMessage() |
||
| 405 | |||
| 406 | /** |
||
| 407 | * @param string $message |
||
| 408 | * |
||
| 409 | * @return CreateMeetingParameters |
||
| 410 | */ |
||
| 411 | public function setModeratorOnlyMessage($message) |
||
| 417 | |||
| 418 | /** |
||
| 419 | * @return array |
||
| 420 | */ |
||
| 421 | public function getPresentations() |
||
| 425 | |||
| 426 | /** |
||
| 427 | * @param $nameOrUrl |
||
| 428 | * @param null $content |
||
| 429 | * |
||
| 430 | * @return CreateMeetingParameters |
||
| 431 | */ |
||
| 432 | public function addPresentation($nameOrUrl, $content = null) |
||
| 438 | |||
| 439 | public function getPresentationsAsXML() |
||
| 461 | |||
| 462 | /** |
||
| 463 | * @return string |
||
| 464 | */ |
||
| 465 | public function getHTTPQuery() |
||
| 489 | } |
||
| 490 |