Memcache::updateExpire() - Code Metrics - Inspection of "Fix of the language used in the code" - bfw-systems/bfw - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.0 ( 572920...bfe862 )

by Vermeulen

created 2017-05-08 22:47 UTC

Memcache::updateExpire() B

↳ Parent: Memcache

Complexity

Conditions	5
Paths	5

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	29
rs	8.439
cc	5
eloc	15
nc	5
nop	2

<?php

namespace BFW\Traits;

use \Exception;

/**
 * Trait to regroup memcache(d) methods
 */
trait Memcache
{
    /**
     * Read the server information and add not existing keys
     * 
     * @param array &$infos Server informations
     * 
     * @return void
     * 
     * @throw \Exception If informations datas is not an array
     */
    protected function getServerInfos(&$infos)
    {
        if (!is_array($infos)) {
            throw new Exception(
                'Memcache(d) server information is not an array.'
            );
        }
        
        $infosKeyDefaultValues = [
            'host'       => null,
            'port'       => null,
            'weight'     => 0,
            'timeout'    => null,
            'persistent' => false
        ];
        
        foreach ($infosKeyDefaultValues as $infosKey => $defaultValue) {
            if (!isset($infos[$infosKey])) {
                $infos[$infosKey] = $defaultValue;
            }
        }
    }
    
    /**
     * Check if a key exists into memcache(d)
     * /!\ Not work if the correct value is the boolean false /!\
     * 
     * @param string $key The memcache(d) key to check
     * 
     * @return boolean
     * 
     * @throws Exception If the key is not a string
     */
    public function ifExists($key)
    {
        $verifParams = \BFW\Helpers\Datas::checkType([
            [
                'type' => 'string',
                'data' => $key
            ]
        ]);
        
        if (!$verifParams) {
            throw new Exception(
                'The $key parameters must be a string.'
                .' Currently the value is a/an '.gettype($key)
                .' and is equal to '.$key
            );
        }

        if ($this->get($key) === false) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return false;
        }

        return true;
    }

    /**
     * Update the expire time for a memcache(d) key.
     * 
     * @param string $key The memcache(d) key to update
     * @param int $expire The new expire time
     * 
     * @return boolean
     * 
     * @throws Exception
     */
    public function updateExpire($key, $expire)
    {
        $verifParams = \BFW\Helpers\Datas::checkType([
            ['type' => 'string', 'data' => $key],
            ['type' => 'int', 'data' => $expire]
        ]);

        if (!$verifParams) {
            throw new Exception(
                'Once of parameters $key or $expire not have a correct type.'
            );
        }
        
        if (!$this->ifExists($key)) {
            throw new Exception(
                'The key '.$key.' not exist on memcache(d) server'
            );
        }

        //To change expire time, we need to re-set the value.
        $value = $this->get($key); //Get the value
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        //Re-set the value with new expire time.
        if (is_subclass_of($this, '\Memcache')) {

            return $this->replace($key, $value, 0, $expire);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } elseif (is_subclass_of($this, '\Memcached')) {

            return $this->replace($key, $value, $expire);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php
2
3			namespace BFW\Traits;
4
5			use \Exception;
6
7			/**
8			* Trait to regroup memcache(d) methods
9			*/
10			trait Memcache
11			{
12			/**
13			* Read the server information and add not existing keys
14			*
15			* @param array &$infos Server informations
16			*
17			* @return void
18			*
19			* @throw \Exception If informations datas is not an array
20			*/
21			protected function getServerInfos(&$infos)
22			{
23			if (!is_array($infos)) {
24			throw new Exception(
25			'Memcache(d) server information is not an array.'
26			);
27			}
28
29			$infosKeyDefaultValues = [
30			'host' => null,
31			'port' => null,
32			'weight' => 0,
33			'timeout' => null,
34			'persistent' => false
35			];
36
37			foreach ($infosKeyDefaultValues as $infosKey => $defaultValue) {
38			if (!isset($infos[$infosKey])) {
39			$infos[$infosKey] = $defaultValue;
40			}
41			}
42			}
43
44			/**
45			* Check if a key exists into memcache(d)
46			* /!\ Not work if the correct value is the boolean false /!\
47			*
48			* @param string $key The memcache(d) key to check
49			*
50			* @return boolean
51			*
52			* @throws Exception If the key is not a string
53			*/
54			public function ifExists($key)
55			{
56			$verifParams = \BFW\Helpers\Datas::checkType([
57			[
58			'type' => 'string',
59			'data' => $key
60			]
61			]);
62
63			if (!$verifParams) {
64			throw new Exception(
65			'The $key parameters must be a string.'
66			.' Currently the value is a/an '.gettype($key)
67			.' and is equal to '.$key
68			);
69			}
70
71			if ($this->get($key) === false) {
			0 ignored issues – show Bug introduced 2017-05-08 22:49 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
72			return false;
73			}
74
75			return true;
76			}
77
78			/**
79			* Update the expire time for a memcache(d) key.
80			*
81			* @param string $key The memcache(d) key to update
82			* @param int $expire The new expire time
83			*
84			* @return boolean
85			*
86			* @throws Exception
87			*/
88			public function updateExpire($key, $expire)
89			{
90			$verifParams = \BFW\Helpers\Datas::checkType([
91			['type' => 'string', 'data' => $key],
92			['type' => 'int', 'data' => $expire]
93			]);
94
95			if (!$verifParams) {
96			throw new Exception(
97			'Once of parameters $key or $expire not have a correct type.'
98			);
99			}
100
101			if (!$this->ifExists($key)) {
102			throw new Exception(
103			'The key '.$key.' not exist on memcache(d) server'
104			);
105			}
106
107			//To change expire time, we need to re-set the value.
108			$value = $this->get($key); //Get the value
			0 ignored issues – show Bug introduced 2017-05-08 22:49 UTC by Report Bug Copy Issue Report It seems like `get()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
109
110			//Re-set the value with new expire time.
111			if (is_subclass_of($this, '\Memcache')) {
			0 ignored issues – show Bug introduced 2016-08-28 23:20 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
112			return $this->replace($key, $value, 0, $expire);
			0 ignored issues – show Bug introduced 2016-07-31 21:35 UTC by Report Bug Copy Issue Report It seems like `replace()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
113			} elseif (is_subclass_of($this, '\Memcached')) {
			0 ignored issues – show Bug introduced 2016-08-28 23:20 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
114			return $this->replace($key, $value, $expire);
			0 ignored issues – show Bug introduced 2016-08-28 23:20 UTC by Report Bug Copy Issue Report It seems like `replace()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
115			}
116			}
117			}
118

bfw-systems / bfw

GitHub Access Token became invalid

Push — 3.0 ( 572920...bfe862 )

Memcache::updateExpire() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like