Application::defineCoreSystemList() - Code Metrics - Inspection of "Rewrite Application class to split core system and..." - bfw-systems/bfw - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.0 ( fea5eb...c29f0e )

by Vermeulen

created 2018-08-03 16:17 UTC

Application::defineCoreSystemList() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.6666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace BFW\Install;

/**
 * Application class for install module script
 */
class Application extends \BFW\Application
{
    /**
     * {@inheritdoc}
     * Remove not used systems, and add new system used by installer
     */
    protected function defineCoreSystemList()
    {
        parent::defineCoreSystemList();
        
        //Remove not used systems
        unset(
            $this->coreSystemList['request'],
            $this->coreSystemList['session'],
            $this->coreSystemList['errors'],
            $this->coreSystemList['cli']
        );
        
        //Change ModuleList class
        $this->coreSystemList['moduleList'] = new Core\AppSystems\ModuleList;
        
        //Add new system : module installation system
        $this->coreSystemList['moduleInstall'] = new Core\AppSystems\ModuleInstall;
    }

    /**
     * {@inheritdoc}
     */
    public function run()
    {
        $this->getMonolog()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ->getLogger()
            ->debug('running framework install')
        ;
        
        $this->runTasks->run();
        $this->runTasks->sendNotify('bfw_modules_install_done');
    }
}


1			<?php
2
3			namespace BFW\Install;
4
5			/**
6			* Application class for install module script
7			*/
8			class Application extends \BFW\Application
9			{
10			/**
11			* {@inheritdoc}
12			* Remove not used systems, and add new system used by installer
13			*/
14			protected function defineCoreSystemList()
15			{
16			parent::defineCoreSystemList();
17
18			//Remove not used systems
19			unset(
20			$this->coreSystemList['request'],
21			$this->coreSystemList['session'],
22			$this->coreSystemList['errors'],
23			$this->coreSystemList['cli']
24			);
25
26			//Change ModuleList class
27			$this->coreSystemList['moduleList'] = new Core\AppSystems\ModuleList;
28
29			//Add new system : module installation system
30			$this->coreSystemList['moduleInstall'] = new Core\AppSystems\ModuleInstall;
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			public function run()
37			{
38			$this->getMonolog()
			0 ignored issues – show Documentation Bug introduced 2018-08-03 16:19 UTC by Report Bug Copy Issue Report The method `getMonolog` does not exist on `object<BFW\Install\Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
39			->getLogger()
40			->debug('running framework install')
41			;
42
43			$this->runTasks->run();
44			$this->runTasks->sendNotify('bfw_modules_install_done');
45			}
46			}
47

bfw-systems / bfw

GitHub Access Token became invalid

Push — 3.0 ( fea5eb...c29f0e )

Application::defineCoreSystemList() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like