BFW\Install\Core\AppSystems\ModuleInstall

Complexity

Total Complexity

16

Size/Duplication

Total Lines	130
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	4	1
A	getListToInstall()	0	4	1
A	init()	0	4	1
A	toRun()	0	4	1
A	run()	0	5	1
A	addToList()	0	8	1
A	installAllModules()	0	23	5
A	installModule()	0	24	5

<?php

namespace BFW\Install\Core\AppSystems;

use \BFW\Core\AppSystems\AbstractSystem;
use \BFW\Helpers\Cli;

class ModuleInstall extends AbstractSystem
{
    /**
     * @var \BFW\Install\ModuleInstall[] $listToInstall
     */
    protected $listToInstall = [];
    
    /**
     * {@inheritdoc}
     * 
     * @return $this
     */
    public function __invoke()
    {
        return $this;
    }
    
    /**
     * Getter accessor to property listToInstall
     * 
     * @return type
     */
    public function getListToInstall()
    {
        return $this->listToInstall;
    }
    
    /**
     * {@inheritdoc}
     */
    public function init()
    {
        $this->initStatus = true;
    }
    
    /**
     * {@inheritdoc}
     */
    public function toRun()
    {
        return true;
    }
    
    /**
     * {@inheritdoc}
     * Run install of all modules
     */
    public function run()
    {
        $this->installAllModules();
        $this->runStatus = true;
    }
    
    /**
     * Add a new module to the list to install
     * 
     * @param \BFW\Install\ModuleInstall $module The new module
     * 
     * @return $this
     */
    public function addToList(\BFW\Install\ModuleInstall $module)
    {
        $moduleName = $module->getName();
        
        $this->listToInstall[$moduleName] = $module;
        
        return $this;
    }
    
    /**
     * Install all modules in the order of the dependency tree.
     * 
     * @return void
     */
    protected function installAllModules()
    {
        Cli::displayMsgNL('Read all modules to run install script...');
        
        $tree = \BFW\Install\Application::getInstance()

The method getModuleList does not exist on object<BFW\Application>? Since you implemented __call, maybe consider adding a @method annotation.

            ->getModuleList()
            ->getLoadTree()
        ;

        foreach ($tree as $firstLine) {
            foreach ($firstLine as $secondLine) {
                foreach ($secondLine as $moduleName) {
                    if (!isset($this->listToInstall[$moduleName])) {
                        continue;
                    }
                    
                    $this->installModule($moduleName);
                }
            }
        }
        
        Cli::displayMsgNL('All modules have been read.');
    }
    
    /**
     * Install a module
     * 
     * @param string $moduleName The module name
     * 
     * @return void
     */
    protected function installModule($moduleName)
    {
        if (!isset($this->listToInstall[$moduleName])) {
            return;
        }
        
        Cli::displayMsgNL(' > Read for module '.$moduleName);
        
        $module         = $this->listToInstall[$moduleName];
        $installScripts = $module->getSourceInstallScript();
        
        if ($installScripts === '') {
            Cli::displayMsgNL(' >> No script to run.');
            return;
        }
        
        if (is_string($installScripts)) {
            $installScripts = (array) $installScripts;
        }
        
        foreach ($installScripts as $scriptPath) {

The expression $installScripts of type array|boolean is not guaranteed to be traversable. How about adding an additional type check?

            $module->runInstallScript($scriptPath);
        }
    }
}