Constants - Code Metrics - Inspection of "Rewrite Application class to split core system and..." - bfw-systems/bfw - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.0 ( fea5eb...c29f0e )

by Vermeulen

created 2018-08-03 16:17 UTC

Constants A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	3
dl	0
loc	47
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__invoke()	4	1
A	init()	18	1
A	obtainRootDir()	7	1

<?php

namespace BFW\Core\AppSystems;

class Constants extends AbstractSystem
{
    /**
     * {@inheritdoc}
     * @return null
     */
    public function __invoke()
    {
        return null;
    }

    /**
     * {@inheritdoc}
     * Define all constants
     */
    public function init()
    {
        \BFW\Helpers\Constants::create('ROOT_DIR', $this->obtainRootDir());

        \BFW\Helpers\Constants::create('APP_DIR', ROOT_DIR.'app/');
        \BFW\Helpers\Constants::create('SRC_DIR', ROOT_DIR.'src/');
        \BFW\Helpers\Constants::create('WEB_DIR', ROOT_DIR.'web/');

        \BFW\Helpers\Constants::create('CONFIG_DIR', APP_DIR.'config/');
        \BFW\Helpers\Constants::create('MODULES_DIR', APP_DIR.'modules/');

        \BFW\Helpers\Constants::create('CLI_DIR', SRC_DIR.'cli/');
        \BFW\Helpers\Constants::create('CTRL_DIR', SRC_DIR.'controllers/');
        \BFW\Helpers\Constants::create('MODELES_DIR', SRC_DIR.'modeles/');
        \BFW\Helpers\Constants::create('VIEW_DIR', SRC_DIR.'view/');
        
        $this->initStatus = true;
    }
    
    /**
     * Obtain the path of the application root directory
     * 
     * @return string
     */
    protected function obtainRootDir()
    {
        return \BFW\Application::getInstance()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ->getOptions()
            ->getValue('rootDir')
        ;
    }
}


1			<?php
2
3			namespace BFW\Core\AppSystems;
4
5			class Constants extends AbstractSystem
6			{
7			/**
8			* {@inheritdoc}
9			* @return null
10			*/
11			public function __invoke()
12			{
13			return null;
14			}
15
16			/**
17			* {@inheritdoc}
18			* Define all constants
19			*/
20			public function init()
21			{
22			\BFW\Helpers\Constants::create('ROOT_DIR', $this->obtainRootDir());
23
24			\BFW\Helpers\Constants::create('APP_DIR', ROOT_DIR.'app/');
25			\BFW\Helpers\Constants::create('SRC_DIR', ROOT_DIR.'src/');
26			\BFW\Helpers\Constants::create('WEB_DIR', ROOT_DIR.'web/');
27
28			\BFW\Helpers\Constants::create('CONFIG_DIR', APP_DIR.'config/');
29			\BFW\Helpers\Constants::create('MODULES_DIR', APP_DIR.'modules/');
30
31			\BFW\Helpers\Constants::create('CLI_DIR', SRC_DIR.'cli/');
32			\BFW\Helpers\Constants::create('CTRL_DIR', SRC_DIR.'controllers/');
33			\BFW\Helpers\Constants::create('MODELES_DIR', SRC_DIR.'modeles/');
34			\BFW\Helpers\Constants::create('VIEW_DIR', SRC_DIR.'view/');
35
36			$this->initStatus = true;
37			}
38
39			/**
40			* Obtain the path of the application root directory
41			*
42			* @return string
43			*/
44			protected function obtainRootDir()
45			{
46			return \BFW\Application::getInstance()
			0 ignored issues – show Documentation Bug introduced 2018-08-03 16:19 UTC by Report Bug Copy Issue Report The method `getOptions` does not exist on `object<BFW\Application>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
47			->getOptions()
48			->getValue('rootDir')
49			;
50			}
51			}
52

bfw-systems / bfw

Push — 3.0 ( fea5eb...c29f0e )

Constants A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like