Observer::updateWithAction() - Code Metrics - Inspection of "Merge pull request #68 from bulton-fr/2.2" - bfw-systems/bfw - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3e2e1a...d57d41 )

by Vermeulen

created 2017-10-13 23:16 UTC

Observer::updateWithAction() C

↳ Parent: Observer

Complexity

Conditions	10
Paths	14

Size

Total Lines	70
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	10
eloc	33
c	2
b	0
f	1
nc	14
nop	2
dl	0
loc	70
rs	5.9999
ccs	0
cts	40
cp	0
crap	110

How to fix Long Method Complexity

<?php
/**
 * Classes en rapport avec les observers
 * @author Vermeulen Maxime <[email protected]>
 * @version 1.0
 */

namespace BFW;

use \Exception;
use \SplSubject;

/**
 * Classe Observer
 * @package bfw
 */
class Observer implements \SplObserver
{
    /**
     * Méthode par défaut appelé lorsque l'observer se déclanche
     * 
     * @param SplSubject $subject Le sujet déclanchant l'observer
     */
    public function update(SplSubject $subject)
    {
        
    }
    
    /**
     * Méthode appelé lorsque l'observer se déclanche via la classe Kernel
     * 
     * @param SplSubject $subject Le sujet déclanchant l'observer
     * @param string     $action  L'action à faire lors du déclanchement
     * 
     * @throws \Exception : Si le paramètre $subject n'est pas un objet ou n'est pas une instance de \BFW\Kernel
     */
    public function updateWithAction($subject, $action)
    {
        if(!is_object($subject))
        {
            throw new Exception('Le paramètre $subject doit être un objet.');
        }
        elseif(is_object($subject) && get_class($subject) != '\SplSubject')
        {
            throw new Exception('Le paramètre $subject doit être un objet de type \SplSubject.');
        }
        
        //Gestion de l'action.
        /*
         * $action : 
         *  Maclass::MaMethode()
         *  Maclass->MaMethode()
         *  MaFonction()
        */
        //Il faut gérer la porter des variables (classe/arguments)
        
        $class = null;
        $args = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        
        $match = array();
        $regex = '([0-9a-zA-Z.,_-]+)';
        $regex2 = '([0-9a-zA-Z.,_-]*)';
        
        if(strpos($action, '::') !== false)
        {
            $preg_match = preg_match('^'.$regex.'::'.$regex.'\('.$regex2.'\);$', $action, $match);
            $class = $match[1];
            $args = $match[3];
        }
        elseif(strpos($action, '->') !== false)
        {
            $preg_match = preg_match('^'.$regex.'::'.$regex.'\('.$regex2.'\);$', $action, $match);
            $class = $match[1];
            $args = $match[3];
        }
        else
        {
            $preg_match = preg_match('^'.$regex.'\('.$regex2.'\);$', $action, $match);
            $args = $match[2]; 
        }
        
        if(!is_null($class))
        {
            $class = str_replace('$', '', $class);
            global ${$class};
        }
             
        if(!is_null($args))
        {
            $args = explode(',', $args);
            foreach($args as $arg)
            {
                $arg = str_replace('$', '', $arg);
                global ${$arg};
            }
        }
        
        try
        {
            eval($action);
        }
        catch(\Exception $e)
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        {
            echo $e->getMessage();
        }
    }
}


1		<?php
2		/**
3		* Classes en rapport avec les observers
4		* @author Vermeulen Maxime <[email protected]>
5		* @version 1.0
6		*/
7
8		namespace BFW;
9
10		use \Exception;
11		use \SplSubject;
12
13		/**
14		* Classe Observer
15		* @package bfw
16		*/
17		class Observer implements \SplObserver
18		{
19		/**
20		* Méthode par défaut appelé lorsque l'observer se déclanche
21		*
22		* @param SplSubject $subject Le sujet déclanchant l'observer
23		*/
24		public function update(SplSubject $subject)
25		{
26
27	1	}
28
29		/**
30		* Méthode appelé lorsque l'observer se déclanche via la classe Kernel
31		*
32		* @param SplSubject $subject Le sujet déclanchant l'observer
33		* @param string $action L'action à faire lors du déclanchement
34		*
35		* @throws \Exception : Si le paramètre $subject n'est pas un objet ou n'est pas une instance de \BFW\Kernel
36		*/
37		public function updateWithAction($subject, $action)
38		{
39		if(!is_object($subject))
40		{
41		throw new Exception('Le paramètre $subject doit être un objet.');
42		}
43		elseif(is_object($subject) && get_class($subject) != '\SplSubject')
44		{
45		throw new Exception('Le paramètre $subject doit être un objet de type \SplSubject.');
46		}
47
48		//Gestion de l'action.
49		/*
50		* $action :
51		* Maclass::MaMethode()
52		* Maclass->MaMethode()
53		* MaFonction()
54		*/
55		//Il faut gérer la porter des variables (classe/arguments)
56
57		$class = null;
58		$args = null;
		0 ignored issues – show Unused Code introduced 2016-01-16 16:22 UTC by Report Bug Copy Issue Report `$args` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
59
60		$match = array();
61		$regex = '([0-9a-zA-Z.,_-]+)';
62		$regex2 = '([0-9a-zA-Z.,_-]*)';
63
64		if(strpos($action, '::') !== false)
65		{
66		$preg_match = preg_match('^'.$regex.'::'.$regex.'\('.$regex2.'\);$', $action, $match);
67		$class = $match[1];
68		$args = $match[3];
69		}
70		elseif(strpos($action, '->') !== false)
71		{
72		$preg_match = preg_match('^'.$regex.'::'.$regex.'\('.$regex2.'\);$', $action, $match);
73		$class = $match[1];
74		$args = $match[3];
75		}
76		else
77		{
78		$preg_match = preg_match('^'.$regex.'\('.$regex2.'\);$', $action, $match);
79		$args = $match[2];
80		}
81
82		if(!is_null($class))
83		{
84		$class = str_replace('$', '', $class);
85		global ${$class};
86		}
87
88		if(!is_null($args))
89		{
90		$args = explode(',', $args);
91		foreach($args as $arg)
92		{
93		$arg = str_replace('$', '', $arg);
94		global ${$arg};
95		}
96		}
97
98		try
99		{
100		eval($action);
101		}
102		catch(\Exception $e)
		0 ignored issues – show Unused Code introduced 2016-01-16 16:22 UTC by Report Bug Copy Issue Report `catch (\Exception $e) { ...cho $e->getMessage(); }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
103		{
104		echo $e->getMessage();
105		}
106		}
107		}
108

bfw-systems / bfw

GitHub Access Token became invalid

Push — master ( 3e2e1a...d57d41 )

Observer::updateWithAction() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like