beyondcode / laravel-websockets

src/Console/Commands/CleanStatistics.php

<?php

namespace BeyondCode\LaravelWebSockets\Console\Commands;

use BeyondCode\LaravelWebSockets\Facades\StatisticsStore;
use Illuminate\Console\Command;

class CleanStatistics extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'websockets:clean
        {appId? : (optional) The app id that will be cleaned.}
        {--days= : Delete records older than this amount of days since now.}
    ';

    /**
     * The console command description.
     *
     * @var string|null
     */
    protected $description = 'Clean up old statistics from the WebSocket statistics storage.';

    /**
     * Run the command.
     *
     * @return void
     */
    public function handle()
    {
        $this->comment('Cleaning WebSocket Statistics...');

        $days = $this->option('days') ?: config('statistics.delete_statistics_older_than_days');

        $amountDeleted = StatisticsStore::delete(
            now()->subDays($days), $this->argument('appId')

It seems like $days can also be of type string; however, parameter $value of Carbon\Carbon::subDays() does only seem to accept integer, maybe add an additional type check?

It seems like $this->argument('appId') can also be of type array; however, parameter $appId of BeyondCode\LaravelWebSockets\Contracts\StatisticsStore::delete() does only seem to accept integer|null|string, maybe add an additional type check?

        );

        $this->info("Deleted {$amountDeleted} record(s) from the WebSocket statistics storage.");
    }
}