beyondcode / laravel-websockets

src/Server/Logger/HttpLogger.php

<?php

namespace BeyondCode\LaravelWebSockets\Server\Logger;

use Exception;
use Ratchet\ConnectionInterface;
use Ratchet\MessageComponentInterface;

class HttpLogger extends Logger implements MessageComponentInterface
{
    /** @var \Ratchet\Http\HttpServerInterface */
    protected $app;

    public static function decorate(MessageComponentInterface $app): self
    {
        $logger = app(self::class);

        return $logger->setApp($app);
    }

    public function setApp(MessageComponentInterface $app)
    {
        $this->app = $app;

$app is of type object<Ratchet\MessageComponentInterface>, but the property $app was declared to be of type object<Ratchet\Http\HttpServerInterface>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    public function onOpen(ConnectionInterface $connection)
    {
        $this->app->onOpen($connection);
    }

    public function onMessage(ConnectionInterface $connection, $message)
    {
        $this->app->onMessage($connection, $message);
    }

    public function onClose(ConnectionInterface $connection)
    {
        $this->app->onClose($connection);
    }

    public function onError(ConnectionInterface $connection, Exception $exception)
    {
        $exceptionClass = get_class($exception);

        $message = "Exception `{$exceptionClass}` thrown: `{$exception->getMessage()}`";

        if ($this->verbose) {
            $message .= $exception->getTraceAsString();
        }

        $this->error($message);

        $this->app->onError($connection, $exception);
    }
}