Unsubscribed::__construct() - Code Metrics - Inspection of "[2.x] Major refactoring" - beyondcode/laravel-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#447)

by Alexandru

created 2020-09-06 16:44 UTC

Unsubscribed::__construct() A

↳ Parent: Unsubscribed

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	5
Ratio	100 %

Importance

Changes

Metric	Value
dl	5
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace BeyondCode\LaravelWebSockets\Events;

use Illuminate\Foundation\Events\Dispatchable;
use Illuminate\Queue\SerializesModels;
use Ratchet\ConnectionInterface;

class Unsubscribed

{
    use Dispatchable, SerializesModels;

    /**
     * The channel name the user has unsubscribed from.
     *
     * @var string
     */
    protected $channelName;

    /**
     * The connection that initiated the unsubscription.
     *
     * @var \Ratchet\ConnectionInterface
     */
    protected $connection;

    /**
     * Initialize the event.
     *
     * @param  string  $channelName
     * @param  \Ratchet\ConnectionInterface  $connection
     * @return void

     */
    public function __construct(string $channelName, ConnectionInterface $connection)
    {
        $this->channelName = $channelName;
        $this->connection = $connection;
    }
}


1		<?php
2
3		namespace BeyondCode\LaravelWebSockets\Events;
4
5		use Illuminate\Foundation\Events\Dispatchable;
6		use Illuminate\Queue\SerializesModels;
7		use Ratchet\ConnectionInterface;
8
9	View Code Duplication	class Unsubscribed
		0 ignored issues – show Duplication introduced 2020-09-02 14:18 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		use Dispatchable, SerializesModels;
12
13		/**
14		* The channel name the user has unsubscribed from.
15		*
16		* @var string
17		*/
18		protected $channelName;
19
20		/**
21		* The connection that initiated the unsubscription.
22		*
23		* @var \Ratchet\ConnectionInterface
24		*/
25		protected $connection;
26
27		/**
28		* Initialize the event.
29		*
30		* @param string $channelName
31		* @param \Ratchet\ConnectionInterface $connection
32		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2020-09-02 14:18 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
33		*/
34		public function __construct(string $channelName, ConnectionInterface $connection)
35		{
36		$this->channelName = $channelName;
37		$this->connection = $connection;
38		}
39		}
40

beyondcode / laravel-websockets

Pull Request — master (#447)

Unsubscribed::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like