AppsController::edit() - Code Metrics - Inspection of "Feature apps from database table" - beyondcode/laravel-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#90)

unknown

created 2019-01-16 10:39 UTC

AppsController::edit() A

↳ Parent: AppsController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace BeyondCode\LaravelWebSockets\Database\Http\Controllers;

use Illuminate\Http\Request;
use BeyondCode\LaravelWebSockets\Database\Models\App;
use BeyondCode\LaravelWebSockets\Database\Http\Requests\StoreWebSocketsApp;

class AppsController
{
    /**
     * Display a listing of the resource.
     *
     * @param  Request $request
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $apps = App::when($request->has('q'), function ($query) use ($request) {
            $query->whereLike('name', $request->get('q'));
        })->get();

        return view('websockets::apps.index', [
            'apps' => $apps,
        ]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('websockets::apps.edit', [
            'app' => new App(),
        ]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  StoreWebSocketsApp  $request
     * @return \Illuminate\Http\Response
     */
    public function store(StoreWebSocketsApp $request)

    {
        $app = new App();

        $app->name = $request->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->host = $request->host;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->enable_client_messages = $request->get('enable_client_messages', false);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->enable_statistics = $request->get('enable_statistics', false);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->save();

        return redirect(route('websockets.admin.edit', ['app' => $app->id]))->with('success', 'Record created.');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  App  $app
     * @return \Illuminate\Http\Response
     */
    public function edit(App $app)
    {
        return view('websockets::apps.edit', [
            'app' => $app,
        ]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  StoreWebSocketsApp  $request
     * @param  App  $app
     * @return \Illuminate\Http\Response
     */
    public function update(StoreWebSocketsApp $request, App $app)

    {
        $app->name = $request->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->host = $request->host;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->enable_client_messages = $request->get('enable_client_messages', false);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->enable_statistics = $request->get('enable_statistics', false);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $app->save();

        return redirect(route('websockets.admin.edit', ['app' => $app->id]))->with('success', 'Record saved.');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  App  $app
     * @return \Illuminate\Http\Response
     */
    public function destroy(App $app)
    {
        $app->delete();

        return redirect(route('websockets.admin.index'))->with('success', 'Record deleted.');
    }
}


1		<?php
2
3		namespace BeyondCode\LaravelWebSockets\Database\Http\Controllers;
4
5		use Illuminate\Http\Request;
6		use BeyondCode\LaravelWebSockets\Database\Models\App;
7		use BeyondCode\LaravelWebSockets\Database\Http\Requests\StoreWebSocketsApp;
8
9		class AppsController
10		{
11		/**
12		* Display a listing of the resource.
13		*
14		* @param Request $request
15		* @return \Illuminate\Http\Response
16		*/
17		public function index(Request $request)
18		{
19		$apps = App::when($request->has('q'), function ($query) use ($request) {
20		$query->whereLike('name', $request->get('q'));
21		})->get();
22
23		return view('websockets::apps.index', [
24		'apps' => $apps,
25		]);
26		}
27
28		/**
29		* Show the form for creating a new resource.
30		*
31		* @return \Illuminate\Http\Response
32		*/
33		public function create()
34		{
35		return view('websockets::apps.edit', [
36		'app' => new App(),
37		]);
38		}
39
40		/**
41		* Store a newly created resource in storage.
42		*
43		* @param StoreWebSocketsApp $request
44		* @return \Illuminate\Http\Response
45		*/
46	View Code Duplication	public function store(StoreWebSocketsApp $request)
		0 ignored issues – show Duplication introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$app = new App();
49
50		$app->name = $request->name;
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist in `BeyondCode\LaravelWebSoc...ests\StoreWebSocketsApp`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
51		$app->host = $request->host;
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `host` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `host` does not seem to exist in `BeyondCode\LaravelWebSoc...ests\StoreWebSocketsApp`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
52		$app->enable_client_messages = $request->get('enable_client_messages', false);
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `enable_client_messages` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
53		$app->enable_statistics = $request->get('enable_statistics', false);
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `enable_statistics` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54		$app->save();
55
56		return redirect(route('websockets.admin.edit', ['app' => $app->id]))->with('success', 'Record created.');
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
57		}
58
59		/**
60		* Show the form for editing the specified resource.
61		*
62		* @param App $app
63		* @return \Illuminate\Http\Response
64		*/
65		public function edit(App $app)
66		{
67		return view('websockets::apps.edit', [
68		'app' => $app,
69		]);
70		}
71
72		/**
73		* Update the specified resource in storage.
74		*
75		* @param StoreWebSocketsApp $request
76		* @param App $app
77		* @return \Illuminate\Http\Response
78		*/
79	View Code Duplication	public function update(StoreWebSocketsApp $request, App $app)
		0 ignored issues – show Duplication introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		{
81		$app->name = $request->name;
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist in `BeyondCode\LaravelWebSoc...ests\StoreWebSocketsApp`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
82		$app->host = $request->host;
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `host` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `host` does not seem to exist in `BeyondCode\LaravelWebSoc...ests\StoreWebSocketsApp`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
83		$app->enable_client_messages = $request->get('enable_client_messages', false);
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `enable_client_messages` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
84		$app->enable_statistics = $request->get('enable_statistics', false);
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `enable_statistics` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
85		$app->save();
86
87		return redirect(route('websockets.admin.edit', ['app' => $app->id]))->with('success', 'Record saved.');
		0 ignored issues – show Documentation introduced 2019-01-16 10:36 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<BeyondCode\Larave...ts\Database\Models\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
88		}
89
90		/**
91		* Remove the specified resource from storage.
92		*
93		* @param App $app
94		* @return \Illuminate\Http\Response
95		*/
96		public function destroy(App $app)
97		{
98		$app->delete();
99
100		return redirect(route('websockets.admin.index'))->with('success', 'Record deleted.');
101		}
102		}
103

beyondcode / laravel-websockets

Pull Request — master (#90)

AppsController::edit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like