Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class StartServer extends Command |
||
18 | { |
||
19 | /** |
||
20 | * The name and signature of the console command. |
||
21 | * |
||
22 | * @var string |
||
23 | */ |
||
24 | protected $signature = 'websockets:serve |
||
25 | {--host=0.0.0.0} |
||
26 | {--port=6001} |
||
27 | {--disable-statistics : Disable the statistics tracking.} |
||
28 | {--statistics-interval= : The amount of seconds to tick between statistics saving.} |
||
29 | {--debug : Forces the loggers to be enabled and thereby overriding the APP_DEBUG setting.} |
||
30 | {--test : Prepare the server, but do not start it.} |
||
31 | '; |
||
32 | |||
33 | /** |
||
34 | * The console command description. |
||
35 | * |
||
36 | * @var string|null |
||
37 | */ |
||
38 | protected $description = 'Start the LaravelWebSockets server.'; |
||
39 | |||
40 | /** |
||
41 | * Get the loop instance. |
||
42 | * |
||
43 | * @var \React\EventLoop\LoopInterface |
||
44 | */ |
||
45 | protected $loop; |
||
46 | |||
47 | /** |
||
48 | * The Pusher server instance. |
||
49 | * |
||
50 | * @var \Ratchet\Server\IoServer |
||
51 | */ |
||
52 | public $server; |
||
53 | |||
54 | /** |
||
55 | * Initialize the command. |
||
56 | * |
||
57 | * @return void |
||
|
|||
58 | */ |
||
59 | public function __construct() |
||
65 | |||
66 | /** |
||
67 | * Run the command. |
||
68 | * |
||
69 | * @return void |
||
70 | */ |
||
71 | public function handle() |
||
83 | |||
84 | /** |
||
85 | * Configure the loggers used for the console. |
||
86 | * |
||
87 | * @return void |
||
88 | */ |
||
89 | protected function configureLoggers() |
||
95 | |||
96 | /** |
||
97 | * Register the managers that are not resolved |
||
98 | * in the package service provider. |
||
99 | * |
||
100 | * @return void |
||
101 | */ |
||
102 | protected function configureManagers() |
||
112 | |||
113 | /** |
||
114 | * Register the Statistics Collectors that |
||
115 | * are not resolved in the package service provider. |
||
116 | * |
||
117 | * @return void |
||
118 | */ |
||
119 | protected function configureStatistics() |
||
145 | |||
146 | /** |
||
147 | * Configure the restart timer. |
||
148 | * |
||
149 | * @return void |
||
150 | */ |
||
151 | public function configureRestartTimer() |
||
161 | |||
162 | /** |
||
163 | * Configure the HTTP logger class. |
||
164 | * |
||
165 | * @return void |
||
166 | */ |
||
167 | View Code Duplication | protected function configureHttpLogger() |
|
175 | |||
176 | /** |
||
177 | * Configure the logger for messages. |
||
178 | * |
||
179 | * @return void |
||
180 | */ |
||
181 | View Code Duplication | protected function configureMessageLogger() |
|
189 | |||
190 | /** |
||
191 | * Configure the connection logger. |
||
192 | * |
||
193 | * @return void |
||
194 | */ |
||
195 | protected function configureConnectionLogger() |
||
203 | |||
204 | /** |
||
205 | * Start the server. |
||
206 | * |
||
207 | * @return void |
||
208 | */ |
||
209 | protected function startServer() |
||
225 | |||
226 | /** |
||
227 | * Build the server instance. |
||
228 | * |
||
229 | * @return void |
||
230 | */ |
||
231 | protected function buildServer() |
||
243 | |||
244 | /** |
||
245 | * Get the last time the server restarted. |
||
246 | * |
||
247 | * @return int |
||
248 | */ |
||
249 | protected function getLastRestart() |
||
255 | } |
||
256 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.