SendMessage::getPusherBroadcaster() - Code Metrics - Inspection of "[2.x] Major refactoring" - beyondcode/laravel-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#447)

by Marcel

created 2020-09-02 14:17 UTC

SendMessage::getPusherBroadcaster() A

↳ Parent: SendMessage::__invoke()

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace BeyondCode\LaravelWebSockets\Dashboard\Http\Controllers;

use BeyondCode\LaravelWebSockets\Concerns\PushesToPusher;
use BeyondCode\LaravelWebSockets\Statistics\Rules\AppId;
use Exception;
use Illuminate\Http\Request;

class SendMessage
{
    use PushesToPusher;

    /**
     * Send the message to the requested channel.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function __invoke(Request $request)
    {
        $request->validate([

            'appId' => ['required', new AppId],
            'key' => 'required|string',
            'secret' => 'required|string',
            'channel' => 'required|string',
            'event' => 'required|string',
            'data' => 'required|json',
        ]);

        $broadcaster = $this->getPusherBroadcaster([
            'key' => $request->key,
            'secret' => $request->secret,
            'id' => $request->appId,
        ]);

        try {
            $decodedData = @json_decode($request->data, true);

            $broadcaster->broadcast(
                [$request->channel],
                $request->event,
                $decodedData ?: []
            );
        } catch (Exception $e) {
            return response()->json([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'ok' => false,
                'exception' => $e->getMessage(),
            ]);
        }

        return response()->json([
            'ok' => true,
        ]);
    }
}


1			<?php
2
3			namespace BeyondCode\LaravelWebSockets\Dashboard\Http\Controllers;
4
5			use BeyondCode\LaravelWebSockets\Concerns\PushesToPusher;
6			use BeyondCode\LaravelWebSockets\Statistics\Rules\AppId;
7			use Exception;
8			use Illuminate\Http\Request;
9
10			class SendMessage
11			{
12			use PushesToPusher;
13
14			/**
15			* Send the message to the requested channel.
16			*
17			* @param \Illuminate\Http\Request $request
18			* @return \Illuminate\Http\Response
19			*/
20			public function __invoke(Request $request)
21			{
22			$request->validate([
			0 ignored issues – show Bug introduced 2020-08-24 06:54 UTC by Report Bug Copy Issue Report The call to `validate()` misses a required argument `$...$params`. This check looks for function calls that miss required arguments. Loading history...
23			'appId' => ['required', new AppId],
24			'key' => 'required\|string',
25			'secret' => 'required\|string',
26			'channel' => 'required\|string',
27			'event' => 'required\|string',
28			'data' => 'required\|json',
29			]);
30
31			$broadcaster = $this->getPusherBroadcaster([
32			'key' => $request->key,
33			'secret' => $request->secret,
34			'id' => $request->appId,
35			]);
36
37			try {
38			$decodedData = @json_decode($request->data, true);
39
40			$broadcaster->broadcast(
41			[$request->channel],
42			$request->event,
43			$decodedData ?: []
44			);
45			} catch (Exception $e) {
46			return response()->json([
			0 ignored issues – show Bug introduced 2020-08-24 06:54 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
47			'ok' => false,
48			'exception' => $e->getMessage(),
49			]);
50			}
51
52			return response()->json([
53			'ok' => true,
54			]);
55			}
56			}
57

beyondcode / laravel-websockets

Pull Request — master (#447)

SendMessage::getPusherBroadcaster() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like