BeyondCode\LaravelWebSockets\Server\Loggers\ConnectionLogger

Complexity

Total Complexity

8

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	decorate()	0	6	1
A	setConnection()	0	6	1
A	send()	0	8	1
A	close()	0	6	1
A	__set()	0	4	1
A	__get()	0	4	1
A	__isset()	0	4	1
A	__unset()	0	4	1

<?php

namespace BeyondCode\LaravelWebSockets\Server\Loggers;

use Ratchet\ConnectionInterface;

class ConnectionLogger extends Logger implements ConnectionInterface
{
    /**
     * The connection to watch.
     *
     * @var \Ratchet\ConnectionInterface
     */
    protected $connection;

    /**
     * Create a new instance and add a connection to watch.
     *
     * @param  \Ratchet\ConnectionInterface  $connection

There is no parameter named $connection. Was it maybe removed?

     * @return self
     */
    public static function decorate(ConnectionInterface $app): self
    {
        $logger = app(self::class);

        return $logger->setConnection($app);
    }

    /**
     * Set a new connection to watch.
     *
     * @param  \Ratchet\ConnectionInterface  $connection
     * @return $this
     */
    public function setConnection(ConnectionInterface $connection)
    {
        $this->connection = $connection;

        return $this;
    }

    /**
     * Send data through the connection.
     *
     * @param  string  $data
     * @return void
     */
    public function send($data)
    {
        $socketId = $this->connection->socketId ?? null;

Accessing socketId on the interface Ratchet\ConnectionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->info("Connection id {$socketId} sending message {$data}");

        $this->connection->send($data);
    }

    /**
     * Close the connection.
     *
     * @return void
     */
    public function close()
    {
        $this->warn("Connection id {$this->connection->socketId} closing.");

Accessing socketId on the interface Ratchet\ConnectionInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $this->connection->close();
    }

    /**
     * {@inheritdoc}
     */
    public function __set($name, $value)
    {
        return $this->connection->$name = $value;
    }

    /**
     * {@inheritdoc}
     */
    public function __get($name)
    {
        return $this->connection->$name;
    }

    /**
     * {@inheritdoc}
     */
    public function __isset($name)
    {
        return isset($this->connection->$name);
    }

    /**
     * {@inheritdoc}
     */
    public function __unset($name)
    {
        unset($this->connection->$name);
    }
}