HttpStatisticsLogger::getUrl() - Code Metrics - Inspection of "Add support for overriding stats logger's base URL" - beyondcode/laravel-websockets - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#115)

unknown

created 2019-02-21 17:13 UTC

HttpStatisticsLogger::getUrl() A

↳ Parent: HttpStatisticsLogger

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php

namespace BeyondCode\LaravelWebSockets\Statistics\Logger;

use Clue\React\Buzz\Browser;
use Ratchet\ConnectionInterface;
use function GuzzleHttp\Psr7\stream_for;
use BeyondCode\LaravelWebSockets\Apps\App;
use BeyondCode\LaravelWebSockets\Statistics\Statistic;
use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManager;
use BeyondCode\LaravelWebSockets\Statistics\Http\Controllers\WebSocketStatisticsEntriesController;

class HttpStatisticsLogger implements StatisticsLogger
{
    /** @var \BeyondCode\LaravelWebSockets\Statistics\Statistic[] */
    protected $statistics = [];

    /** @var \BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManager */
    protected $channelManager;

    /** @var \Clue\React\Buzz\Browser */
    protected $browser;

    public function __construct(ChannelManager $channelManager, Browser $browser)
    {
        $this->channelManager = $channelManager;

        $this->browser = $browser;
    }

    public function webSocketMessage(ConnectionInterface $connection)
    {
        $this
            ->findOrMakeStatisticForAppId($connection->app->id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->webSocketMessage();
    }

    public function apiMessage($appId)
    {
        $this
            ->findOrMakeStatisticForAppId($appId)
            ->apiMessage();
    }

    public function connection(ConnectionInterface $connection)
    {
        $this
            ->findOrMakeStatisticForAppId($connection->app->id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->connection();
    }

    public function disconnection(ConnectionInterface $connection)
    {
        $this
            ->findOrMakeStatisticForAppId($connection->app->id)
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            ->disconnection();
    }

    protected function findOrMakeStatisticForAppId($appId): Statistic
    {
        if (! isset($this->statistics[$appId])) {
            $this->statistics[$appId] = new Statistic($appId);
        }

        return $this->statistics[$appId];
    }

    protected function getUrl(): string
    {
        $action = [WebSocketStatisticsEntriesController::class, 'store'];

        $url_override = config('websockets.statistics.base_url_override', null);

        if ($url_override !== null) {
            return $url_override . action($action, [], false);
        }

        return action($action);
    }

    public function save()
    {
        foreach ($this->statistics as $appId => $statistic) {
            if (! $statistic->isEnabled()) {
                continue;
            }

            $postData = array_merge($statistic->toArray(), [
                'secret' => App::findById($appId)->secret,
            ]);

            $this
                ->browser
                ->post(
                    $this->getUrl(),
                    ['Content-Type' => 'application/json'],
                    stream_for(json_encode($postData))
                );

            $currentConnectionCount = $this->channelManager->getConnectionCount($appId);
            $statistic->reset($currentConnectionCount);
        }
    }
}


1			<?php
2
3			namespace BeyondCode\LaravelWebSockets\Statistics\Logger;
4
5			use Clue\React\Buzz\Browser;
6			use Ratchet\ConnectionInterface;
7			use function GuzzleHttp\Psr7\stream_for;
8			use BeyondCode\LaravelWebSockets\Apps\App;
9			use BeyondCode\LaravelWebSockets\Statistics\Statistic;
10			use BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManager;
11			use BeyondCode\LaravelWebSockets\Statistics\Http\Controllers\WebSocketStatisticsEntriesController;
12
13			class HttpStatisticsLogger implements StatisticsLogger
14			{
15			/** @var \BeyondCode\LaravelWebSockets\Statistics\Statistic[] */
16			protected $statistics = [];
17
18			/** @var \BeyondCode\LaravelWebSockets\WebSockets\Channels\ChannelManager */
19			protected $channelManager;
20
21			/** @var \Clue\React\Buzz\Browser */
22			protected $browser;
23
24			public function __construct(ChannelManager $channelManager, Browser $browser)
25			{
26			$this->channelManager = $channelManager;
27
28			$this->browser = $browser;
29			}
30
31			public function webSocketMessage(ConnectionInterface $connection)
32			{
33			$this
34			->findOrMakeStatisticForAppId($connection->app->id)
			0 ignored issues – show Bug introduced 2018-12-04 21:28 UTC by Report Bug Copy Issue Report Accessing `app` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35			->webSocketMessage();
36			}
37
38			public function apiMessage($appId)
39			{
40			$this
41			->findOrMakeStatisticForAppId($appId)
42			->apiMessage();
43			}
44
45			public function connection(ConnectionInterface $connection)
46			{
47			$this
48			->findOrMakeStatisticForAppId($connection->app->id)
			0 ignored issues – show Bug introduced 2018-12-04 21:28 UTC by Report Bug Copy Issue Report Accessing `app` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49			->connection();
50			}
51
52			public function disconnection(ConnectionInterface $connection)
53			{
54			$this
55			->findOrMakeStatisticForAppId($connection->app->id)
			0 ignored issues – show Bug introduced 2018-12-04 21:28 UTC by Report Bug Copy Issue Report Accessing `app` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
56			->disconnection();
57			}
58
59			protected function findOrMakeStatisticForAppId($appId): Statistic
60			{
61			if (! isset($this->statistics[$appId])) {
62			$this->statistics[$appId] = new Statistic($appId);
63			}
64
65			return $this->statistics[$appId];
66			}
67
68			protected function getUrl(): string
69			{
70			$action = [WebSocketStatisticsEntriesController::class, 'store'];
71
72			$url_override = config('websockets.statistics.base_url_override', null);
73
74			if ($url_override !== null) {
75			return $url_override . action($action, [], false);
76			}
77
78			return action($action);
79			}
80
81			public function save()
82			{
83			foreach ($this->statistics as $appId => $statistic) {
84			if (! $statistic->isEnabled()) {
85			continue;
86			}
87
88			$postData = array_merge($statistic->toArray(), [
89			'secret' => App::findById($appId)->secret,
90			]);
91
92			$this
93			->browser
94			->post(
95			$this->getUrl(),
96			['Content-Type' => 'application/json'],
97			stream_for(json_encode($postData))
98			);
99
100			$currentConnectionCount = $this->channelManager->getConnectionCount($appId);
101			$statistic->reset($currentConnectionCount);
102			}
103			}
104			}
105

beyondcode / laravel-websockets

Pull Request — master (#115)

HttpStatisticsLogger::getUrl() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like