Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class ExampleEnvironmentVariablesAreSet implements Check |
|
|
|||
9 | { |
||
10 | /** @var Collection */ |
||
11 | private $envVariables; |
||
12 | |||
13 | /** |
||
14 | * The name of the check. |
||
15 | * |
||
16 | * @param array $config |
||
17 | * @return string |
||
18 | */ |
||
19 | public function name(array $config): string |
||
23 | |||
24 | /** |
||
25 | * Perform the actual verification of this check. |
||
26 | * |
||
27 | * @param array $config |
||
28 | * @return bool |
||
29 | */ |
||
30 | 4 | public function check(array $config): bool |
|
52 | |||
53 | /** |
||
54 | * Perform the verification of this check for DotEnv v4. |
||
55 | * |
||
56 | * @return bool |
||
57 | */ |
||
58 | private function checkForDotEnvV4(): bool |
||
69 | |||
70 | /** |
||
71 | * The error message to display in case the check does not pass. |
||
72 | * |
||
73 | * @param array $config |
||
74 | * @return string |
||
75 | */ |
||
76 | 4 | public function message(array $config): string |
|
82 | } |
||
83 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.