ExampleEnvironmentVariablesAreSet - Code Metrics - Inspection of "Update composer.json" - beyondcode/laravel-self-diagnosis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4ee28c...27c466 )

by Marcel

created 2019-08-26 20:44 UTC

ExampleEnvironmentVariablesAreSet A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

75%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	54
loc	54
ccs	12
cts	16
cp	0.75
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	name()	4	4	1
A	message()	6	6	1
A	check()	18	18	2

How to fix Duplicated Code

<?php

namespace BeyondCode\SelfDiagnosis\Checks;

use Dotenv\Dotenv;
use Illuminate\Support\Collection;

class ExampleEnvironmentVariablesAreSet implements Check

{
    /** @var Collection */
    private $envVariables;

    /**
     * The name of the check.
     *
     * @param array $config
     * @return string
     */
    public function name(array $config): string
    {
        return trans('self-diagnosis::checks.example_environment_variables_are_set.name');
    }

    /**
     * Perform the actual verification of this check.
     *
     * @param array $config
     * @return bool
     */
    public function check(array $config): bool
    {
        if (interface_exists(\Dotenv\Environment\FactoryInterface::class)) {
            $examples = Dotenv::create(base_path(), '.env.example');
            $actual = Dotenv::create(base_path(), '.env');
        } else {
            $examples = new Dotenv(base_path(), '.env.example');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $actual = new Dotenv(base_path(), '.env');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $examples->safeLoad();
        $actual->safeLoad();

        $this->envVariables = Collection::make($examples->getEnvironmentVariableNames())
            ->diff($actual->getEnvironmentVariableNames());

        return $this->envVariables->isEmpty();
    }

    /**
     * The error message to display in case the check does not pass.
     *
     * @param array $config
     * @return string
     */
    public function message(array $config): string
    {
        return trans('self-diagnosis::checks.example_environment_variables_are_set.message', [
            'variables' => $this->envVariables->implode(PHP_EOL),
        ]);
    }
}


1			<?php
2
3			namespace BeyondCode\SelfDiagnosis\Checks;
4
5			use Dotenv\Dotenv;
6			use Illuminate\Support\Collection;
7
8		View Code Duplication	class ExampleEnvironmentVariablesAreSet implements Check
			0 ignored issues – show Duplication introduced 2018-07-24 13:25 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9			{
10			/** @var Collection */
11			private $envVariables;
12
13			/**
14			* The name of the check.
15			*
16			* @param array $config
17			* @return string
18			*/
19			public function name(array $config): string
20			{
21			return trans('self-diagnosis::checks.example_environment_variables_are_set.name');
22			}
23
24			/**
25			* Perform the actual verification of this check.
26			*
27			* @param array $config
28			* @return bool
29			*/
30	4		public function check(array $config): bool
31			{
32	4		if (interface_exists(\Dotenv\Environment\FactoryInterface::class)) {
33	4		$examples = Dotenv::create(base_path(), '.env.example');
34	4		$actual = Dotenv::create(base_path(), '.env');
35			} else {
36			$examples = new Dotenv(base_path(), '.env.example');
			0 ignored issues – show Documentation introduced 2019-02-27 01:13 UTC by Report Bug Copy Issue Report `base_path()` is of type `string`, but the function expects a `object<Dotenv\Loader>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2019-02-27 01:13 UTC by Report Bug Copy Issue Report The call to `Dotenv::__construct()` has too many arguments starting with `'.env.example'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
37			$actual = new Dotenv(base_path(), '.env');
			0 ignored issues – show Documentation introduced 2019-02-27 01:13 UTC by Report Bug Copy Issue Report `base_path()` is of type `string`, but the function expects a `object<Dotenv\Loader>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2019-02-27 01:13 UTC by Report Bug Copy Issue Report The call to `Dotenv::__construct()` has too many arguments starting with `'.env'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
38			}
39
40	4		$examples->safeLoad();
41	4		$actual->safeLoad();
42
43	4		$this->envVariables = Collection::make($examples->getEnvironmentVariableNames())
44	4		->diff($actual->getEnvironmentVariableNames());
45
46	4		return $this->envVariables->isEmpty();
47			}
48
49			/**
50			* The error message to display in case the check does not pass.
51			*
52			* @param array $config
53			* @return string
54			*/
55	4		public function message(array $config): string
56			{
57	4		return trans('self-diagnosis::checks.example_environment_variables_are_set.message', [
58	4		'variables' => $this->envVariables->implode(PHP_EOL),
59			]);
60			}
61			}
62

beyondcode / laravel-self-diagnosis

Push — master ( 4ee28c...27c466 )

ExampleEnvironmentVariablesAreSet A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like