ExampleEnvironmentVariablesAreUpToDate   A
last analyzed

Complexity

Total Complexity 6

Size/Duplication

Total Lines 75
Duplicated Lines 24 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 60%

Importance

Changes 0
Metric Value
wmc 6
lcom 1
cbo 2
dl 18
loc 75
ccs 15
cts 25
cp 0.6
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A checkForDotEnvV4() 11 11 1
A name() 0 4 1
A check() 7 22 3
A message() 0 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace BeyondCode\SelfDiagnosis\Checks;
4
5
use Dotenv\Dotenv;
6
use Illuminate\Support\Collection;
7
8
class ExampleEnvironmentVariablesAreUpToDate implements Check
9
{
10
    /** @var Collection */
11
    private $envVariables;
12
13
    /**
14
     * The name of the check.
15
     *
16
     * @param array $config
17
     * @return string
18
     */
19
    public function name(array $config): string
20
    {
21
        return trans('self-diagnosis::checks.example_environment_variables_are_up_to_date.name');
22
    }
23
24
    /**
25
     * Perform the actual verification of this check.
26
     *
27
     * @param array $config
28
     * @return bool
29
     */
30 4
    public function check(array $config): bool
31
    {
32 4
        if (method_exists(Dotenv::class, 'createImmutable')) {
33
            return $this->checkForDotEnvV4();
34
        }
35
36 4 View Code Duplication
        if (interface_exists(\Dotenv\Environment\FactoryInterface::class)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
37 2
            $examples = Dotenv::create(base_path(), '.env.example');
38 2
            $actual = Dotenv::create(base_path(), '.env');
39
        } else {
40 2
            $examples = new Dotenv(base_path(), '.env.example');
0 ignored issues
show
Documentation introduced by
base_path() is of type string, but the function expects a object<Dotenv\Loader>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
Unused Code introduced by
The call to Dotenv::__construct() has too many arguments starting with '.env.example'.

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
41 2
            $actual = new Dotenv(base_path(), '.env');
0 ignored issues
show
Documentation introduced by
base_path() is of type string, but the function expects a object<Dotenv\Loader>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
Unused Code introduced by
The call to Dotenv::__construct() has too many arguments starting with '.env'.

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
42
        }
43
44 4
        $examples->safeLoad();
45 4
        $actual->safeLoad();
46
47 4
        $this->envVariables = Collection::make($actual->getEnvironmentVariableNames())
48 4
            ->diff($examples->getEnvironmentVariableNames());
49
50 4
        return $this->envVariables->isEmpty();
51
    }
52
53
    /**
54
     * Perform the verification of this check for DotEnv v4.
55
     *
56
     * @return bool
57
     */
58 View Code Duplication
    private function checkForDotEnvV4(): bool
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
59
    {
60
        $examples = Dotenv::createImmutable(base_path(), '.env.example');
0 ignored issues
show
Bug introduced by
The method createImmutable() does not exist on Dotenv\Dotenv. Did you maybe mean create()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
61
        $actual = Dotenv::createImmutable(base_path(), '.env');
0 ignored issues
show
Bug introduced by
The method createImmutable() does not exist on Dotenv\Dotenv. Did you maybe mean create()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
62
63
        $this->envVariables = Collection::make($actual->safeLoad())
64
            ->diffKeys($examples->safeLoad())
65
            ->keys();
66
67
        return $this->envVariables->isEmpty();
68
    }
69
70
    /**
71
     * The error message to display in case the check does not pass.
72
     *
73
     * @param array $config
74
     * @return string
75
     */
76 4
    public function message(array $config): string
77
    {
78 4
        return trans('self-diagnosis::checks.example_environment_variables_are_up_to_date.message', [
79 4
            'variables' => $this->envVariables->implode(PHP_EOL),
80
        ]);
81
    }
82
}
83