BeyondCode\EmailConfirmation\Notifications\ConfirmEmail

Complexity

Total Complexity

3

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	via()	0	4	1
A	toMail()	0	8	1
A	confirmationUrl()	0	8	1

<?php

namespace BeyondCode\EmailConfirmation\Notifications;

use Carbon\Carbon;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Support\Facades\URL;

class ConfirmEmail extends Notification implements ShouldQueue
{
    use Queueable;

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)
    {
        return (new MailMessage)
            ->subject(__('confirmation::confirmation.confirmation_subject'))

It seems like __('confirmation::confirmation.confirmation_subject') targeting __() can also be of type array or null; however, Illuminate\Notifications\Messages\SimpleMessage::subject() does only seem to accept string, maybe add an additional type check?

            ->line(__('confirmation::confirmation.confirmation_subject_title'))
            ->line(__('confirmation::confirmation.confirmation_body'))
            ->action(__('confirmation::confirmation.confirmation_button'), $this->confirmationUrl($notifiable));

It seems like __('confirmation::confirmation.confirmation_button') targeting __() can also be of type array or null; however, Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

    }

    protected function confirmationUrl($notifiable)
    {
        return URL::temporarySignedRoute(
            "auth.confirm",
            now()->addMinutes(config('confirmation.timeout',60)),
            ['id' => $notifiable->getKey()]
        );
    }
}