BeyondCode\EmailConfirmation\Traits\RegistersUsers

Complexity

Total Complexity

16

Size/Duplication

Total Lines	131
Duplicated Lines	18.32 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	redirectAfterConfirmationPath()	8	8	3
A	redirectAfterRegistrationPath()	8	8	3
A	redirectAfterResendConfirmationPath()	8	8	3
A	confirm()	0	15	2
A	resendConfirmation()	0	9	1
A	sendConfirmationToUser()	0	10	1
A	confirmed()	0	3	1

<?php

namespace BeyondCode\EmailConfirmation\Traits;

use BeyondCode\EmailConfirmation\Events\Confirmed;
use Illuminate\Http\Request;
use Illuminate\Support\Str;
use Illuminate\Auth\Events\Registered;

trait RegistersUsers
{
    use \Illuminate\Foundation\Auth\RegistersUsers {
        register as baseRegister;
    }

    /**
     * Get redirect path after a successful confirmation.
     *
     * @return string
     */
    public function redirectAfterConfirmationPath()

This method seems to be duplicated in your project.

    {
        if (method_exists($this, 'redirectConfirmationTo')) {
            return $this->redirectConfirmationTo();

The method redirectConfirmationTo() does not exist on BeyondCode\EmailConfirmation\Traits\RegistersUsers. Did you maybe mean confirm()?

        }

        return property_exists($this, 'redirectConfirmationTo') ? $this->redirectConfirmationTo : route('login');

The property redirectConfirmationTo does not exist. Did you maybe forget to declare it?

    }

    /**
     * Get redirect path after a registration that still needs to be confirmed.
     *
     * @return string
     */
    public function redirectAfterRegistrationPath()

This method seems to be duplicated in your project.

    {
        if (method_exists($this, 'redirectAfterRegistrationTo')) {
            return $this->redirectAfterRegistrationTo();

It seems like redirectAfterRegistrationTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return property_exists($this, 'redirectAfterRegistrationTo') ? $this->redirectAfterRegistrationTo : route('login');

The property redirectAfterRegistrationTo does not exist. Did you maybe forget to declare it?

    }

    /**
     * Get redirect path after the confirmation was sent.
     *
     * @return string
     */
    public function redirectAfterResendConfirmationPath()

This method seems to be duplicated in your project.

    {
        if (method_exists($this, 'redirectAfterResendConfirmationTo')) {
            return $this->redirectAfterResendConfirmationTo();

The method redirectAfterResendConfirmationTo() does not exist on BeyondCode\EmailConfirmation\Traits\RegistersUsers. Did you maybe mean confirm()?

        }

        return property_exists($this, 'redirectAfterResendConfirmationTo') ? $this->redirectAfterResendConfirmationTo : route('login');

The property redirectAfterResendConfirmationTo does not exist. Did you maybe forget to declare it?

    }

    /**
     * Confirm a user with a given confirmation code.
     *
     * @param $confirmation_code
     * @return \Illuminate\Http\RedirectResponse
     */
    public function confirm($confirmation_code)
    {
        $model = $this->guard()->getProvider()->createModel();

        $user = $model->where('confirmation_code', $confirmation_code)->firstOrFail();

        $user->confirmation_code = null;
        $user->confirmed_at = now();
        $user->save();

        event(new Confirmed($user));

        return $this->confirmed($user)
            ?: redirect($this->redirectAfterConfirmationPath())->with('confirmation', __('confirmation::confirmation.confirmation_successful'));
    }

    /**
     * Resend a confirmation code to a user.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse
     */
    public function resendConfirmation(Request $request)
    {
        $model = $this->guard()->getProvider()->createModel();

        $user = $model->findOrFail($request->session()->pull('confirmation_user_id'));

The method pull cannot be called on $request->session() (of type callable).

        $this->sendConfirmationToUser($user);

        return redirect($this->redirectAfterResendConfirmationPath())->with('confirmation', __('confirmation::confirmation.confirmation_resent'));
    }

    /**
     * Handle a registration request for the application.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function register(Request $request)
    {
        $this->validator($request->all())->validate();

It seems like validator() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        event(new Registered($user = $this->create($request->all())));

It seems like create() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->sendConfirmationToUser($user);

        return $this->registered($request, $user)
            ?: redirect($this->redirectAfterRegistrationPath())->with('confirmation', __('confirmation::confirmation.confirmation_info'));
    }

    /**
     * Send the confirmation code to a user.
     *
     * @param $user
     */
    protected function sendConfirmationToUser($user)
    {
        // Create the confirmation code
        $user->confirmation_code = Str::random(25);
        $user->save();

        // Notify the user
        $notification = app(config('confirmation.notification'));
        $user->notify($notification);
    }


    /**
     * The users email address has been confirmed.
     *
     * @param  mixed  $user
     * @return mixed
     */
    protected function confirmed($user) {

The parameter $user is not used and could be removed.

        //
    }
}