Issues in ConfigurationLoader.php (main) - Issues in main - bestit/license-check - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Configuration/ConfigurationLoader.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace BestIt\LicenseCheck\Configuration;

use BestIt\LicenseCheck\Configuration\Exception\ConfigurationNotFoundException;
use BestIt\LicenseCheck\Configuration\Exception\ConfigurationParseException;
use Symfony\Component\Yaml\Yaml;
use Throwable;

/**
 * Loader to create a configuration object by a configuration yaml file.
 *
 * @author best it AG <[email protected]>
 * @package BestIt\LicenseCheck\Configuration
 */
class ConfigurationLoader
{
    /**
     * Constant for the array key of allowed licenses.
     *
     * @var string KEY_ALLOWED_LICENSES
     */
    private const KEY_ALLOWED_LICENSES = 'allowed-licenses';

    /**
     * Constant for the array key of allowed packages.
     *
     * @var string KEY_ALLOWED_PACKAGES
     */
    private const KEY_ALLOWED_PACKAGES = 'allowed-packages';


    /**
     * Extract allowed licenses from whole configuration array and validates the type.
     *
     * @param string[] $items
     *
     * @return array<string>
     */
    private function getAllowedLicenses(array $items): array
    {
        $result = [];

        foreach ($items as $item) {
            if (!is_string($item)) {
                throw new ConfigurationParseException('Invalid value.');
            }
            $result[] = $item;
        }

        return $result;
    }

    /**
     * Extract allowed packages from whole configuration array and validates the type.
     *
     * @param string[][] $list
     *
     * @return array<string, array<string>>
     */
    private function getAllowedPackages(array $list): array
    {
        $result = [];

        foreach ($list as $type => $items) {
            if (!is_array($items)) {
                $items = [];
            }
            foreach ($items as $item) {
                if (!is_string($item)) {
                    throw new ConfigurationParseException('Invalid value.');
                }
                $result[$type][] = $item;
            }
        }

        return $result;
    }

    /**
     * Create a configuration object from a file.
     *
     * @param string[] $configFiles Array of configuration files with path.
     *
     * @throws ConfigurationNotFoundException Exception if configuration file was not found.
     * @throws ConfigurationParseException Exception if configuration cannot be parsed.
     *
     * @return Configuration
     */
    public function load(array $configFiles): Configuration
    {
        $configArrays = [];
        foreach ($configFiles as $configFile) {
            $configArrays[] = $this->parseConfigFile($configFile);
        }

        $mergedConfig = [
            'allowed_licenses' => [],
            'allowed_packages' => [],
        ];

        foreach ($configArrays as $configArray) {
            $mergedConfig = array_merge_recursive($mergedConfig, $configArray);
        }

        return new Configuration(
            $mergedConfig['allowed_licenses'],
            $mergedConfig['allowed_packages'],
        );

    }

    /**
     * Reads a single config file and returns the config as array.
     *
     * @param string $fileName Path to config file.
     *
     * @throws ConfigurationNotFoundException Exception if configuration file was not found.
     * @throws ConfigurationParseException Exception if configuration cannot be parsed.
     *
     * @return array<string, array<array<string>|string>>
     */
    private function parseConfigFile(string $fileName): array
    {
        if (!file_exists($fileName)) {
            throw new ConfigurationNotFoundException(sprintf('Configuration file %s not found.', $fileName));
        }

        try {
            $yaml = Yaml::parseFile($fileName);

            $allowedLicences = $this->getAllowedLicenses($yaml[self::KEY_ALLOWED_LICENSES] ?? []);
            $allowedPackages = $this->getAllowedPackages($yaml[self::KEY_ALLOWED_PACKAGES] ?? []);
        } catch (Throwable $e) {
            throw new ConfigurationParseException('Configuration file cannot be parsed.', 0, $e);
        }

        return ['allowed_licenses' => $allowedLicences, 'allowed_packages' => $allowedPackages];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BestIt\LicenseCheck\Configuration;
6
7			use BestIt\LicenseCheck\Configuration\Exception\ConfigurationNotFoundException;
8			use BestIt\LicenseCheck\Configuration\Exception\ConfigurationParseException;
9			use Symfony\Component\Yaml\Yaml;
10			use Throwable;
11
12			/**
13			* Loader to create a configuration object by a configuration yaml file.
14			*
15			* @author best it AG <[email protected]>
16			* @package BestIt\LicenseCheck\Configuration
17			*/
18			class ConfigurationLoader
19			{
20			/**
21			* Constant for the array key of allowed licenses.
22			*
23			* @var string KEY_ALLOWED_LICENSES
24			*/
25			private const KEY_ALLOWED_LICENSES = 'allowed-licenses';
26
27			/**
28			* Constant for the array key of allowed packages.
29			*
30			* @var string KEY_ALLOWED_PACKAGES
31			*/
32			private const KEY_ALLOWED_PACKAGES = 'allowed-packages';
33
34
35			/**
36			* Extract allowed licenses from whole configuration array and validates the type.
37			*
38			* @param string[] $items
39			*
40			* @return array<string>
41			*/
42			private function getAllowedLicenses(array $items): array
43			{
44			$result = [];
45
46			foreach ($items as $item) {
47			if (!is_string($item)) {
48			throw new ConfigurationParseException('Invalid value.');
49			}
50			$result[] = $item;
51			}
52
53			return $result;
54			}
55
56			/**
57			* Extract allowed packages from whole configuration array and validates the type.
58			*
59			* @param string[][] $list
60			*
61			* @return array<string, array<string>>
62			*/
63			private function getAllowedPackages(array $list): array
64			{
65			$result = [];
66
67			foreach ($list as $type => $items) {
68			if (!is_array($items)) {
69			$items = [];
70			}
71			foreach ($items as $item) {
72			if (!is_string($item)) {
73			throw new ConfigurationParseException('Invalid value.');
74			}
75			$result[$type][] = $item;
76			}
77			}
78
79			return $result;
80			}
81
82			/**
83			* Create a configuration object from a file.
84			*
85			* @param string[] $configFiles Array of configuration files with path.
86			*
87			* @throws ConfigurationNotFoundException Exception if configuration file was not found.
88			* @throws ConfigurationParseException Exception if configuration cannot be parsed.
89			*
90			* @return Configuration
91			*/
92			public function load(array $configFiles): Configuration
93			{
94			$configArrays = [];
95			foreach ($configFiles as $configFile) {
96			$configArrays[] = $this->parseConfigFile($configFile);
97			}
98
99			$mergedConfig = [
100			'allowed_licenses' => [],
101			'allowed_packages' => [],
102			];
103
104			foreach ($configArrays as $configArray) {
105			$mergedConfig = array_merge_recursive($mergedConfig, $configArray);
106			}
107
108			return new Configuration(
109			$mergedConfig['allowed_licenses'],
110			$mergedConfig['allowed_packages'],
111			);
			0 ignored issues – show Bug introduced 2021-03-04 19:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected ')' Loading history...
112			}
113
114			/**
115			* Reads a single config file and returns the config as array.
116			*
117			* @param string $fileName Path to config file.
118			*
119			* @throws ConfigurationNotFoundException Exception if configuration file was not found.
120			* @throws ConfigurationParseException Exception if configuration cannot be parsed.
121			*
122			* @return array<string, array<array<string>\|string>>
123			*/
124			private function parseConfigFile(string $fileName): array
125			{
126			if (!file_exists($fileName)) {
127			throw new ConfigurationNotFoundException(sprintf('Configuration file %s not found.', $fileName));
128			}
129
130			try {
131			$yaml = Yaml::parseFile($fileName);
132
133			$allowedLicences = $this->getAllowedLicenses($yaml[self::KEY_ALLOWED_LICENSES] ?? []);
134			$allowedPackages = $this->getAllowedPackages($yaml[self::KEY_ALLOWED_PACKAGES] ?? []);
135			} catch (Throwable $e) {
136			throw new ConfigurationParseException('Configuration file cannot be parsed.', 0, $e);
137			}
138
139			return ['allowed_licenses' => $allowedLicences, 'allowed_packages' => $allowedPackages];
140			}
141			}
142

bestit / license-check

Issues (7)

Security Analysis no request data

src/Configuration/ConfigurationLoader.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like