Issues in CamelCaseVariableSniff.php (master) - Issues in master - bestit/PHP_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (51)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

NamingConventions/CamelCaseVariableSniff.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace BestIt\Sniffs\NamingConventions;

use BestIt\CodeSniffer\Helper\TokenHelper;
use BestIt\Sniffs\AbstractSniff;
use BestIt\Sniffs\VariableRegistrationTrait;
use PHP_CodeSniffer\Util\Common;
use SlevomatCodingStandard\Helpers\PropertyHelper;
use function array_key_exists;
use function substr;
use const T_EQUAL;
use const T_SEMICOLON;

/**
 * Registers an error if the variables are not in camelCase (lc first).
 *
 * @author blange <[email protected]>
 * @package BestIt\Sniffs\NamingConventions
 */
class CamelCaseVariableSniff extends AbstractSniff
{
    use VariableRegistrationTrait;

    /**
     * You MUST provide your vars in camel case, lower case first.
     *
     * @var string
     */
    public const CODE_NOT_CAMEL_CASE = 'NotCamelCase';

    /**
     * The error message for this sniff.
     *
     * @var string
     */
    private const MESSAGE_NOT_CAMEL_CASE = 'Variable %s should be in camelCase (lowercase first).';

    /**
     * The previously sniffed file.
     *
     * @var string
     */
    private string $prevSniffedFile = '';


    /**
     * The vars which were sniffed in this file.
     *
     * @var array
     */
    private array $sniffedVars = [];

    /**
     * Returns true if there is a value assignment or a property declaration, but which can be without an assignment.
     *
     * @return bool
     */
    protected function areRequirementsMet(): bool
    {
        $var = $this->token['content'];

        // We need to check everything != $this.
        if ($return = $var !== '$this') {
            $nextPos = (int) TokenHelper::findNextEffective($this->file, $this->stackPos + 1);

            if ($nextPos > 0) {
                $isProperty = PropertyHelper::isProperty($this->file, $this->stackPos);
                $nextTokenCode = $this->tokens[$nextPos]['code'];

                // The var should be followed by an "=" or can be followed by a semicolon if its a property.
                $return = ($nextTokenCode === T_EQUAL) || ($nextTokenCode === T_SEMICOLON && $isProperty);
            }
        }

        return $return;
    }

    /**
     * Processes the token.
     *
     * @see self::setUp()
     *
     * @return void
     */
    protected function processToken(): void
    {
        // "Sniff" the var name only once, but register the possible error everytime the var is declared.
        if (!$this->sniffedVars[$var = $this->token['content']]) {
            $this->file->recordMetric($this->stackPos, 'CamelCase var name', 'no');

            if (!$this->isSniffSuppressed(static::CODE_NOT_CAMEL_CASE)) {
                $this->file->addError(
                    self::MESSAGE_NOT_CAMEL_CASE,
                    $this->stackPos,
                    static::CODE_NOT_CAMEL_CASE,
                    [
                        $var
                    ]
                );
            }
        } else {
            $this->file->recordMetric($this->stackPos, 'CamelCase var name', 'yes');
        }
    }

    /**
     * Sets up the sniff.
     *
     * @return void
     */
    protected function setUp(): void
    {
        parent::setUp();

        $this->prevSniffedFile = $this->file->getFilename();

        if (!array_key_exists($var = $this->token['content'], $this->sniffedVars)) {
            // "Sniff" the var name only once ...
            $this->sniffedVars[$var] = Common::isCamelCaps(substr($var, 1));
        }
    }

    /**
     * Cleans the cache of this sniff.
     *
     * @return void
     */
    protected function tearDown(): void
    {
        parent::tearDown();

        if ($this->prevSniffedFile && $this->prevSniffedFile !== $this->file->getFilename()) {
            $this->sniffedVars = [];
            $this->prevSniffedFile = '';
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BestIt\Sniffs\NamingConventions;
6
7			use BestIt\CodeSniffer\Helper\TokenHelper;
8			use BestIt\Sniffs\AbstractSniff;
9			use BestIt\Sniffs\VariableRegistrationTrait;
10			use PHP_CodeSniffer\Util\Common;
11			use SlevomatCodingStandard\Helpers\PropertyHelper;
12			use function array_key_exists;
13			use function substr;
14			use const T_EQUAL;
15			use const T_SEMICOLON;
16
17			/**
18			* Registers an error if the variables are not in camelCase (lc first).
19			*
20			* @author blange <[email protected]>
21			* @package BestIt\Sniffs\NamingConventions
22			*/
23			class CamelCaseVariableSniff extends AbstractSniff
24			{
25			use VariableRegistrationTrait;
26
27			/**
28			* You MUST provide your vars in camel case, lower case first.
29			*
30			* @var string
31			*/
32			public const CODE_NOT_CAMEL_CASE = 'NotCamelCase';
33
34			/**
35			* The error message for this sniff.
36			*
37			* @var string
38			*/
39			private const MESSAGE_NOT_CAMEL_CASE = 'Variable %s should be in camelCase (lowercase first).';
40
41			/**
42			* The previously sniffed file.
43			*
44			* @var string
45			*/
46			private string $prevSniffedFile = '';
			0 ignored issues – show Bug introduced 2020-06-12 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
47
48			/**
49			* The vars which were sniffed in this file.
50			*
51			* @var array
52			*/
53			private array $sniffedVars = [];
54
55			/**
56			* Returns true if there is a value assignment or a property declaration, but which can be without an assignment.
57			*
58			* @return bool
59			*/
60			protected function areRequirementsMet(): bool
61			{
62			$var = $this->token['content'];
63
64			// We need to check everything != $this.
65			if ($return = $var !== '$this') {
66			$nextPos = (int) TokenHelper::findNextEffective($this->file, $this->stackPos + 1);
67
68			if ($nextPos > 0) {
69			$isProperty = PropertyHelper::isProperty($this->file, $this->stackPos);
70			$nextTokenCode = $this->tokens[$nextPos]['code'];
71
72			// The var should be followed by an "=" or can be followed by a semicolon if its a property.
73			$return = ($nextTokenCode === T_EQUAL) \|\| ($nextTokenCode === T_SEMICOLON && $isProperty);
74			}
75			}
76
77			return $return;
78			}
79
80			/**
81			* Processes the token.
82			*
83			* @see self::setUp()
84			*
85			* @return void
86			*/
87			protected function processToken(): void
88			{
89			// "Sniff" the var name only once, but register the possible error everytime the var is declared.
90			if (!$this->sniffedVars[$var = $this->token['content']]) {
91			$this->file->recordMetric($this->stackPos, 'CamelCase var name', 'no');
92
93			if (!$this->isSniffSuppressed(static::CODE_NOT_CAMEL_CASE)) {
94			$this->file->addError(
95			self::MESSAGE_NOT_CAMEL_CASE,
96			$this->stackPos,
97			static::CODE_NOT_CAMEL_CASE,
98			[
99			$var
100			]
101			);
102			}
103			} else {
104			$this->file->recordMetric($this->stackPos, 'CamelCase var name', 'yes');
105			}
106			}
107
108			/**
109			* Sets up the sniff.
110			*
111			* @return void
112			*/
113			protected function setUp(): void
114			{
115			parent::setUp();
116
117			$this->prevSniffedFile = $this->file->getFilename();
118
119			if (!array_key_exists($var = $this->token['content'], $this->sniffedVars)) {
120			// "Sniff" the var name only once ...
121			$this->sniffedVars[$var] = Common::isCamelCaps(substr($var, 1));
122			}
123			}
124
125			/**
126			* Cleans the cache of this sniff.
127			*
128			* @return void
129			*/
130			protected function tearDown(): void
131			{
132			parent::tearDown();
133
134			if ($this->prevSniffedFile && $this->prevSniffedFile !== $this->file->getFilename()) {
135			$this->sniffedVars = [];
136			$this->prevSniffedFile = '';
137			}
138			}
139			}
140

bestit / PHP_CodeSniffer

Issues (51)

Security Analysis no request data

NamingConventions/CamelCaseVariableSniff.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like