Issues in EqualOperatorSniff.php (master) - Issues in master - bestit/PHP_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (51)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

BestIt/Sniffs/Comparisons/EqualOperatorSniff.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace BestIt\Sniffs\Comparisons;

use BestIt\Sniffs\AbstractSniff;
use const T_IS_EQUAL;

/**
 * Class EqualOperatorSniff.
 *
 * @author Mika Bertels <[email protected]>
 * @package BestIt\Sniffs\Comparisons
 */
class EqualOperatorSniff extends AbstractSniff
{
    /**
     * You SHOULD use the "Identical" operator (===).
     */
    public const CODE_EQUAL_OPERATOR_FOUND = 'EqualOperatorFound';

    /**
     * Warning when an equal operator was found.
     *
     * @var string WARNING_EQUAL_OPERATOR_FOUND
     */
    private const MESSAGE_EQUAL_OPERATOR_FOUND = 'Please check if you could use the "Identical" operator (===).';

    /**
     * Is this sniff allowed to fix?
     *
     * @var bool $isFixing
     */
    public bool $isFixable = false;

    
    /**
     * Processes the token.
     *
     * @return void
     */
    protected function processToken(): void
    {
        $file = $this->getFile();
        $stackPos = $this->getStackPos();

        $isFixing = $file->addFixableWarning(
            self::MESSAGE_EQUAL_OPERATOR_FOUND,
            $stackPos,
            static::CODE_EQUAL_OPERATOR_FOUND
        );

        $file->recordMetric($stackPos, 'Found not wanted T_IS_EQUAL', 'yes');

        if ($isFixing && $this->isFixable) {
            $this->replaceToken();
        }
    }

    /**
     * Registers the tokens that this sniff wants to listen for.
     *
     * An example return value for a sniff that wants to listen for whitespace
     * and any comments would be:
     *
     * <code>
     *    return array(
     *            T_WHITESPACE,
     *            T_DOC_COMMENT,
     *            T_COMMENT,
     *           );
     * </code>
     *
     * @see    Tokens.php
     *
     * @return int[]
     */
    public function register(): array
    {
        return [T_IS_EQUAL];
    }

    /**
     * Replace token with the T_IS_IDENTIAL token.
     *
     * @return void
     */
    private function replaceToken(): void
    {
        $file = $this->getFile();

        $file->fixer->beginChangeset();
        $file->fixer->replaceToken($this->getStackPos(), '===');
        $file->fixer->endChangeset();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace BestIt\Sniffs\Comparisons;
6
7			use BestIt\Sniffs\AbstractSniff;
8			use const T_IS_EQUAL;
9
10			/**
11			* Class EqualOperatorSniff.
12			*
13			* @author Mika Bertels <[email protected]>
14			* @package BestIt\Sniffs\Comparisons
15			*/
16			class EqualOperatorSniff extends AbstractSniff
17			{
18			/**
19			* You SHOULD use the "Identical" operator (===).
20			*/
21			public const CODE_EQUAL_OPERATOR_FOUND = 'EqualOperatorFound';
22
23			/**
24			* Warning when an equal operator was found.
25			*
26			* @var string WARNING_EQUAL_OPERATOR_FOUND
27			*/
28			private const MESSAGE_EQUAL_OPERATOR_FOUND = 'Please check if you could use the "Identical" operator (===).';
29
30			/**
31			* Is this sniff allowed to fix?
32			*
33			* @var bool $isFixing
34			*/
35			public bool $isFixable = false;
			0 ignored issues – show Bug introduced 2020-06-12 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
36
37			/**
38			* Processes the token.
39			*
40			* @return void
41			*/
42			protected function processToken(): void
43			{
44			$file = $this->getFile();
45			$stackPos = $this->getStackPos();
46
47			$isFixing = $file->addFixableWarning(
48			self::MESSAGE_EQUAL_OPERATOR_FOUND,
49			$stackPos,
50			static::CODE_EQUAL_OPERATOR_FOUND
51			);
52
53			$file->recordMetric($stackPos, 'Found not wanted T_IS_EQUAL', 'yes');
54
55			if ($isFixing && $this->isFixable) {
56			$this->replaceToken();
57			}
58			}
59
60			/**
61			* Registers the tokens that this sniff wants to listen for.
62			*
63			* An example return value for a sniff that wants to listen for whitespace
64			* and any comments would be:
65			*
66			* <code>
67			* return array(
68			* T_WHITESPACE,
69			* T_DOC_COMMENT,
70			* T_COMMENT,
71			* );
72			* </code>
73			*
74			* @see Tokens.php
75			*
76			* @return int[]
77			*/
78			public function register(): array
79			{
80			return [T_IS_EQUAL];
81			}
82
83			/**
84			* Replace token with the T_IS_IDENTIAL token.
85			*
86			* @return void
87			*/
88			private function replaceToken(): void
89			{
90			$file = $this->getFile();
91
92			$file->fixer->beginChangeset();
93			$file->fixer->replaceToken($this->getStackPos(), '===');
94			$file->fixer->endChangeset();
95			}
96			}
97

bestit / PHP_CodeSniffer

Issues (51)

Security Analysis no request data

BestIt/Sniffs/Comparisons/EqualOperatorSniff.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like