bestit / PHP_CodeSniffer

src/Standards/BestIt/Sniffs/DocTags/ReturnTagSniff.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     /**
      * The message for the mixed type warning.
      */
-    private const MESSAGE_MIXED_TYPE = 'We suggest that you avoid the "mixed" type and declare the ' .
+    private const MESSAGE_MIXED_TYPE = 'We suggest that you avoid the "mixed" type and declare the '.
         'required types in detail.';
 
     /**

src/Standards/BestIt/Sniffs/SuppressingTrait.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         );
 
         if ($sniffName) {
-            $sniffClassName .= '.' . $sniffName;
+            $sniffClassName .= '.'.$sniffName;
         }
 
         return $sniffClassName;

src/Standards/BestIt/Sniffs/DocTags/AbstractRequiredTagsSniff.php

Spacing +8 added lines, -8 removed lines

@@ -86,7 +86,7 @@ 
         array_walk(
             $allTags,
             // TODO: Removed Duplicates
-            function (array $tag, int $tagPos) use (&$checkedTags, $tagRules): void {
+            function(array $tag, int $tagPos) use (&$checkedTags, $tagRules): void {
                 $tagContent = substr($tag['content'], 1);
 
                 if (!in_array($tagContent, $checkedTags)) {
@@ -101,7 +101,7 @@ 
                             $tagPos,
                             // We use an error code containing the tag name because we can't configure this rules from
                             // the outside and need  specific code to exclude the rule for this special tag.
-                            static::CODE_TAG_OCCURRENCE_MAX_PREFIX . ucfirst($tagContent),
+                            static::CODE_TAG_OCCURRENCE_MAX_PREFIX.ucfirst($tagContent),
                             [
                                 $tagContent,
                                 $maxCount,
@@ -126,7 +126,7 @@ 
 
         array_walk(
             $rulesWithReq,
-            function (array $tagRule, string $tag) use ($checkedRule): void {
+            function(array $tagRule, string $tag) use ($checkedRule): void {
                 $minCount = $tagRule[$checkedRule];
                 $tagCount = count($this->findTokensForTag($tag));
 
@@ -136,7 +136,7 @@ 
                         $this->getDocCommentPos(),
                         // We use an error code containing the tag name because we can't configure this rules from the
                         // outside and need  specific code to exclude the rule for this special tag.
-                        static::CODE_TAG_OCCURRENCE_MIN_PREFIX . ucfirst($tag),
+                        static::CODE_TAG_OCCURRENCE_MIN_PREFIX.ucfirst($tag),
                         [
                             $tag,
                             $minCount,
@@ -159,7 +159,7 @@ 
     {
         $allTags = $this->getAllTags();
 
-        return array_filter($allTags, function (array $tag) use ($tagName): bool {
+        return array_filter($allTags, function(array $tag) use ($tagName): bool {
             return substr($tag['content'], 1) === $tagName;
         });
     }
@@ -203,7 +203,7 @@ 
     {
         $processedTagRules = $this->getProcessedTagRules();
 
-        $processedTagRules = array_filter($processedTagRules, function (array $tagRule) use ($requiredRule): bool {
+        $processedTagRules = array_filter($processedTagRules, function(array $tagRule) use ($requiredRule): bool {
             return array_key_exists($requiredRule, $tagRule);
         });
         return $processedTagRules;
@@ -242,8 +242,8 @@ 
     {
         $processedTagRules = $this->getTagRules();
 
-        array_walk($processedTagRules, function (&$tagRule) {
-            $tagRule = array_map(function ($valueOrCallback) {
+        array_walk($processedTagRules, function(&$tagRule) {
+            $tagRule = array_map(function($valueOrCallback) {
                 return is_callable($valueOrCallback, true)
                     ? Closure::fromCallable($valueOrCallback)->call($this)
                     : $valueOrCallback;

Doc Comments +1 added lines, -1 removed lines

@@ -232,7 +232,7 @@
      * @param string $rule
      * @param string $tag
      *
-     * @return bool|string
+     * @return string|false
      */
     private function hasFixCallback(string $rule, string $tag)
     {

src/Standards/BestIt/Sniffs/Functions/FluentSetterSniff.php

Spacing +2 added lines, -2 removed lines

@@ -110,7 +110,7 @@ 
     private function checkForFluentSetterErrors(File $phpcsFile, int $functionPos, int $classPos): void
     {
         $tokens = $phpcsFile->getTokens();
-        $errorData = $phpcsFile->getDeclarationName($classPos) . '::' . $phpcsFile->getDeclarationName($functionPos);
+        $errorData = $phpcsFile->getDeclarationName($classPos).'::'.$phpcsFile->getDeclarationName($functionPos);
 
         $functionToken = $tokens[$functionPos];
         $openBracePtr = $functionToken['scope_opener'];
@@ -226,7 +226,7 @@ 
 
         $phpcsFile->fixer->beginChangeset();
         $phpcsFile->fixer->addNewlineBefore($closingBracePtr - 1);
-        $phpcsFile->fixer->addContentBefore($closingBracePtr - 1, $expectedReturnSpaces . 'return $this;');
+        $phpcsFile->fixer->addContentBefore($closingBracePtr - 1, $expectedReturnSpaces.'return $this;');
         $phpcsFile->fixer->addNewlineBefore($closingBracePtr - 1);
         $phpcsFile->fixer->endChangeset();
     }

build/refreshReadmeTable.php

Spacing +4 added lines, -4 removed lines

@@ -2,7 +2,7 @@ 
 
 declare(strict_types=1);
 
-require_once __DIR__ . '/../vendor/autoload.php';
+require_once __DIR__.'/../vendor/autoload.php';
 
 $directory = new RecursiveDirectoryIterator($baseFolder = './src/Standards/BestIt/Sniffs');
 $iterator = new RecursiveIteratorIterator($directory);
@@ -74,8 +74,8 @@ 
     foreach ($regexIterator as $file) {
         [$file] = $file;
 
-        $simpleClassName = str_replace([$baseFolder . DIRECTORY_SEPARATOR, '.php', 'Sniff'], '', $file);
-        $fullQualifiedClassName = 'BestIt\\Sniffs\\' . str_replace('/', '\\', $simpleClassName) . 'Sniff';
+        $simpleClassName = str_replace([$baseFolder.DIRECTORY_SEPARATOR, '.php', 'Sniff'], '', $file);
+        $fullQualifiedClassName = 'BestIt\\Sniffs\\'.str_replace('/', '\\', $simpleClassName).'Sniff';
 
         $hasSuppresses = (bool) preg_match_all(
             '/->isSniffSuppressed\((?P<code>\s*.*\s*)\)/mU',
@@ -145,7 +145,7 @@ 
     ksort($codes);
 
     file_put_contents(
-        $tmpFile = __DIR__ . DIRECTORY_SEPARATOR . 'table.md',
+        $tmpFile = __DIR__.DIRECTORY_SEPARATOR.'table.md',
         <<<EOD
 | Sniff | Description | suppressable |
 | ----- | ----------- | ------------ |

src/Standards/BestIt/Sniffs/DocTags/TagSortingSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -151,7 +151,7 @@ 
     /**
      * The callback to sort tokens.
      *
-     * 1. @return goes to the bottom
+     * 1. @return integer to the bottom
      * 2. Single tags are group alphabetically in the top group.
      * 3. Groups are sorted then by occurrence, that the largest group is the last one before the return.
      * 4. Same annotations are kept in the order of their code.
@@ -160,7 +160,7 @@ 
      * @param array $rightToken Provided by usort.
      * @param array $tagCounts Saves the occurence count for every tag.
      *
-     * @return int
+     * @return integer
      */
     private function compareTokensForSorting(array $leftToken, array $rightToken, array $tagCounts): int
     {

Spacing +9 added lines, -9 removed lines

@@ -230,27 +230,27 @@ 
 
             // Insert new line between groups.
             if ($isGroupSwitch) {
-                $newContent .= $lineStartingPadding . '*' . $eolChar;
+                $newContent .= $lineStartingPadding.'*'.$eolChar;
             }
 
             // Create the new Tag.
             // WARNING We do not need a line break in the tag summary.
-            $newContent .= $lineStartingPadding . '* ' . trim($thisTagContent);
+            $newContent .= $lineStartingPadding.'* '.trim($thisTagContent);
 
             if ($tag['contents']) {
                 $prevLine = $tag['line'];
                 foreach ($tag['contents'] as $subToken) {
                     // If we have a line switch, we need to create the correct indentation from before ...
                     if ($withLineSwitch = $subToken['line'] > $prevLine) {
-                        $newContent .= $eolChar .
-                            $lineStartingPadding . '*' .
+                        $newContent .= $eolChar.
+                            $lineStartingPadding.'*'.
                             str_repeat(' ', $subToken['column'] - strlen($lineStartingPadding) - 2);
 
                         $prevLine = $subToken['line'];
                     }
 
                     // ... if we have no line switch, then an additional whitespace is enough.
-                    $newContent .= ($withLineSwitch ? '' : ' ') . $subToken['content'];
+                    $newContent .= ($withLineSwitch ? '' : ' ').$subToken['content'];
                 }
             }
 
@@ -260,7 +260,7 @@ 
             $withReturn = $isReturn;
         }
 
-        $newContent .= $lineStartingPadding . '*/' . $eolChar;
+        $newContent .= $lineStartingPadding.'*/'.$eolChar;
 
         return $newContent;
     }
@@ -332,7 +332,7 @@ 
 
         $fixer->addContentBefore(
             $token['pointer'],
-            $this->file->getEolChar() . $lineStartPadding . '* '
+            $this->file->getEolChar().$lineStartPadding.'* '
         );
 
         $fixer->endChangeset();
@@ -348,7 +348,7 @@ 
         $barrier = 0;
         $tokens = $this->docTagHelper->getTagTokens();
 
-        $tokens = array_filter($tokens, function (array $token) use (&$barrier): bool {
+        $tokens = array_filter($tokens, function(array $token) use (&$barrier): bool {
             $allowed = true;
 
             if ($barrier) {
@@ -443,7 +443,7 @@ 
     {
         $tagCounts = $this->docTagHelper->getTagCounts($tokens);
 
-        usort($tokens, function (array $leftToken, array $rightToken) use ($tagCounts): int {
+        usort($tokens, function(array $leftToken, array $rightToken) use ($tagCounts): int {
             return $this->compareTokensForSorting($leftToken, $rightToken, $tagCounts);
         });
 

src/Standards/BestIt/Sniffs/Formatting/TraitUseDeclarationSniff.php

Spacing +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
         $commaPointers = TokenHelper::findNextAll($file, T_COMMA, $usePos + 1, $endPos);
         foreach ($commaPointers as $commaPos) {
             $pointerAfterComma = TokenHelper::findNextEffective($file, $commaPos + 1);
-            $fixer->replaceToken($commaPos, ';' . $file->eolChar . $indentation . 'use ');
+            $fixer->replaceToken($commaPos, ';'.$file->eolChar.$indentation.'use ');
             for ($i = $commaPos + 1; $i < $pointerAfterComma; $i++) {
                 $fixer->replaceToken($i, '');
             }

src/Standards/BestIt/Sniffs/Formatting/AlphabeticallySortedUsesSniff.php

Spacing +2 added lines, -2 removed lines

@@ -199,7 +199,7 @@ 
         return implode(
             $file->eolChar,
             array_map(
-                function (UseStatement $useStatement) use ($file): string {
+                function(UseStatement $useStatement) use ($file): string {
                     $unqualifiedName = NamespaceHelper::getUnqualifiedNameFromFullyQualifiedName(
                         $useStatement->getFullyQualifiedTypeName()
                     );
@@ -301,7 +301,7 @@ 
      */
     private function sortUseStatements(): void
     {
-        uasort($this->useStatements, function (UseStatement $prevStatement, UseStatement $nextStatement) {
+        uasort($this->useStatements, function(UseStatement $prevStatement, UseStatement $nextStatement) {
             return $this->compareUseStatements($prevStatement, $nextStatement);
         });
     }

src/Standards/BestIt/Sniffs/Commenting/RequiredDocBlockSniff.php

Spacing +3 added lines, -3 removed lines

@@ -94,13 +94,13 @@ 
 
             if ($tokenIdent == $this->registeredTokens[T_VARIABLE]) {
                 $exception = (new CodeError(
-                    static::CODE_MISSING_DOC_BLOCK_PREFIX . ucfirst($tokenIdent),
+                    static::CODE_MISSING_DOC_BLOCK_PREFIX.ucfirst($tokenIdent),
                     self::MESSAGE_MISSING_DOC_BLOCK_VAR,
                     $this->stackPos
                 ))->setPayload([lcfirst($tokenIdent)]);
             } else {
                 $exception = (new CodeError(
-                    static::CODE_MISSING_DOC_BLOCK_PREFIX . ucfirst($tokenIdent),
+                    static::CODE_MISSING_DOC_BLOCK_PREFIX.ucfirst($tokenIdent),
                     self::MESSAGE_MISSING_DOC_BLOCK,
                     $this->stackPos
                 ))->setPayload([lcfirst($tokenIdent)]);
@@ -127,7 +127,7 @@ 
             $tokenIdent = $this->getTokenName();
 
             $exception = (new CodeError(
-                static::CODE_NO_MULTI_LINE_DOC_BLOCK_PREFIX . ucfirst($tokenIdent),
+                static::CODE_NO_MULTI_LINE_DOC_BLOCK_PREFIX.ucfirst($tokenIdent),
                 self::MESSAGE_NO_MULTI_LINE_DOC_BLOCK_PREFIX,
                 $docCommentPos
             ))->setPayload([lcfirst($tokenIdent)]);