Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | class MethodDocSniff extends AbstractDocSniff |
||
12 | { |
||
13 | /** |
||
14 | * Returns which tokens should be listened to. |
||
15 | * |
||
16 | * @return int[] List of tokens which is to be listened to |
||
17 | */ |
||
18 | 28 | public function getListenedTokens() |
|
24 | |||
25 | /** |
||
26 | * Returns allowed tag metadata. |
||
27 | * |
||
28 | * @return array List of tag metadata |
||
29 | */ |
||
30 | 26 | public function getTagMetadata() |
|
58 | |||
59 | /** |
||
60 | * Returns an array of disallowed tokens. |
||
61 | * |
||
62 | * @return array List of disallowed tags |
||
63 | */ |
||
64 | 26 | View Code Duplication | public function getDisallowedTags() |
93 | } |
||
94 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.