Bernard\Router\SimpleReceiverResolver

Complexity

Total Complexity

8

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

60%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	accepts()	0	4	3
A	resolve()	0	21	5

<?php

namespace Bernard\Router;

use Bernard\Envelope;
use Bernard\Receiver;

/**
 * SimpleReceiverResolver supports various receiver inputs, like classes objects and callables.
 */
class SimpleReceiverResolver implements ReceiverResolver
{
    /**
     * {@inheritdoc}
     */
    public function accepts($receiver)
    {
        return is_callable($receiver) || is_object($receiver) || class_exists($receiver);
    }

    /**
     * {@inheritdoc}
     */
    public function resolve($receiver, Envelope $envelope)
    {
        if (null === $receiver) {
            return null;
        }

        if ($receiver instanceof Receiver) {
            return $receiver;
        }

        if (is_callable($receiver) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $receiver = [$receiver, lcfirst($envelope->getName())];
        }

        // Receiver is still not a callable which means it's not a valid receiver.
        if (is_callable($receiver) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return null;
        }

        return new Receiver\CallableReceiver($receiver);
    }
}