Driver - Code Metrics - Inspection of "Merge pull request #341 from namoscato/drivers-red..." - bernardphp/bernard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — drivers ( ce2bdc...3f42ed )

by Márk

created 2018-02-11 04:23 UTC

Driver A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	1
dl	0
loc	37
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	popMessage()	6	2
A	info()	13	1

<?php

namespace Bernard\Driver\Predis;

use Predis\ClientInterface;

/**
 * @package Bernard
 */
final class Driver extends \Bernard\Driver\PhpRedis\Driver
{
    /**
     * @param ClientInterface $redis
     */
    public function __construct(ClientInterface $redis)
    {
        $this->redis = $redis;
    }

    /**
     * {@inheritdoc}
     */
    public function popMessage($queueName, $duration = 5)
    {
        list(, $message) = $this->redis->blpop($this->resolveKey($queueName), $duration) ?: null;
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return [$message, null];
    }

    /**
     * {@inheritdoc}
     */
    public function info()
    {
        // Temporarily change the command use to get info as earlier and newer redis
        // versions breaks it into sections.
        $commandClass = $this->redis->getProfile()->getCommandClass('info');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->redis->getProfile()->defineCommand('info', 'Predis\Command\ServerInfo');

        $info = $this->redis->info();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->redis->getProfile()->defineCommand('info', $commandClass);

        return $info;
    }
}


GitHub Access Token became invalid

Push — drivers ( ce2bdc...3f42ed )

Driver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Bernard\Driver\Predis;
4
5			use Predis\ClientInterface;
6
7			/**
8			* @package Bernard
9			*/
10			final class Driver extends \Bernard\Driver\PhpRedis\Driver
11			{
12			/**
13			* @param ClientInterface $redis
14			*/
15			public function __construct(ClientInterface $redis)
16			{
17			$this->redis = $redis;
18			}
19
20			/**
21			* {@inheritdoc}
22			*/
23			public function popMessage($queueName, $duration = 5)
24			{
25			list(, $message) = $this->redis->blpop($this->resolveKey($queueName), $duration) ?: null;
			0 ignored issues – show Bug introduced 2017-11-19 17:50 UTC by Report Bug Copy Issue Report The method `blpop` does only exist in `Redis`, but not in `Predis\ClientInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
26
27			return [$message, null];
28			}
29
30			/**
31			* {@inheritdoc}
32			*/
33			public function info()
34			{
35			// Temporarily change the command use to get info as earlier and newer redis
36			// versions breaks it into sections.
37			$commandClass = $this->redis->getProfile()->getCommandClass('info');
			0 ignored issues – show Bug introduced 2017-11-19 17:50 UTC by Report Bug Copy Issue Report The method `getProfile` does only exist in `Predis\ClientInterface`, but not in `Redis`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38			$this->redis->getProfile()->defineCommand('info', 'Predis\Command\ServerInfo');
39
40			$info = $this->redis->info();
			0 ignored issues – show Bug introduced 2017-11-19 17:50 UTC by Report Bug Copy Issue Report The method `info` does only exist in `Redis`, but not in `Predis\ClientInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41
42			$this->redis->getProfile()->defineCommand('info', $commandClass);
43
44			return $info;
45			}
46			}
47

bernardphp / bernard

GitHub Access Token became invalid

Push — drivers ( ce2bdc...3f42ed )

Driver A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like