PhpAmqpDriver::configureQueueOptions() - Code Metrics - Inspection of "Added options array to queue create and message pr..." - bernardphp/bernard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#206)

by Jeroen

created 2015-12-27 23:18 UTC

PhpAmqpDriver::configureQueueOptions() A

↳ Parent: PhpAmqpDriver

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	17
rs	9.4286
cc	1
eloc	3
nc	1
nop	1

<?php

namespace Bernard\Driver;

use Bernard\Driver;
use PhpAmqpLib\Channel\AMQPChannel;
use PhpAmqpLib\Connection\AMQPStreamConnection;
use PhpAmqpLib\Message\AMQPMessage;
use Symfony\Component\OptionsResolver\OptionsResolver;

class PhpAmqpDriver extends AbstractDriver
{
    /**
     * @var AMQPStreamConnection
     */
    private $connection;

    /**
     * @var AMQPChannel
     */
    private $channel;

    /**
     * @var string
     */
    private $exchange;
    /**
     * @var array|null
     */
    private $defaultMessageParams;

    /**
     * @param AMQPStreamConnection $connection
     * @param string               $exchange
     * @param array                $defaultMessageParams
     */
    public function __construct(AMQPStreamConnection $connection, $exchange, array $defaultMessageParams = null)
    {
        $this->connection = $connection;
        $this->exchange = $exchange;
        $this->defaultMessageParams = $defaultMessageParams;

        $this->channel = $this->connection->channel();
    }

    /**
     * Returns a list of all queue names.
     *
     * @return array
     */
    public function listQueues()
    {
    }

    /**
     * {@inheritdoc}
     */
    public function createQueue($queueName, array $options = [])
    {
        $options = $this->validateQueueOptions($options);

        $this->channel->exchange_declare($this->exchange, 'direct', false, true, false);
        $this->channel->queue_declare($queueName, false, true, false, false);
        $this->channel->queue_bind($queueName, $this->exchange, $options['routingkey']);
    }

    /**
     * Count the number of messages in queue. This can be a approximately number.
     *
     * @return int
     */
    public function countMessages($queueName)
    {
    }

    /**
     * {@inheritdoc}
     */
    public function pushMessage($queueName, $message, array $options = [])
    {
        $amqpMessage = new AMQPMessage($message, $this->defaultMessageParams);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $options = $this->validatePushOptions($options);

        $this->channel->basic_publish(
            $amqpMessage,
            $this->exchange,
            $options['routingkey'],
            $options['mandatory'],
            $options['immediate'],
            $options['ticket']
        );
    }

    /**
     * Remove the next message in line. And if no message is available
     * wait $interval seconds.
     *
     * @param string $queueName
     * @param int    $interval
     *
     * @return array An array like array($message, $receipt);
     */
    public function popMessage($queueName, $interval = 5)
    {
        $message = $this->channel->basic_get($queueName);
        if (!$message) {
            // sleep for 10 ms to prevent hammering CPU
            usleep(10000);

            return [null, null];
        }

        return [$message->body, $message->get('delivery_tag')];
    }

    /**
     * If the driver supports it, this will be called when a message
     * have been consumed.
     *
     * @param string $queueName
     * @param mixed  $receipt
     */
    public function acknowledgeMessage($queueName, $receipt)
    {
        $this->channel->basic_ack($receipt);
    }

    /**
     * Returns a $limit numbers of messages without removing them
     * from the queue.
     *
     * @param string $queueName
     * @param int    $index
     * @param int    $limit
     */
    public function peekQueue($queueName, $index = 0, $limit = 20)
    {
    }

    /**
     * Removes the queue.
     *
     * @param string $queueName
     */
    public function removeQueue($queueName)
    {
    }

    /**
     * @return array
     */
    public function info()
    {
    }

    public function __destruct()
    {
        $this->channel->close();
    }

    public function configureQueueOptions(OptionsResolver $resolver)
    {
        //BC layer to support 2.3+ and 2.7+/3.0+ versions
//        if (class_exists('Symfony\Component\OptionsResolver\OptionsResolverInterface')) {
//            //2.3+
//            $resolver->setDefaults(array(
//                'routingkey' => '',
//            ));
//        } else {
//            //2.7+
//        }

        $resolver->setDefaults(array(
            'routingkey' => '',
        ));

    }

    public function configurePushOptions(OptionsResolver $resolver)
    {
        $resolver->setDefaults(array(
            'routingkey' => '',
            'mandatory' => false,
            'immediate' => false,
            'ticket' => null,
        ));
    }


}


1			<?php
2
3			namespace Bernard\Driver;
4
5			use Bernard\Driver;
6			use PhpAmqpLib\Channel\AMQPChannel;
7			use PhpAmqpLib\Connection\AMQPStreamConnection;
8			use PhpAmqpLib\Message\AMQPMessage;
9			use Symfony\Component\OptionsResolver\OptionsResolver;
10
11			class PhpAmqpDriver extends AbstractDriver
12			{
13			/**
14			* @var AMQPStreamConnection
15			*/
16			private $connection;
17
18			/**
19			* @var AMQPChannel
20			*/
21			private $channel;
22
23			/**
24			* @var string
25			*/
26			private $exchange;
27			/**
28			* @var array\|null
29			*/
30			private $defaultMessageParams;
31
32			/**
33			* @param AMQPStreamConnection $connection
34			* @param string $exchange
35			* @param array $defaultMessageParams
36			*/
37			public function __construct(AMQPStreamConnection $connection, $exchange, array $defaultMessageParams = null)
38			{
39			$this->connection = $connection;
40			$this->exchange = $exchange;
41			$this->defaultMessageParams = $defaultMessageParams;
42
43			$this->channel = $this->connection->channel();
44			}
45
46			/**
47			* Returns a list of all queue names.
48			*
49			* @return array
50			*/
51			public function listQueues()
52			{
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function createQueue($queueName, array $options = [])
59			{
60			$options = $this->validateQueueOptions($options);
61
62			$this->channel->exchange_declare($this->exchange, 'direct', false, true, false);
63			$this->channel->queue_declare($queueName, false, true, false, false);
64			$this->channel->queue_bind($queueName, $this->exchange, $options['routingkey']);
65			}
66
67			/**
68			* Count the number of messages in queue. This can be a approximately number.
69			*
70			* @return int
71			*/
72			public function countMessages($queueName)
73			{
74			}
75
76			/**
77			* {@inheritdoc}
78			*/
79			public function pushMessage($queueName, $message, array $options = [])
80			{
81			$amqpMessage = new AMQPMessage($message, $this->defaultMessageParams);
			0 ignored issues – show Bug introduced 2015-11-30 20:04 UTC by Report Bug Copy Issue Report It seems like `$this->defaultMessageParams` can also be of type `array`; however, `PhpAmqpLib\Message\AMQPMessage::__construct()` does only seem to accept `null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
82			$options = $this->validatePushOptions($options);
83
84			$this->channel->basic_publish(
85			$amqpMessage,
86			$this->exchange,
87			$options['routingkey'],
88			$options['mandatory'],
89			$options['immediate'],
90			$options['ticket']
91			);
92			}
93
94			/**
95			* Remove the next message in line. And if no message is available
96			* wait $interval seconds.
97			*
98			* @param string $queueName
99			* @param int $interval
100			*
101			* @return array An array like array($message, $receipt);
102			*/
103			public function popMessage($queueName, $interval = 5)
104			{
105			$message = $this->channel->basic_get($queueName);
106			if (!$message) {
107			// sleep for 10 ms to prevent hammering CPU
108			usleep(10000);
109
110			return [null, null];
111			}
112
113			return [$message->body, $message->get('delivery_tag')];
114			}
115
116			/**
117			* If the driver supports it, this will be called when a message
118			* have been consumed.
119			*
120			* @param string $queueName
121			* @param mixed $receipt
122			*/
123			public function acknowledgeMessage($queueName, $receipt)
124			{
125			$this->channel->basic_ack($receipt);
126			}
127
128			/**
129			* Returns a $limit numbers of messages without removing them
130			* from the queue.
131			*
132			* @param string $queueName
133			* @param int $index
134			* @param int $limit
135			*/
136			public function peekQueue($queueName, $index = 0, $limit = 20)
137			{
138			}
139
140			/**
141			* Removes the queue.
142			*
143			* @param string $queueName
144			*/
145			public function removeQueue($queueName)
146			{
147			}
148
149			/**
150			* @return array
151			*/
152			public function info()
153			{
154			}
155
156			public function __destruct()
157			{
158			$this->channel->close();
159			}
160
161			public function configureQueueOptions(OptionsResolver $resolver)
162			{
163			//BC layer to support 2.3+ and 2.7+/3.0+ versions
164			// if (class_exists('Symfony\Component\OptionsResolver\OptionsResolverInterface')) {
165			// //2.3+
166			// $resolver->setDefaults(array(
167			// 'routingkey' => '',
168			// ));
169			// } else {
170			// //2.7+
171			// }
172
173			$resolver->setDefaults(array(
174			'routingkey' => '',
175			));
176
177			}
178
179			public function configurePushOptions(OptionsResolver $resolver)
180			{
181			$resolver->setDefaults(array(
182			'routingkey' => '',
183			'mandatory' => false,
184			'immediate' => false,
185			'ticket' => null,
186			));
187			}
188
189
190			}
191

bernardphp / bernard

GitHub Access Token became invalid

Pull Request — master (#206)

PhpAmqpDriver::configureQueueOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like