Driver::__construct() - Code Metrics - Inspection of "WIP: Drivers" - bernardphp/bernard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#337)

by Márk

created 2017-11-07 09:35 UTC

Driver::__construct() A

↳ Parent: Driver

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	3

<?php

namespace Bernard\Driver\Amqp;

use PhpAmqpLib\Channel\AMQPChannel;
use PhpAmqpLib\Connection\AbstractConnection;
use PhpAmqpLib\Message\AMQPMessage;

final class Driver implements \Bernard\Driver
{
    /**
     * @var AbstractConnection
     */
    private $connection;

    /**
     * @var AMQPChannel
     */
    private $channel;

    /**
     * @var string
     */
    private $exchange;

    /**
     * @var array|null
     */
    private $defaultMessageParams;

    /**
     * @param AbstractConnection $connection
     * @param string             $exchange
     * @param array              $defaultMessageParams
     */
    public function __construct(AbstractConnection $connection, $exchange, array $defaultMessageParams = null)
    {
        $this->connection = $connection;
        $this->exchange = $exchange;
        $this->defaultMessageParams = $defaultMessageParams;
    }

    /**
     * Returns a list of all queue names.
     *
     * @return array
     */
    public function listQueues()
    {
    }

    /**
     * Create a queue.
     *
     * @param string $queueName
     */
    public function createQueue($queueName)
    {
        $channel = $this->getChannel();
        $channel->exchange_declare($this->exchange, 'direct', false, true, false);
        $channel->queue_declare($queueName, false, true, false, false);
        $channel->queue_bind($queueName, $this->exchange, $queueName);
    }

    /**
     * Count the number of messages in queue. This can be a approximately number.
     *
     * @param string $queueName
     *
     * @return int
     */
    public function countMessages($queueName)
    {
        list(,$messageCount) = $this->getChannel()->queue_declare($queueName, true);

        return $messageCount;
    }

    /**
     * Insert a message at the top of the queue.
     *
     * @param string $queueName
     * @param string $message
     */
    public function pushMessage($queueName, $message)
    {
        $amqpMessage = new AMQPMessage($message, $this->defaultMessageParams);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->getChannel()->basic_publish($amqpMessage, $this->exchange, $queueName);
    }

    /**
     * Remove the next message in line. And if no message is available
     * wait $duration seconds.
     *
     * @param string $queueName
     * @param int    $duration
     *
     * @return array An array like array($message, $receipt);
     */
    public function popMessage($queueName, $duration = 5)
    {
        $runtime = microtime(true) + $duration;

        while (microtime(true) < $runtime) {
            $message = $this->getChannel()->basic_get($queueName);

            if ($message) {
                return [$message->body, $message->get('delivery_tag')];
            }

            // sleep for 10 ms to prevent hammering CPU
            usleep(10000);
        }

        return [null, null];
    }

    /**
     * If the driver supports it, this will be called when a message
     * have been consumed.
     *
     * @param string $queueName
     * @param mixed  $receipt
     */
    public function acknowledgeMessage($queueName, $receipt)
    {
        $this->getChannel()->basic_ack($receipt);
    }

    /**
     * Returns a $limit numbers of messages without removing them
     * from the queue.
     *
     * @param string $queueName
     * @param int    $index
     * @param int    $limit
     */
    public function peekQueue($queueName, $index = 0, $limit = 20)
    {
    }

    /**
     * Removes the queue.
     *
     * @param string $queueName
     */
    public function removeQueue($queueName)
    {
        $this->getChannel()->queue_delete($queueName);
    }

    /**
     * @return array
     */
    public function info()
    {
    }

    public function __destruct()
    {
        if (null !== $this->channel) {
            $this->channel->close();
        }
    }

    private function getChannel()
    {
        if (null === $this->channel) {
            $this->channel = $this->connection->channel();
        }

        return $this->channel;
    }
}


1			<?php
2
3			namespace Bernard\Driver\Amqp;
4
5			use PhpAmqpLib\Channel\AMQPChannel;
6			use PhpAmqpLib\Connection\AbstractConnection;
7			use PhpAmqpLib\Message\AMQPMessage;
8
9			final class Driver implements \Bernard\Driver
10			{
11			/**
12			* @var AbstractConnection
13			*/
14			private $connection;
15
16			/**
17			* @var AMQPChannel
18			*/
19			private $channel;
20
21			/**
22			* @var string
23			*/
24			private $exchange;
25
26			/**
27			* @var array\|null
28			*/
29			private $defaultMessageParams;
30
31			/**
32			* @param AbstractConnection $connection
33			* @param string $exchange
34			* @param array $defaultMessageParams
35			*/
36			public function __construct(AbstractConnection $connection, $exchange, array $defaultMessageParams = null)
37			{
38			$this->connection = $connection;
39			$this->exchange = $exchange;
40			$this->defaultMessageParams = $defaultMessageParams;
41			}
42
43			/**
44			* Returns a list of all queue names.
45			*
46			* @return array
47			*/
48			public function listQueues()
49			{
50			}
51
52			/**
53			* Create a queue.
54			*
55			* @param string $queueName
56			*/
57			public function createQueue($queueName)
58			{
59			$channel = $this->getChannel();
60			$channel->exchange_declare($this->exchange, 'direct', false, true, false);
61			$channel->queue_declare($queueName, false, true, false, false);
62			$channel->queue_bind($queueName, $this->exchange, $queueName);
63			}
64
65			/**
66			* Count the number of messages in queue. This can be a approximately number.
67			*
68			* @param string $queueName
69			*
70			* @return int
71			*/
72			public function countMessages($queueName)
73			{
74			list(,$messageCount) = $this->getChannel()->queue_declare($queueName, true);
75
76			return $messageCount;
77			}
78
79			/**
80			* Insert a message at the top of the queue.
81			*
82			* @param string $queueName
83			* @param string $message
84			*/
85			public function pushMessage($queueName, $message)
86			{
87			$amqpMessage = new AMQPMessage($message, $this->defaultMessageParams);
			0 ignored issues – show Bug introduced 2016-02-17 19:36 UTC by Report Bug Copy Issue Report It seems like `$this->defaultMessageParams` can also be of type `null`; however, `PhpAmqpLib\Message\AMQPMessage::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
88			$this->getChannel()->basic_publish($amqpMessage, $this->exchange, $queueName);
89			}
90
91			/**
92			* Remove the next message in line. And if no message is available
93			* wait $duration seconds.
94			*
95			* @param string $queueName
96			* @param int $duration
97			*
98			* @return array An array like array($message, $receipt);
99			*/
100			public function popMessage($queueName, $duration = 5)
101			{
102			$runtime = microtime(true) + $duration;
103
104			while (microtime(true) < $runtime) {
105			$message = $this->getChannel()->basic_get($queueName);
106
107			if ($message) {
108			return [$message->body, $message->get('delivery_tag')];
109			}
110
111			// sleep for 10 ms to prevent hammering CPU
112			usleep(10000);
113			}
114
115			return [null, null];
116			}
117
118			/**
119			* If the driver supports it, this will be called when a message
120			* have been consumed.
121			*
122			* @param string $queueName
123			* @param mixed $receipt
124			*/
125			public function acknowledgeMessage($queueName, $receipt)
126			{
127			$this->getChannel()->basic_ack($receipt);
128			}
129
130			/**
131			* Returns a $limit numbers of messages without removing them
132			* from the queue.
133			*
134			* @param string $queueName
135			* @param int $index
136			* @param int $limit
137			*/
138			public function peekQueue($queueName, $index = 0, $limit = 20)
139			{
140			}
141
142			/**
143			* Removes the queue.
144			*
145			* @param string $queueName
146			*/
147			public function removeQueue($queueName)
148			{
149			$this->getChannel()->queue_delete($queueName);
150			}
151
152			/**
153			* @return array
154			*/
155			public function info()
156			{
157			}
158
159			public function __destruct()
160			{
161			if (null !== $this->channel) {
162			$this->channel->close();
163			}
164			}
165
166			private function getChannel()
167			{
168			if (null === $this->channel) {
169			$this->channel = $this->connection->channel();
170			}
171
172			return $this->channel;
173			}
174			}
175

bernardphp / bernard

GitHub Access Token became invalid

Pull Request — master (#337)

Driver::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like