AmqpInteropDriver::acknowledgeMessage() - Code Metrics - Inspection of "Add queue interop driver" - bernardphp/bernard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#320)

by Maksim

created 2017-08-11 11:59 UTC

AmqpInteropDriver::acknowledgeMessage() A

↳ Parent: AmqpInteropDriver

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2

<?php
namespace Bernard\Driver;

use Bernard\Driver;
use Interop\Amqp\AmqpContext;
use Interop\Amqp\AmqpQueue;

final class AmqpInteropDriver implements Driver
{
    /**
     * @var AmqpContext
     */
    private $context;

    /**
     * @var InteropDriver
     */
    private $interopDriver;

    /**
     * @param InteropDriver $interopDriver
     */
    public function __construct(InteropDriver $interopDriver)
    {
        $this->interopDriver = $interopDriver;
        $this->context = $interopDriver->getContext();

        if (false == $this->context instanceof AmqpContext) {

            throw new \LogicException(sprintf(
                'The context must be instance of "%s" but got "%s"',
                AmqpContext::class,
                get_class($this->context)
            ));
        }
    }

    /**
     * {@inheritdoc}
     */
    public function listQueues()
    {
        return $this->interopDriver->listQueues();
    }

    /**
     * {@inheritdoc}
     */
    public function createQueue($queueName)
    {
        $this->context->declareQueue($this->createAmqpQueue($queueName));
    }

    /**
     * {@inheritdoc}
     */
    public function countMessages($queueName)
    {
        return $this->context->declareQueue($this->createAmqpQueue($queueName));
    }

    /**
     * {@inheritdoc}
     */
    public function pushMessage($queueName, $message)
    {
        $this->interopDriver->pushMessage($queueName, $message);
    }

    /**
     * {@inheritdoc}
     */
    public function popMessage($queueName, $duration = 5)
    {
        return $this->interopDriver->popMessage($queueName, $duration);
    }

    /**
     * {@inheritdoc}
     */
    public function acknowledgeMessage($queueName, $receipt)
    {
        $this->interopDriver->acknowledgeMessage($queueName, $receipt);
    }

    /**
     * {@inheritdoc}
     */
    public function peekQueue($queueName, $index = 0, $limit = 20)
    {
        return $this->interopDriver->peekQueue($queueName, $index, $limit);
    }

    /**
     * {@inheritdoc}
     */
    public function removeQueue($queueName)
    {
        $queue = $this->createAmqpQueue($queueName);

        $this->context->deleteQueue($queue);
    }

    /**
     * {@inheritdoc}
     */
    public function info()
    {
        $this->interopDriver->info();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * @param $queueName
     *
     * @return AmqpQueue
     */
    private function createAmqpQueue($queueName)
    {
        $queue = $this->context->createQueue($queueName);
        $queue->addFlag(AmqpQueue::FLAG_DURABLE);

        return $queue;
    }

    /**
     * @return AmqpContext
     */
    public function getContext()
    {
        return $this->context;
    }
}


1			<?php
2			namespace Bernard\Driver;
3
4			use Bernard\Driver;
5			use Interop\Amqp\AmqpContext;
6			use Interop\Amqp\AmqpQueue;
7
8			final class AmqpInteropDriver implements Driver
9			{
10			/**
11			* @var AmqpContext
12			*/
13			private $context;
14
15			/**
16			* @var InteropDriver
17			*/
18			private $interopDriver;
19
20			/**
21			* @param InteropDriver $interopDriver
22			*/
23			public function __construct(InteropDriver $interopDriver)
24			{
25			$this->interopDriver = $interopDriver;
26			$this->context = $interopDriver->getContext();
27
28			if (false == $this->context instanceof AmqpContext) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-08-10 12:49 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
29			throw new \LogicException(sprintf(
30			'The context must be instance of "%s" but got "%s"',
31			AmqpContext::class,
32			get_class($this->context)
33			));
34			}
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function listQueues()
41			{
42			return $this->interopDriver->listQueues();
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function createQueue($queueName)
49			{
50			$this->context->declareQueue($this->createAmqpQueue($queueName));
51			}
52
53			/**
54			* {@inheritdoc}
55			*/
56			public function countMessages($queueName)
57			{
58			return $this->context->declareQueue($this->createAmqpQueue($queueName));
59			}
60
61			/**
62			* {@inheritdoc}
63			*/
64			public function pushMessage($queueName, $message)
65			{
66			$this->interopDriver->pushMessage($queueName, $message);
67			}
68
69			/**
70			* {@inheritdoc}
71			*/
72			public function popMessage($queueName, $duration = 5)
73			{
74			return $this->interopDriver->popMessage($queueName, $duration);
75			}
76
77			/**
78			* {@inheritdoc}
79			*/
80			public function acknowledgeMessage($queueName, $receipt)
81			{
82			$this->interopDriver->acknowledgeMessage($queueName, $receipt);
83			}
84
85			/**
86			* {@inheritdoc}
87			*/
88			public function peekQueue($queueName, $index = 0, $limit = 20)
89			{
90			return $this->interopDriver->peekQueue($queueName, $index, $limit);
91			}
92
93			/**
94			* {@inheritdoc}
95			*/
96			public function removeQueue($queueName)
97			{
98			$queue = $this->createAmqpQueue($queueName);
99
100			$this->context->deleteQueue($queue);
101			}
102
103			/**
104			* {@inheritdoc}
105			*/
106			public function info()
107			{
108			$this->interopDriver->info();
			0 ignored issues – show Unused Code introduced 2017-08-11 12:01 UTC by Report Bug Copy Issue Report The call to the method `Bernard\Driver\InteropDriver::info()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
109			}
110
111			/**
112			* @param $queueName
113			*
114			* @return AmqpQueue
115			*/
116			private function createAmqpQueue($queueName)
117			{
118			$queue = $this->context->createQueue($queueName);
119			$queue->addFlag(AmqpQueue::FLAG_DURABLE);
120
121			return $queue;
122			}
123
124			/**
125			* @return AmqpContext
126			*/
127			public function getContext()
128			{
129			return $this->context;
130			}
131			}
132

bernardphp / bernard

GitHub Access Token became invalid

Pull Request — master (#320)

AmqpInteropDriver::acknowledgeMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like