Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | final class Driver implements \Bernard\Driver |
||
| 13 | { |
||
| 14 | private $messages; |
||
| 15 | private $queues; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @param MongoCollection $queues Collection where queues will be stored |
||
| 19 | * @param MongoCollection $messages Collection where messages will be stored |
||
| 20 | */ |
||
| 21 | 10 | public function __construct(MongoCollection $queues, MongoCollection $messages) |
|
| 26 | |||
| 27 | /** |
||
| 28 | * {@inheritdoc} |
||
| 29 | */ |
||
| 30 | 1 | public function listQueues() |
|
| 34 | |||
| 35 | /** |
||
| 36 | * {@inheritdoc} |
||
| 37 | */ |
||
| 38 | 1 | public function createQueue($queueName) |
|
| 44 | |||
| 45 | /** |
||
| 46 | * {@inheritdoc} |
||
| 47 | */ |
||
| 48 | 1 | public function countMessages($queueName) |
|
| 55 | |||
| 56 | /** |
||
| 57 | * {@inheritdoc} |
||
| 58 | */ |
||
| 59 | 1 | public function pushMessage($queueName, $message) |
|
| 70 | |||
| 71 | /** |
||
| 72 | * {@inheritdoc} |
||
| 73 | */ |
||
| 74 | 2 | public function popMessage($queueName, $duration = 5) |
|
| 97 | |||
| 98 | /** |
||
| 99 | * {@inheritdoc} |
||
| 100 | */ |
||
| 101 | 1 | public function acknowledgeMessage($queueName, $receipt) |
|
| 108 | |||
| 109 | /** |
||
| 110 | * {@inheritdoc} |
||
| 111 | */ |
||
| 112 | 1 | public function peekQueue($queueName, $index = 0, $limit = 20) |
|
| 130 | |||
| 131 | /** |
||
| 132 | * {@inheritdoc} |
||
| 133 | */ |
||
| 134 | 1 | public function removeQueue($queueName) |
|
| 139 | |||
| 140 | /** |
||
| 141 | * {@inheritdoc} |
||
| 142 | */ |
||
| 143 | 1 | public function info() |
|
| 150 | } |
||
| 151 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.