Benrowe\Laravel\Config\ServiceProvider

Complexity

Total Complexity

11

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	13
Bugs	1	Features	4

8 Methods

Rating	Name	Duplication	Size	Complexity
A	boot()	0	11	1
A	register()	0	16	3
A	provides()	0	7	1
A	selectStorage()	0	9	2
A	selectStoragePdo()	0	7	1
A	selectStorageRedis()	0	5	1
A	selectStorageCustom()	0	5	1
A	selectStorageFile()	0	5	1

<?php

namespace Benrowe\Laravel\Config;

use Benrowe\Laravel\Config\Storage\File;
use Benrowe\Laravel\Config\Storage\Pdo;
use Benrowe\Laravel\Config\Storage\Redis;
use Benrowe\Laravel\Config\Storage\StorageInterface;
use Illuminate\Contracts\Config\Repository as Config;

This use statement conflicts with another class in this namespace, Benrowe\Laravel\Config\Config.

use Illuminate\Support\ServiceProvider as BaseServiceProvider;

/**
 * Service Provider for Config
 *
 * @package Benrowe\Laravel\Config;
 */
class ServiceProvider extends BaseServiceProvider
{
    protected $defer = false;

    /**
     * @inheritdoc
     */
    public function boot()
    {
        # publish necessary files
        $this->publishes([
            __DIR__ . '/config/config.php' => config_path('config.php'),
        ], 'config');

        $this->publishes([
            __DIR__.'/migrations/' => database_path('migrations'),
        ], 'migrations');
    }

    /**
     * @inheritdoc
     */
    public function register()
    {
        $this->app->singleton('config-runtime', function () {
            $storage = $this->selectStorage($this->app['config']);
            if ($storage === null) {
                $storage = [];
            }
            $cfg = new Config($storage);

The call to Repository::__construct() has too many arguments starting with $storage.

            $modifiers = $this->app['config']->get('config.modifiers', []);
            foreach ($modifiers as $className) {
                $cfg->modifiers->push(new $className);

Accessing modifiers on the interface Illuminate\Contracts\Config\Repository suggest that you code against a concrete implementation. How about adding an instanceof check?

            }

            return $cfg;
        });
    }

    /**
     * Define the services this provider will build & provide
     *
     * @return string[]
     */
    public function provides()
    {
        return [
            'Benrowe\Laravel\Config\Config',
            'config-runtime'
        ];
    }

    /**
     * Retrieve the storage engine, based on the current configuration
     *
     * @param  Config $config
     * @return StorageInterface
     */
    protected function selectStorage($config)
    {
        if (!$config->get('config.storage.enabled')) {
            return null;
        }
        $driver = $config->get('config.storage.driver', 'file');
        $method = 'selectStorage'.ucfirst($driver);
        return $this->$method($config);
    }

    /**
     * Get an instance of the PDO storage engine
     *
     * @param  Config $config
     * @return Pdo
     */
    protected function selectStoragePdo($config)
    {
        $connection = $config->get('config.storage.connection');
        $table = $this->app['db']->getTablePrefix() . 'config';
        $pdo = $this->app['db']->connection($connection)->getPdo();
        return new Pdo($pdo, $table);
    }

    /**
     * Get an instance of the Redis storage engine
     *
     * @param  Config  $config
     * @return Redis
     */
    protected function selectStorageRedis($config)
    {
        $connection = $config->get('config.storage.connection');
        return new Redis($this->app['redis']->connection($connection));
    }

    /**
     * Get an instance of a custom defined storage engine
     *
     * @param  Config $config [description]
     * @return StorageInterface
     */
    protected function selectStorageCustom($config)
    {
        $class = $config->get('config.storage.provider');
        return $this->app->make($class);
    }

    /**
     * Get an instance of the File storage engine
     *
     * @param  Config $config
     * @return File
     */
    protected function selectStorageFile($config)
    {
        $path = $config->get('config.storage.path');
        return new File($path);
    }
}