shouldComponentUpdate.js ➔ shouldRowUpdate - Code Metrics - Inspection of "general clean up for shouldrowupdate" - bencripps/react-redux-grid - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7ae88...35be68 )

by Benjamin

created 2017-01-06 19:28 UTC

shouldComponentUpdate.js ➔ shouldRowUpdate B

↳ Parent: src/util/shouldComponentUpdate.js

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
nc	1
dl	0
loc	40
rs	8.8571
nop	1

import deepEqual from 'deep-equal';
import { getLastUpdate } from './lastUpdate';

export function shouldGridUpdate(nextProps) {
    let result = true;


    const { reducerKeys, stateKey, store } = this.props;

    const nextUpdate = getLastUpdate(store, stateKey, reducerKeys);

    result = (
        !deepEqual(nextUpdate, this._lastUpdate)
        || !equalProps(nextProps, this._lastProps)
    );

    this._lastUpdate = nextUpdate;
    this._lastProps = nextProps;

    return result;
}

export function shouldPagerUpdate(nextProps, nextState) {

    let result = true;


    const limitedNextProps = {
        gridData: nextProps.gridData,
        state: this.state
    };

    const limitedProps = {
        gridData: this.props.gridData,
        state: nextState
    };

    result = (
        !deepEqual(limitedNextProps, limitedProps)
    );

    return result;
}

export function shouldHeaderUpdate() {
    // let result = true;
    // to do, stop this
    return true;

    /* eslint-disable no-unreachable */

    // const menuState = state =>
    //     state && state.get('header-row');

    // const limitedNextProps = {
    //     columns: nextProps.columns,
    //     menuState: menuState(nextProps.menuState),
    //     state: nextState
    // };

    // const limitedProps = {
    //     columns: this.previousColumns,
    //     menuState: menuState(this.props.menuState),
    //     state: this.state
    // };

    // result = (
    //     !deepEqual(limitedNextProps, limitedProps)
    // );

    // this.previousColumns = this.props.columns.slice();

    // return result;

    /* eslint-enable no-unreachable */
}

export function shouldRowUpdate(nextProps) {
    let result = true;


    // unique key created by setData action/reducer
    const key = nextProps.row.get('_key');

    const limitedNextProps = {
        columns: slimColumn(nextProps.columns),
        isEdited: isEdited(nextProps.editorState, key),
        currentValues: isEdited(nextProps.editorState, key)
            ? nextProps.editorState.get(key)
            : null,
        isMenuShown: isMenuShown(nextProps.menuState, key),
        row: nextProps.row,
        index: nextProps.index,
        isSelected: isSelected(nextProps.selectedRows, key),
        isDragging: nextProps.isDragging
    };

    const limitedProps = {
        columns: this.previousColumns,
        isEdited: isEdited(this.props.editorState, key),
        currentValues: isEdited(this.props.editorState, key)
            ? this.props.editorState.get(key)
            : null,
        isMenuShown: isMenuShown(this.props.menuState, key),
        row: this.props.row,
        index: this.props.index,
        isSelected: isSelected(this.props.selectedRows, key),
        isDragging: this.props.isDragging
    };

    this.previousColumns = slimColumn(this.props.columns.slice());

    result = (
        !deepEqual(limitedNextProps, limitedProps)
    );

    return result;
}

export const isSelected = (rows, key) => Boolean(rows && rows.get(key));

export const isMenuShown = (rows, key) => Boolean(rows && rows.get(key));

export const isEdited = (editorState, key) => Boolean(
    editorState
    && editorState.get(key)
    && editorState.get(key).values
);

export const slimColumn = cols =>
    cols.map(col => ({ hidden: col.hidden, dataIndex: col.dataIndex }));

export const equalProps = (props = {}, newProps = {}) => {
    return props.height === newProps.height
        && deepEqual(props.classNames, newProps.classNames)
        && deepEqual(props.events, newProps.events);
};


1			import deepEqual from 'deep-equal';
2			import { getLastUpdate } from './lastUpdate';
3
4			export function shouldGridUpdate(nextProps) {
5			let result = true;
			0 ignored issues – show Unused Code introduced 2016-09-08 18:04 UTC by Report Bug Copy Issue Report The assignment to variable `result` seems to be never used. Consider removing it. Loading history...
6
7			const { reducerKeys, stateKey, store } = this.props;
8
9			const nextUpdate = getLastUpdate(store, stateKey, reducerKeys);
10
11			result = (
12			!deepEqual(nextUpdate, this._lastUpdate)
13			\|\| !equalProps(nextProps, this._lastProps)
14			);
15
16			this._lastUpdate = nextUpdate;
17			this._lastProps = nextProps;
18
19			return result;
20			}
21
22			export function shouldPagerUpdate(nextProps, nextState) {
23
24			let result = true;
			0 ignored issues – show Unused Code introduced 2016-09-30 16:20 UTC by Report Bug Copy Issue Report The assignment to variable `result` seems to be never used. Consider removing it. Loading history...
25
26			const limitedNextProps = {
27			gridData: nextProps.gridData,
28			state: this.state
29			};
30
31			const limitedProps = {
32			gridData: this.props.gridData,
33			state: nextState
34			};
35
36			result = (
37			!deepEqual(limitedNextProps, limitedProps)
38			);
39
40			return result;
41			}
42
43			export function shouldHeaderUpdate() {
44			// let result = true;
45			// to do, stop this
46			return true;
47
48			/* eslint-disable no-unreachable */
49
50			// const menuState = state =>
51			// state && state.get('header-row');
52
53			// const limitedNextProps = {
54			// columns: nextProps.columns,
55			// menuState: menuState(nextProps.menuState),
56			// state: nextState
57			// };
58
59			// const limitedProps = {
60			// columns: this.previousColumns,
61			// menuState: menuState(this.props.menuState),
62			// state: this.state
63			// };
64
65			// result = (
66			// !deepEqual(limitedNextProps, limitedProps)
67			// );
68
69			// this.previousColumns = this.props.columns.slice();
70
71			// return result;
72
73			/* eslint-enable no-unreachable */
74			}
75
76			export function shouldRowUpdate(nextProps) {
77			let result = true;
			0 ignored issues – show Unused Code introduced 2016-09-08 18:04 UTC by Report Bug Copy Issue Report The assignment to variable `result` seems to be never used. Consider removing it. Loading history...
78
79			// unique key created by setData action/reducer
80			const key = nextProps.row.get('_key');
81
82			const limitedNextProps = {
83			columns: slimColumn(nextProps.columns),
84			isEdited: isEdited(nextProps.editorState, key),
85			currentValues: isEdited(nextProps.editorState, key)
86			? nextProps.editorState.get(key)
87			: null,
88			isMenuShown: isMenuShown(nextProps.menuState, key),
89			row: nextProps.row,
90			index: nextProps.index,
91			isSelected: isSelected(nextProps.selectedRows, key),
92			isDragging: nextProps.isDragging
93			};
94
95			const limitedProps = {
96			columns: this.previousColumns,
97			isEdited: isEdited(this.props.editorState, key),
98			currentValues: isEdited(this.props.editorState, key)
99			? this.props.editorState.get(key)
100			: null,
101			isMenuShown: isMenuShown(this.props.menuState, key),
102			row: this.props.row,
103			index: this.props.index,
104			isSelected: isSelected(this.props.selectedRows, key),
105			isDragging: this.props.isDragging
106			};
107
108			this.previousColumns = slimColumn(this.props.columns.slice());
109
110			result = (
111			!deepEqual(limitedNextProps, limitedProps)
112			);
113
114			return result;
115			}
116
117			export const isSelected = (rows, key) => Boolean(rows && rows.get(key));
118
119			export const isMenuShown = (rows, key) => Boolean(rows && rows.get(key));
120
121			export const isEdited = (editorState, key) => Boolean(
122			editorState
123			&& editorState.get(key)
124			&& editorState.get(key).values
125			);
126
127			export const slimColumn = cols =>
128			cols.map(col => ({ hidden: col.hidden, dataIndex: col.dataIndex }));
129
130			export const equalProps = (props = {}, newProps = {}) => {
131			return props.height === newProps.height
132			&& deepEqual(props.classNames, newProps.classNames)
133			&& deepEqual(props.events, newProps.events);
134			};
135

bencripps / react-redux-grid

GitHub Access Token became invalid

Push — master ( c7ae88...35be68 )

shouldComponentUpdate.js ➔ shouldRowUpdate B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like