src/util/sorter.js - Code Metrics - bencripps/react-redux-grid - Measure and Improve Code Quality continuously with Scrutinizer

src/util/sorter.js A
last analyzed 2018-02-15 14:17 UTC

↳ Parent: Project

Size

Lines of Code

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
nc	1
dl	0
loc	23
rs	10
noi	1
c	0
b	0
f	0

1 Function

Rating	Name	Duplication	Size	Complexity
A	sorter.js ➔ ???	0	3	1

import { SORT_DIRECTIONS } from '../constants/GridConstants';

export class Sorter {
    constructor() {

    }

    sortBy(name, direction, datasource) {
        return datasource.data.sort((a, b) => {

            if (a.get(name) < b.get(name) && direction) {
                return direction === SORT_DIRECTIONS.ASCEND ? 1 : -1;
            }

            else if (a.get(name) > b.get(name)) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                return direction === SORT_DIRECTIONS.ASCEND ? -1 : 1;
            }

        });
    }
}

export default new Sorter();


1			import { SORT_DIRECTIONS } from '../constants/GridConstants';
2
3			export class Sorter {
4			constructor() {
5
6			}
7
8			sortBy(name, direction, datasource) {
9			return datasource.data.sort((a, b) => {
10
11			if (a.get(name) < b.get(name) && direction) {
12			return direction === SORT_DIRECTIONS.ASCEND ? 1 : -1;
13			}
14
15			else if (a.get(name) > b.get(name)) {
			0 ignored issues – show Complexity Best Practice introduced 2016-11-04 22:17 UTC by Report Bug Copy Issue Report There is no return statement if `a.get(name) > b.get(name)` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
16			return direction === SORT_DIRECTIONS.ASCEND ? -1 : 1;
17			}
18
19			});
20			}
21			}
22
23			export default new Sorter();
24

bencripps / react-redux-grid

GitHub Access Token became invalid

src/util/sorter.js A last analyzed 2018-02-15 14:17 UTC

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like

src/util/sorter.js A
last analyzed 2018-02-15 14:17 UTC