RequiredFieldsValidationStrategy::validate() - Code Metrics - Inspection of "Code refinements" - benanamen/perfect-validation - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 64a3a8...98d18a )

by K

created 2023-10-21 23:05 UTC

RequiredFieldsValidationStrategy::validate() A

↳ Parent: RequiredFieldsValidationStrategy

Complexity

Conditions	5
Paths	5

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	16
ccs	9
cts	9
cp	1
rs	9.6111
cc	5
nc	5
nop	1
crap	5

<?php declare(strict_types=1);

namespace PerfectApp\Validation;

/**
 *
 */
class RequiredFieldsValidationStrategy implements ValidationStrategy
{
    /**
     * @var array
     */
    private array $requiredFields;
    /**
     * @var array
     */
    private array $errors;

    /**
     * @param array $requiredFields
     */
    public function __construct(array $requiredFields)
    {
        $this->requiredFields = $requiredFields;
        $this->errors = [];
    }

    /**
     * @param array $data
     * @return bool
     */
    public function validate(array $data): bool
    {
        $this->errors = [];

        foreach ($this->requiredFields as $field) {
            $fieldValue = $data[$field] ?? null;
            $isFieldEmpty = empty($fieldValue);
            $isFieldArrayWithEmptyValues = is_array($fieldValue) && array_filter($fieldValue) === [];

            if ($isFieldEmpty || $isFieldArrayWithEmptyValues) {
                $msg = ucwords(str_replace('_', ' ', $field));
                $this->errors[$field] = $msg . ' is required.';
            }
        }

        return empty($this->errors); // Validation passed if no errors
    }

    /**
     * @return array
     */
    public function getErrors(): array
    {
        return $this->errors;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace PerfectApp\Validation;
4
5		/**
6		*
7		*/
8		class RequiredFieldsValidationStrategy implements ValidationStrategy
9		{
10		/**
11		* @var array
12		*/
13		private array $requiredFields;
14		/**
15		* @var array
16		*/
17		private array $errors;
18
19		/**
20		* @param array $requiredFields
21		*/
22	6	public function __construct(array $requiredFields)
23		{
24	6	$this->requiredFields = $requiredFields;
25	6	$this->errors = [];
26		}
27
28		/**
29		* @param array $data
30		* @return bool
31		*/
32	6	public function validate(array $data): bool
33		{
34	6	$this->errors = [];
35
36	6	foreach ($this->requiredFields as $field) {
37	6	$fieldValue = $data[$field] ?? null;
38	6	$isFieldEmpty = empty($fieldValue);
39		$isFieldArrayWithEmptyValues = is_array($fieldValue) && array_filter($fieldValue) === [];
40	6
41	4	if ($isFieldEmpty \|\| $isFieldArrayWithEmptyValues) {
42	4	$msg = ucwords(str_replace('_', ' ', $field));
43		$this->errors[$field] = $msg . ' is required.';
44		}
45		}
46	6
47		return empty($this->errors); // Validation passed if no errors
48		}
49
50		/**
51		* @return array
52	3	*/
53		public function getErrors(): array
54	3	{
55		return $this->errors;
56		}
57		}
58

benanamen / perfect-validation

Push — master ( 64a3a8...98d18a )

RequiredFieldsValidationStrategy::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like